Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     "Dr. David Alan Gilbert" <linux@treblig.org>
Cc:     npiggin@gmail.com, christophe.leroy@csgroup.eu, sam@ravnborg.org,
        benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: Use shared font data
In-Reply-To: <ZMOaz9EqqeaPGokA@gallifrey>
References: <20230725000141.165985-1-linux@treblig.org>
 <878rb0em3s.fsf@mail.lhotse> <ZMOaz9EqqeaPGokA@gallifrey>
Date:   Wed, 02 Aug 2023 22:19:41 +1000
Message-ID: <871qgl1vs2.fsf@mail.lhotse>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

"Dr. David Alan Gilbert" <linux@treblig.org> writes:
> * Michael Ellerman (mpe@ellerman.id.au) wrote:
>> linux@treblig.org writes:
>> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
>> >
>> > PowerPC has a 'btext' font used for the console which is almost identical
>> > to the shared font_sun8x16, so use it rather than duplicating the data.
>> >
>> > They were actually identical until about a decade ago when
>> >    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
>> >                         "broken bar" to "vertical line"")
>> >
>> > which changed the | in the shared font to be a solid
>> > bar rather than a broken bar.  That's the only difference.
>> >
>> > This was originally spotted by PMD which noticed that sparc does
>> 
>> PMD means "Page Middle Directory" to most Linux folks, I assume that's
>> not what you meant :)
>
> Ah, any good TLA is ripe for reuse:
>    https://pmd.github.io/pmd/pmd_userdocs_cpd.html

Thanks.

Unfortunately this patch causes a warning:

  WARNING: unmet direct dependencies detected for FONT_SUN8x16
    Depends on [n]: FONT_SUPPORT [=y] && FRAMEBUFFER_CONSOLE [=y] && (!SPARC && FONTS [=n] || SPARC)
    Selected by [y]:
    - BOOTX_TEXT [=y] && PPC_BOOK3S [=y]

And breaks allmodconfig with:

  ld: arch/powerpc/kernel/btext.o:(.toc+0x0): undefined reference to `font_sun_8x16'
  make[3]: *** [../scripts/Makefile.vmlinux:36: vmlinux] Error 1

I guess the Kconfig logic needs some more work.

cheers