Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230731141030.32772-1-yuehaibing@huawei.com>
In-Reply-To: <20230731141030.32772-1-yuehaibing@huawei.com>
From:   Xin Long <lucien.xin@gmail.com>
Date:   Wed, 2 Aug 2023 09:44:17 -0400
Message-ID: <CADvbK_e0n7Y28T6M=tX7htqp4HNdAnT_9FRBux_m46sgPXv9uQ@mail.gmail.com>
Subject: Re: [PATCH net-next] sctp: Remove unused function declarations
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     marcelo.leitner@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 31, 2023 at 10:10=E2=80=AFAM Yue Haibing <yuehaibing@huawei.com=
> wrote:
>
> These declarations are never implemented since beginning of git history.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/sctp/sm.h      | 3 ---
>  include/net/sctp/structs.h | 2 --
>  2 files changed, 5 deletions(-)
>
> diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h
> index f37c7a558d6d..64c42bd56bb2 100644
> --- a/include/net/sctp/sm.h
> +++ b/include/net/sctp/sm.h
> @@ -156,7 +156,6 @@ sctp_state_fn_t sctp_sf_do_6_2_sack;
>  sctp_state_fn_t sctp_sf_autoclose_timer_expire;
>
>  /* Prototypes for utility support functions.  */
> -__u8 sctp_get_chunk_type(struct sctp_chunk *chunk);
>  const struct sctp_sm_table_entry *sctp_sm_lookup_event(
>                                         struct net *net,
>                                         enum sctp_event_type event_type,
> @@ -166,8 +165,6 @@ int sctp_chunk_iif(const struct sctp_chunk *);
>  struct sctp_association *sctp_make_temp_asoc(const struct sctp_endpoint =
*,
>                                              struct sctp_chunk *,
>                                              gfp_t gfp);
> -__u32 sctp_generate_verification_tag(void);
> -void sctp_populate_tie_tags(__u8 *cookie, __u32 curTag, __u32 hisTag);
>
>  /* Prototypes for chunk-building functions.  */
>  struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc,
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 5c72d1864dd6..5a24d6d8522a 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -1122,8 +1122,6 @@ void sctp_outq_free(struct sctp_outq*);
>  void sctp_outq_tail(struct sctp_outq *, struct sctp_chunk *chunk, gfp_t)=
;
>  int sctp_outq_sack(struct sctp_outq *, struct sctp_chunk *);
>  int sctp_outq_is_empty(const struct sctp_outq *);
> -void sctp_outq_restart(struct sctp_outq *);
> -
>  void sctp_retransmit(struct sctp_outq *q, struct sctp_transport *transpo=
rt,
>                      enum sctp_retransmit_reason reason);
>  void sctp_retransmit_mark(struct sctp_outq *, struct sctp_transport *, _=
_u8);
> --
> 2.34.1
>
Acked-by: Xin Long <lucien.xin@gmail.com>