Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1030502rwo; Wed, 2 Aug 2023 07:47:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlGo2skTgVnX8RjBy08uWaphnOpC1LFGhqBiusPH8osRbUjex08duFb3XwxAdR9OLGdF7mqs X-Received: by 2002:a05:6402:12cd:b0:51e:eaf:4fea with SMTP id k13-20020a05640212cd00b0051e0eaf4feamr4509967edx.35.1690987650626; Wed, 02 Aug 2023 07:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690987650; cv=none; d=google.com; s=arc-20160816; b=MAKJpwELhRQZ+es211MLM6cCYczgrB6dYe9WPTa/7TREYZV8qzDh91mN0VqVWGQUSS DLg5rSDx3awrxylqTxwqUNA9DPmDmM1qKuMUm2RhSXItuwkaRxphqMN6OHAc43bmZ6GD BMSka6EEsa084RwV8SY3gwPKbsYDj5oiEk75IhW0pwptEWm35oJY0bI94ldAoOQ8Q1+z RozEuQcf41j63uO8wxsOBVPEF2Xgv3wlNdVC1KmcGvvbu2UTB9fWhE2AAwFIqXe4cGFs Nobs2wOOUlKqcjNkXYw0gOpghxI1ULnL6Z1Cn/Y9XWhsuDsYOpWQrDXaJ9h2WRPP2CsI 7RJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=l1a4G8aL268FEX2ri8M4EqsPSm9XjyfFiYzxQCZ1jUY=; fh=5U0G+4ux6ftRQKrr4U8wMKQ0y/euM+CNdOkiqrpTZXo=; b=K9a9F34SH8SKaGkox2eTdOJIKNtFxC1ZAqVlqC7zQEQ74ynn+6oVW4XrOPzDTw928q o2eoiJHfynG3RYyOHc555I+Pb5r33AimnyiCBBGzaFxlB6lJLi2L//eauH0tpjTfnZrP 39pmBDvSsg+lw9yfiiQl4oE0jK9yOD76AOoehHJl4AtQg5ghXLY+bTHPGTPiQgl+C6/N QI7gmvqMnzbmZ1QdpzwDehK7zJ6HJRG9hEU4dsMSCD/W49HIj/K7xtJp4etfkhWTPxPu WBvQ2kXQxEqlP3oXLhflA3oMN1/ucqLQS5oKU9XJ/RajggWiKRiDuCJQ2v68Dhe3HhL4 KN/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YohbpaZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020aa7d0cc000000b005219e26dddesi5671200edo.655.2023.08.02.07.47.01; Wed, 02 Aug 2023 07:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YohbpaZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233924AbjHBOeg (ORCPT + 99 others); Wed, 2 Aug 2023 10:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233854AbjHBOef (ORCPT ); Wed, 2 Aug 2023 10:34:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCB51723; Wed, 2 Aug 2023 07:34:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 35133619C0; Wed, 2 Aug 2023 14:34:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 575C0C433C7; Wed, 2 Aug 2023 14:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690986867; bh=OztTe/JGYQKST5Rzx0ZT6amRzhDvaMGUqnIJE6VGx4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YohbpaZyHT0oorRTEkwl4f/3SeZ1NyGum898k1JuJYOpJ4n9jkqLM8G1Fl9aGiJu2 tIi//knk87P+fmP2wsB4L2+5Mb9SZ76YXhupsgh4yIavybNpYEtorFGw8pT7Er3P1W jNdKtblXPyX2IQBRbgaa8DxBO5oc90Xl1jF4MkQaRhEEUr1tmpr7kQNAVASTxOuX4g GpHkCC5QoNjx5VYhtETBO7RQ12xvzJ9XZlRNpTqlk0yd64+eFA4xHARxcKNHWPWKWa D5X4T/XXHT3HT71OY61z/xJd7IC/4yCCt85vKva3gd74hatJ9ysA/lXwhNhNd+owui Iigk4K4170y2g== Message-ID: <50b82871-6308-21e1-77db-0c8793df196d@kernel.org> Date: Wed, 2 Aug 2023 17:34:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] usb: dwc3: Properly handle processing of pending events To: Elson Roy Serrao , Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org, felipe.balbi@linux.intel.com, surong.pang@unisoc.com Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, stable@vger.kernel.org References: <20230801192658.19275-1-quic_eserrao@quicinc.com> Content-Language: en-US From: Roger Quadros In-Reply-To: <20230801192658.19275-1-quic_eserrao@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2023 22:26, Elson Roy Serrao wrote: > If dwc3 is runtime suspended we defer processing the event buffer > until resume, by setting the pending_events flag. Set this flag before > triggering resume to avoid race with the runtime resume callback. > > While handling the pending events, in addition to checking the event > buffer we also need to process it. Handle this by explicitly calling > dwc3_thread_interrupt(). Also balance the runtime pm get() operation > that triggered this processing. > > Cc: stable@vger.kernel.org > Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM") > Signed-off-by: Elson Roy Serrao Reviewed-by: Roger Quadros