Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1035230rwo; Wed, 2 Aug 2023 07:52:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlFmfF6EI/MFpR9nwnYbrF1bnzUPGx0RsaDFR6l97pbGcd7IXTI1hfSws3lvdlL6aJnyWJKi X-Received: by 2002:a05:6a20:12d1:b0:13e:4dee:b1f4 with SMTP id v17-20020a056a2012d100b0013e4deeb1f4mr6819635pzg.31.1690987923484; Wed, 02 Aug 2023 07:52:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690987923; cv=none; d=google.com; s=arc-20160816; b=s+LDbSkowzVr1/Yl9CDXUB35w7cRIqX/ct11dh+zpi+C80cVX71ez9zVGSV0Nn3O/w OVupHnqiGe0PK5P2GAx5FnaJiplmpSb1K/SnSS2OCOhfsl4AGfkST74IXfvury6CvXGs Pu/Seg23fO+zNk7rreWg++acYV5qOpt56ccoI8yVn3F4am1Rtv7d23iHudoFh/8mdDR6 yPMwXeeGpoq1yfZ10nXHyaPocb5H42QiTfP7m6N9S24mf0iSd5nyPMEP7taQPzp9Fkhm qnCdqLuiXT6JJxGisqLLAy2hiDk3zlMWnlaSEQICy/zv2yaHygi6QVt3H8U0ZV+oxoeI CiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FfnsBQVxydqhiN/JB0ZUJwbiXvoySmM4wjN1KTJSqis=; fh=ljIlWyD6FHO9HlpeOfcegV5yAjXVPX6ce1fLa3+tlq0=; b=ryqhE/4A3HaO3vLAILO0KiQC2gC03OXaWFqBISWNY2wFHLajcmeC6GIOizvp4EinNK R64gclwwDus7HeQVcBKKlfAHuLf87GsTEoFH3jGGZI/lgaXGuAhxYM6w48k7jeSkjJIF RvxojJJihFU2/cHaxPHtysg/opLI9ls/w6m5GmrFlORst7EbYaDqrptAydHNytYyQIPe c3jfjfqw5sNMi5nzBi+dG+NnAeuqkzrAwbMZhcyeHCoCBGmvBgUb3SU9g/1nMbSUuYGq D3SkHhtUin3PunX8S9EBJqh4C62/VUQ19Imf/viQLUT0MrCMTnoG1IwxLLszqKDZXTq/ 0Rjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=A6sVvDW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc33-20020a056a002e2100b006872b49c1aesi6479407pfb.133.2023.08.02.07.51.51; Wed, 02 Aug 2023 07:52:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=A6sVvDW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233769AbjHBNRg (ORCPT + 99 others); Wed, 2 Aug 2023 09:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjHBNRe (ORCPT ); Wed, 2 Aug 2023 09:17:34 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F210B1718; Wed, 2 Aug 2023 06:17:33 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 372CgH2d012943; Wed, 2 Aug 2023 13:17:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=FfnsBQVxydqhiN/JB0ZUJwbiXvoySmM4wjN1KTJSqis=; b=A6sVvDW1i9TLsZN6ImAMO4aSa/ATIHoXv4BVv6OB3V/7HRuOUZGG/0NLnP2doeSX+GAG V6Un5eWORfbnsDINlVXnqLnBxgweQe5Q/xlmvxIDal0UWGgKJqG8la2dFgSN0i71zaO0 j4Uuo30LfQ5B8p1A6joaezS8UReTHL29gs/Ty8+X1a42Woucuab7e8Egekcv9bVNc5Jn yrtjv1ekFkKezcD8UogXRd3SPWs3up4wyk/lP7pevU+jSAY5SFs/ImEoUmccXuZ7WSju 0M3gxgln1IbYdz9HAkCyjP/uGC0aioHphB2YK+L0GvL/BSIR8BF17rFRW5kdeoVnVOJ5 zQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s75b32fdw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Aug 2023 13:17:29 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 372DHS0g009177 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Aug 2023 13:17:28 GMT Received: from [10.214.66.58] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 2 Aug 2023 06:17:25 -0700 Message-ID: <6653d101-c9d8-fff6-46af-149a2f28e4b6@quicinc.com> Date: Wed, 2 Aug 2023 18:47:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65 Content-Language: en-US To: Konrad Dybcio , , , , , CC: , , References: <1690970366-30982-1-git-send-email-quic_rohiagar@quicinc.com> <1690970366-30982-6-git-send-email-quic_rohiagar@quicinc.com> <51902449-11ea-508e-002d-b4b772ffe754@linaro.org> From: Rohit Agarwal In-Reply-To: <51902449-11ea-508e-002d-b4b772ffe754@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kU7QnUqe990pmFuoe5Tq1aOrxpjLUTf5 X-Proofpoint-ORIG-GUID: kU7QnUqe990pmFuoe5Tq1aOrxpjLUTf5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-02_09,2023-08-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 mlxlogscore=654 bulkscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308020118 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/2023 6:16 PM, Konrad Dybcio wrote: > On 2.08.2023 11:59, Rohit Agarwal wrote: >> Update the pmic used in sdx65 platform to pm7250b. >> >> Signed-off-by: Rohit Agarwal >> --- > Has this changed with a board revision? Was this wrong before? > > Need more explanation, and this definitely deserves a Fixes: tag. Just went through the sdx65 pmics and found this mistake so updating here. Although the validations were successful with the earlier pmic as well when originally pushed the patch. Will add the fixes tag. Thanks, Rohit. > > Konrad >> arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts >> index 02d8d6e..fcf1c51 100644 >> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts >> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts >> @@ -7,7 +7,7 @@ >> #include "qcom-sdx65.dtsi" >> #include >> #include >> -#include >> +#include >> #include "qcom-pmx65.dtsi" >> >> / {