Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To:     linux-arm-msm@vger.kernel.org,
        Ekansh Gupta <quic_ekangupt@quicinc.com>
Cc:     ekangupt@qti.qualcomm.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com,
        stable <stable@kernel.org>
In-Reply-To: <1690984656-11761-1-git-send-email-quic_ekangupt@quicinc.com>
References: <1690984656-11761-1-git-send-email-quic_ekangupt@quicinc.com>
Subject: Re: [PATCH v4] misc: fastrpc: Fix incorrect DMA mapping unmap
 request
Message-Id: <169098840645.77008.10424849723734584416.b4-ty@linaro.org>
Date:   Wed, 02 Aug 2023 16:00:06 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Wed, 02 Aug 2023 19:27:36 +0530, Ekansh Gupta wrote:
> Scatterlist table is obtained during map create request and the same
> table is used for DMA mapping unmap. In case there is any failure
> while getting the sg_table, ERR_PTR is returned instead of sg_table.
> 
> When the map is getting freed, there is only a non-NULL check of
> sg_table which will also be true in case failure was returned instead
> of sg_table. This would result in improper unmap request. Add proper
> check before setting map table to avoid bad unmap request.
> 
> [...]

Applied, thanks!

[1/1] misc: fastrpc: Fix incorrect DMA mapping unmap request
      commit: 3042d44f7e49c74f2928b4780c66564632449bab

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>