Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e82ec662-22d9-b331-0880-886bd28624eb@amd.com>
Date:   Wed, 2 Aug 2023 09:10:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 2/2] PCI: Don't put non-power manageable PCIe root
 ports into D3
Content-Language: en-US
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
        linux-acpi@vger.kernel.org, Iain Lane <iain@orangesquash.org.uk>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
References: <20230711221427.GA250962@bhelgaas>
 <b82a50eb-8182-84ca-5b24-dbe8870fa871@amd.com>
 <CAJZ5v0i6PviqW7u3i8hmvSCvR_VHqP-mWRy3Da8Ev_1vi9qBQA@mail.gmail.com>
 <a309e3fe-b1f9-e269-cb97-8af87c8d483b@amd.com>
 <CAJZ5v0jvxrDMR6YHFpYZ4yYpp82-3TtrH==SMRFtUMJsv7=i=g@mail.gmail.com>
 <37b005d5-68fb-f8dd-67e2-c953d677fca2@amd.com>
 <8298c01c-abec-914b-0542-459f38c635fe@amd.com>
 <CAJZ5v0i3g0JujMwikB8niRZ93hXJZqWtjrCjbaDmkMLUbMmwMA@mail.gmail.com>
 <d1b2cf1b-de5f-6c2e-c8dc-fdf60cd0882d@amd.com>
 <20230802052601.GM14638@black.fi.intel.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230802052601.GM14638@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzkzRG85ZFJVVGpxeDgvV2dJVnJUYlF4T0VmWURWbnFxZVhwR2QvZFpIclpn?=
 =?utf-8?B?TndkYmRnTFJTYXZCbTdaTUdaY2Rqa21TZlNKTVZ3SWlEb3hiRGd0UkNVWitO?=
 =?utf-8?B?Z3diNjJFem00SU9lait1SnNuZjFobWJGNXVGbDdjSXVLZE83Z200MHNBdlpl?=
 =?utf-8?B?TEJxQjkvK2lpN1lWRkw0L096M0dvNG1zcXVaNzRrU3RLakxsMm9TNWQ0Y0tl?=
 =?utf-8?B?VHVSc21meEc0N2MrbDZOeUhhZUhGNStiajhPZGhBYk40dnNkWmpMd20zcis1?=
 =?utf-8?B?Q1RzQUdPbGczeFpldHRnWUNiaTM5OFRTTUxUVUxjbndRaGhUcVNHVGlEZWhu?=
 =?utf-8?B?VTExZUN4dlFDSW1pTTAzL0phc1JTVG5pZmF1WUE4MGZkYk00M0VrMW45UGsw?=
 =?utf-8?B?K1d0Q055TG1pOFlnSW5HUy9PVmU5OUpGVHB2MjRZSjlRN0dxQk5KMEJtN2hE?=
 =?utf-8?B?eFllUmhHVEc3ZkhWMHN2aTVwRjB6eHo3Y2NKamJPUHNGcmVCa293YU50eDVa?=
 =?utf-8?B?WWVyT2YxYXhSYllSaE5ZdnJFUnlUQWNQR1JzZ0JJSjA3UWo2dW5QTDY3c1Fx?=
 =?utf-8?B?TW1WeTlCcWtma0FIMy9Sd2dsbTlTOC9tTjBWS1c2K0lIRms0eWdqeVdiSkVQ?=
 =?utf-8?B?emRVN0xqZTBOTGJWU0dGU3NGVjNoZHFONWMzaHpSMFJyVEV3ckliTlZONE80?=
 =?utf-8?B?TUV1MHR3bnZEUnlKZ05oUEJETEZRWkZPYTc2NVErR2tKKzVpbEVZNTNnNE9H?=
 =?utf-8?B?ckZtT3plTXg3akV3czFMZ1FZK1hXNHlFRVEvS1dJSUlFWU9vVUFEWmRpaEZT?=
 =?utf-8?B?cERGYjNXOGcxQXVUOUFVNHlYdFdEbzZiMHk3NzVCZlg5T3FUenNZdUVUUW0z?=
 =?utf-8?B?WHhuVlZOczJnWDdZdjhvQnI4dnVHSnZDdlhSVEJYUWJuNGlqdUhQaVB2eldZ?=
 =?utf-8?B?MnZwNmRIVStvSHpLRE96Q0xVTlUyT3krd0tvMFV3bitUTThRYVlXVTBlUGNE?=
 =?utf-8?B?WU9UUlVRcTd2Y25PSXROVnAwSTQ5Nm4xdDRzVlhoaVlOSnJUK2FqdzR1ZzRH?=
 =?utf-8?B?djFNMXBVSkVYMnZqZFRYdzhERVVrM3pEWXFwck85bE1zMURyVXpOclVuOXZr?=
 =?utf-8?B?SjJvNld2ZExUcUtSdjduNmtNd3dqeHhDeUFBUmdYckxlSkFlbHdWeS9WQUFE?=
 =?utf-8?B?SzB0QXk1YUttRUhaOCtrTnpHdUdmRS9iNElmblV3NmU2Z3NNYTBZcEswbDZr?=
 =?utf-8?B?K0dSREU3U2tXS0RUSFgwVEo0MzZ1M0FmcDVLN0d0YlM4Wks3L090YVJCaDZF?=
 =?utf-8?B?dngvaWdlTWJVZXVOSVI2WktMblV3QXlLaDNYUFlNR3JnMFdLcVp1NEJDcnd0?=
 =?utf-8?B?VE9DQTlyUU96cEJESWFncVVBZXVLektOclJDVGlOcE43ZGp5cG96SFV4b21M?=
 =?utf-8?B?M2w5Y3d3TTl3eWpvQzN2UEV0THJHalBidWRVcHVncEpLTjk0c0NKeXlxZEU3?=
 =?utf-8?B?R08zNlFpOEtveDA4QmxLR1BMODhCc3ZuQ043djlwQnZ5cndwcTZnMUV3MWRW?=
 =?utf-8?B?ZFhYYW9kK2RITDJRNnBuUFJnSXI2MzI1ay9KNWZDK0drVVZocmxISHFKSHp4?=
 =?utf-8?B?b1BWbHRWbU5HckJGMDNKWlFiaFBzRTVORjdVdjBsZytwQzZhS1U3YlZvV0Qw?=
 =?utf-8?B?OXh5OVB4WHYvUVRSaWZuTTVFd1hoZDgyWjVDVXp1b0xQMnFmd3l5VExpZXVC?=
 =?utf-8?B?bDBHaHFTc1RyLy9vdUp1Yzc1bE1NWDFoRGxvSW1TL3MxazBsdUtxVXlGUHBa?=
 =?utf-8?B?Myt2Qm14dVJjaWh1Q0laVEpscjVIckEwWU5NWTl4VlNnRGpmdDU0elhGeDRM?=
 =?utf-8?B?Q1l2VEZQYWJwNlFiUFovMmZoNlVwS0kvOWJRaTNld05Nck9FTmJ2V3pMci9j?=
 =?utf-8?B?V2Y0VUZ3RlFrcGZvQ21BQXYzRmpLU1FDRk4xVmh0Zyt3UmJUS0g5cDZnOENT?=
 =?utf-8?B?bTM0TnZpc1EwclNnL2lMeEt2VWpYaE84VWRlN0RrejNzamVQaUpPay83MnRn?=
 =?utf-8?B?SEkwRWdzVGtzUWkzOVVmS0Jka0JuaFlid0hyNHNIU0h3UWowMW5BVzV5MWxM?=
 =?utf-8?Q?OxfAYIaoUybWcc4ahMpxjp/p7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 805cbfef-2ca3-46ed-c52b-08db936247a3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:10:52.2315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 55bFdmv82W57Iad2w1Ma+RUm9UMe6lPe3KfC4N4nMwgdtd6eQrbRaNtooZBNh7k1u+dd2GYEiujNNOBZgHq63g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7540
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/2/23 00:26, Mika Westerberg wrote:
> Hi Mario,
> 
> On Tue, Aug 01, 2023 at 10:17:11PM -0500, Mario Limonciello wrote:
>>> Consequently, platform_pci_bridge_d3() will return false and the only
>>> thing that may allow the port to go into D0 is the dmi_get_bios_year()
>>> check at the end of pci_bridge_d3_possible().
>>>
>>> However, that was added, because there are Intel platforms on which
>>> Root Ports need to be programmed into D3hot on suspend (which allows
>>> the whole platform to reduce power significantly) and there are no
>>> ACPI device power management objects associated with them (Mika should
>>> know the gory details related to this).  It looks like under Windows
>>> the additional power reduction would not be possible on those systems,
>>> but that would be a problem, wouldn't it?
>>>
>>
>> I've been thinking on this today, and I at least have a hypothesis about
>> this behavior.  Perhaps Windows is actually utilizing enabled PEP
>> constraints to enforce what state device should be put into over Modern
>> Standby cycles in the absence of ACPI objects.
>>
>> In the case of one of my problematic system the PEP constraints for the root
>> port are:
>>
>> Package (0x04)
>> {
>> 	0x00,
>> 	"\\_SB.PCI0.GP17",
>> 	0x00,
>> 	0x00
>> },
>>
>> That first 0x00 means the constraint isn't actually enabled for the root
>> port.
>>
>> Mika,
>>
>> Could you get an acpidump from one of these problematic Intel systems so we
>> can check the PEP constraints to see if this theory works? Or maybe you have
>> some other ideas why this is different?
> 
> The patch adding this was merged in 2016 and unfortunately I don't have
> any of the ACPI dumps from them available anymore (and do not recall the
> details either). I think these were Apollo Lake-P based systems with the
> initial runtime D3cold and S0ix support at the time.


I scoured the web looking for acpidumps a bit an Apollo Lake system and 
came across this random bug report:

https://bugzilla.redhat.com/show_bug.cgi?id=1591307

"Intel(R) Celeron(R) CPU N3450 @ 1.10GHz (family: 0x6, model: 0x5c, 
stepping: 0x9)"

I looked at the acpidump, and I notice:

Low Power S0 Idle (V5) : 0

That means that Windows wouldn't actually be putting it into Modern 
Standby at suspend but would rather use S3.

Considering that result, could we perhaps adjust the check to:

if ((c->x86_vendor == X86_VENDOR_INTEL) && !(acpi_gbl_FADT.flags & 
ACPI_FADT_LOW_POWER_S0))

Or could we quirk the PCI root ports from Apollo Lake to opt into D3?