Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 2 Aug 2023 08:05:30 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Carsten =?iso-8859-1?Q?Spie=DF?= <mail@carsten-spiess.de>
Cc:     Conor Dooley <conor@kernel.org>, Jean Delvare <jdelvare@suse.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022
Message-ID: <fc0b3cf7-3bd5-43a3-a1fb-5706180774b7@roeck-us.net>
References: <20230801163546.3170-1-mail@carsten-spiess.de>
 <20230801163546.3170-3-mail@carsten-spiess.de>
 <20230801-implicate-mullets-bd160bbda4b2@spud>
 <20230802093023.1a926c9f.mail@carsten-spiess.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230802093023.1a926c9f.mail@carsten-spiess.de>
Precedence: bulk

On Wed, Aug 02, 2023 at 09:30:23AM +0200, Carsten Spie? wrote:
> 
> On 8/1/23 22:52, Conor Dooley wrote:
> > On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spie? wrote:
> > > Add dt-bindings for Renesas ISL28022 power monitor.
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - renesas,isl28022  
> > 
> > You've only got one compatible, why the enum? Will there be more similar
> > devices that have an incompatible programming model?
> Yes, there are isl28023 and isl28025 with different register addresses,
> might be supported in future releases.

This is misleading. ISL28023 and ISL28025 are PMBus compatible chips
and would be added as PMBus driver(s) (if needed). Support for those chips
will never be part of the isl28022 driver, and any devicetree properties
of those chips would not be described in this file.

Guenter

> 
> > > +  renesas,shunt-range-microvolt:
> > > +    description: |  
> > 
> > You don't need these |s if you have no formatting to preserve in the
> > text.
> Will fix in v4.
> 
> > Otherwise, this does look good to me.
> Thanks, regards
> Carsten