Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <18fec8cd-fc91-736e-7c01-453a18f4e9c5@intel.com>
Date:   Wed, 2 Aug 2023 18:11:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K
Content-Language: en-US
To:     Ratheesh Kannoth <rkannoth@marvell.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20230802105227.3691713-1-rkannoth@marvell.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230802105227.3691713-1-rkannoth@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHJja1VwcURNMVIxZ3AvL1JmZUxVUlFrelpJR1NxeTkyN1FZcyttSTlDd3M0?=
 =?utf-8?B?enNBT0NlUit3S1Z2QUlmU0x4QnhtdHVxRzQxQ2JQUWs5QzNUd3hEdzd4ZTNs?=
 =?utf-8?B?bk9NcGNRamFNdUhFclZkbERmKzBLL1BQMmh2STZIZk1HNlVGRnpiOHVaeHlp?=
 =?utf-8?B?MkZhQVRESXpUWG01ek1mQnhGQzJFQjZwUm1oVW9RUklHMlUwU0s4MktVVWwy?=
 =?utf-8?B?bWtZaUtERG12OUdFNTB3a014MWlHTVFVU2pudGkvcEFFVDdGVHpXdU9QQURV?=
 =?utf-8?B?bjQ2RENZUGd6MW1jVzhDQjQrajZaL0YxQ1NNbWVGcUhJLytDNWdXUE0vTXhu?=
 =?utf-8?B?VFNMaFZHSFZzd0xiTm1OYWVVOXFkTlpKMUdvSnpoUmd3bUNvNDlnc1MzQTZz?=
 =?utf-8?B?dWliTzdNcThXcU45amxPRWF4ZnlnUXNMY0JNNXlwU0NUUkJkbXJ5dk53ZExO?=
 =?utf-8?B?Z0kvSStxNERxRlY5Zlo4bGZyR01qZ0YrbzZlQUpyTGRzdGV2QjBYTUdMdUlH?=
 =?utf-8?B?N210eWt6NE1hbnpFY2NkTGdKY3hCVjBaMmdEd1d6RDVJYll5TXhFMWlLQkFq?=
 =?utf-8?B?ZnJUc0E0azFFajU0SE81M3h2K3V1UUZ5Y3N5UWQvNytVaVQ5cnplcWlUeWFG?=
 =?utf-8?B?TG00Q0xnUG9LTlNkRVkrcWlKMDlmUkZJb28wdnhjS1RMUzNrVndrTzNDQ3dY?=
 =?utf-8?B?TVpETlNkMGNha1UwN3VzSnpEaWpXZ1FmeXNFTGpkNHR5TkdQU0Ewa2lwdFUz?=
 =?utf-8?B?Q3NNcWcyVW93dUFqZVJLdGd0SWZudnQ4eTBHZm1xZ2p2dlUzQ0xDNEpoSTUx?=
 =?utf-8?B?UGFZV0xRT05IL20zdnIzTDZUKys2Umd1TkdobVlIS25waVdETkN3b2ZBZFh4?=
 =?utf-8?B?TGtONGM2Y1ZBNlhyMDRkZGJNNmcvV2pmOWY1SnNlK283cWZFdFVZZzd3V0Fz?=
 =?utf-8?B?VkJ4UTgyZ21SZ2c0Qkh6RWhPMkJMNDZpQnlDRkJiVXNYM01HVVVRajRZSTNB?=
 =?utf-8?B?TEh5QlpQTDZuaDRxWUJBSXBsb1VvdHFPcUVrT3hEVXhqSVZtcXBlV0UwOGNE?=
 =?utf-8?B?amdweDlDRHA2TnU5UHRpbmp2QjVZVWtySHFpYURPamFTcjlRT1JNMk1WWGdx?=
 =?utf-8?B?d1RtQ0Y3U2FmeS9WUVRYcy9zOUR1QzJzaXlFMDRiZ1h0N0VsRFJXNlFyWW00?=
 =?utf-8?B?eTZZTzR4clAwK1NBVjlVbjlHQVFxNXBxMmViNy8xVzRjcHZzSWxnL2tYNVd6?=
 =?utf-8?B?Y09NdWFZWC9RaWVWOFBKK0xSa1FPUCtFRy9DSWVVZVpJZDRac0hhN1VxVWY5?=
 =?utf-8?B?YStTcUxYRlZEMWYzeitoVTAwdmlCYkFuOTAwZGVzOWtXQWN3L2xHRm1jZWtn?=
 =?utf-8?B?MVp2cUFINWVYV1lmMWtGUXZhaGNQeGxJU2psMUVkdzNIQzJQVXlSUFhRY25v?=
 =?utf-8?B?Tk45eUo2OG50cW04dUhHTlVxcUtST1VXa0E2OFU3czJpanFMb2dsUFFyYXRk?=
 =?utf-8?B?V0ZmUnNMSVRjb2lYY3V5L1NOZ09YYlJqL2tFdkMvc0tmQktBSTJ6cXVIUjZM?=
 =?utf-8?B?YldlMkgrS1VuYTJ2Wm55YVVoeGdJcHNYNkVRaFMyOGVPVmNkdUwxZ3A4T3FP?=
 =?utf-8?B?QU1PMW5HMHBLbWc0S2QyZmRSbnd3NGRqZEVDWVNndE1xWXlYaEhWOWJDNGE4?=
 =?utf-8?B?MXVJR0J1Sksxb3JRRWtIMDR6M2kyeXRtQ1VpUjB3YmV4WXE4RDF4eitZM3RB?=
 =?utf-8?B?UTFidXRmQlJ4ZkVIYmxYMzVnaWM5WUErUG1tUnBSVGF0cm9lNVI2ajhnbnQx?=
 =?utf-8?B?Um9kWFduZTRaazFqTldYVG8wb3hYOWxTTkx3U0Jpek5vd2d6Z1ZsZkRnQkNL?=
 =?utf-8?B?aFpTTXBtNi9wNjRJak9xTTA5bHNGMlpuSEFxcERTMFBGZUNNWVh0SFB6NFE1?=
 =?utf-8?B?dkdiYUxPQlg0NGJMcVl6MCtzUndZei83dnE1NzBwU0JLSHZTa3puUlZodW10?=
 =?utf-8?B?bEhaRmEzajhXcTVUTTI4c09iQ01MTHphdzVibmM5cjA4UHNvSE91blhxdSs1?=
 =?utf-8?B?RlF1TXk2VlVsUXRKVWI1VmlBb0dCMjdaSUszWjVQR21CUWsxZVhxMkZqZG95?=
 =?utf-8?B?NGVOdzVONEJNZHNQd3pMWG93UGVSOTFNT3VJSW1UOGdLaUtIUTNwQnNPNG95?=
 =?utf-8?B?RUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aafac81d-4609-460e-4fbd-08db93736bbc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 16:13:34.3303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UsjGe8htcSauST2adVbJFiC2H12vfrKSS2K1ul9K9ogIn3Xhh/uIkeLu+IbnAiFiAxjiQvoKvgqRr/5YrGqc4WlkaHfT3OnjUOJDpq08lTU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7704
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Ratheesh Kannoth <rkannoth@marvell.com>
Date: Wed, 2 Aug 2023 16:22:27 +0530

> page_pool_init() return error on requesting ring size > 32K.
> PF uses page pool for rx. octeon-tx2 Supported queue size
> are 16, 64, 256, 1K, 2K, 4K, 16K, 64K. If user try to
> configure larger ring size for rx, return error.
> 
> Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> index c47d91da32dc..978e371008d6 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> @@ -378,7 +378,7 @@ static void otx2_get_ringparam(struct net_device *netdev,
>  	struct otx2_nic *pfvf = netdev_priv(netdev);
>  	struct otx2_qset *qs = &pfvf->qset;
>  
> -	ring->rx_max_pending = Q_COUNT(Q_SIZE_MAX);
> +	ring->rx_max_pending = 16384; /* Page pool support on RX */

This is very hardcodish. Why not limit the Page Pool size when creating
instead? It's perfectly fine to have a queue with 64k descriptors and a
Page Pool with only ("only" :D) 16k elements.
Page Pool size affects only the size of the embedded ptr_ring, which is
used for indirect (locking) recycling. I would even recommend to not go
past 2k for PP sizes, it makes no sense and only consumes memory.

>  	ring->rx_pending = qs->rqe_cnt ? qs->rqe_cnt : Q_COUNT(Q_SIZE_256);
>  	ring->tx_max_pending = Q_COUNT(Q_SIZE_MAX);
>  	ring->tx_pending = qs->sqe_cnt ? qs->sqe_cnt : Q_COUNT(Q_SIZE_4K);

Thanks,
Olek