Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 13:07:02 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     akpm@linux-foundation.org, torvalds@linux-foundation.org,
        jannh@google.com, willy@infradead.org, david@redhat.com,
        peterx@redhat.com, ldufour@linux.ibm.com, vbabka@suse.cz,
        michel@lespinasse.org, jglisse@google.com, mhocko@suse.com,
        hannes@cmpxchg.org, dave@stgolabs.net, hughd@google.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        stable@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mm: for !CONFIG_PER_VMA_LOCK equate write lock
 assertion for vma and mmap
Message-ID: <20230802170702.cj6vwixrksqsdqp6@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, jannh@google.com,
        willy@infradead.org, david@redhat.com, peterx@redhat.com,
        ldufour@linux.ibm.com, vbabka@suse.cz, michel@lespinasse.org,
        jglisse@google.com, mhocko@suse.com, hannes@cmpxchg.org,
        dave@stgolabs.net, hughd@google.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, stable@vger.kernel.org
References: <20230801220733.1987762-1-surenb@google.com>
 <20230801220733.1987762-3-surenb@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230801220733.1987762-3-surenb@google.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OGP6zOnoUnBc6ix7WkxcTMO2+AiswfKkk7RB4o0vpXvTkPMvX11FEAwlUUc/?=
 =?us-ascii?Q?loS1lCdG3/JEHHDF3Fe/43nKcYi5I91R4Wf7sqRvCSvUxKxNypoCdcR5I2u2?=
 =?us-ascii?Q?+/xgsapL5/nPfVcNJzrw6QfWAlpZhAWyapONFHpPcYz6CeHOcZgy/61QlGWG?=
 =?us-ascii?Q?I7icb0s1c08uUMC/3prsmhs6DNO4/U4RFJ3qEeXrT+nC9hsN7FpxqtaH6/Wh?=
 =?us-ascii?Q?gDX2TMglyUd0CCv3ZsCmNOEKdZ9ONchMAENBi3T4wLG2cjjQsFrTPjJnrJoh?=
 =?us-ascii?Q?QJNxp9KWlBk8X4OZp5o51tXjWCKCzNpjGfLoqE50/uowX/53Qi7e4VRfoNhC?=
 =?us-ascii?Q?+CfB5+uoFCm5aMWYXdidse4QFqYyibFeDYHJYm/6VJplmOv1HfLn1O5zUIDU?=
 =?us-ascii?Q?rcTHX0sovi+XzV3G1wyopoEo3xGoUViqW2e3UNzO+cuBfTGLH0HFg46mDH8I?=
 =?us-ascii?Q?YsQFzqhYxaxajuCOro8ciqcms4Te0nq3FMlyaqJkXF9IZ2nF/P0pGJzG0T2X?=
 =?us-ascii?Q?eixQA8/Hs8s7aN1/EyL2k3zAlj4er0z4FJn5H9pfcmdj+ZvWWJTK35zLMhYx?=
 =?us-ascii?Q?G+G9Fba2pLZpXaeEJOwvs6e96t0OVdQntQCiaxgIIK1KwCJRNz7GsTp/OJER?=
 =?us-ascii?Q?PR/S42YCDjvq5zL1SZBMU4e2IMVsyogXiYWJw/upuqb0EV5qUvXPkcGiK+Km?=
 =?us-ascii?Q?4wiJibOsH+yOf7uaAYnG2QfbN8Nfs44+D6YwbHKm+lzo75BywO4H1I85tqoe?=
 =?us-ascii?Q?4rofPrhPSXq3TvNPbVUVQZqLC0NA6jkAVVV4wvVTCsxwECBbp3eoIfQU0fMd?=
 =?us-ascii?Q?Jm+OYtd1ts5CN5CqoTr8Dh27mrzecGlyJlGFEQh3qrnUJX2gVT4qa6zfTuGt?=
 =?us-ascii?Q?2LqNCmCpaJhZE3fpoWcUrmfXBpPY3ekyKsTGWWosV5P9fY2kJZcwI9mRWZ4n?=
 =?us-ascii?Q?uWIv446F0gyOmheG7m9qGW4ljZUdW9H0F//hA+Pqbfs1MZvsf1H4M6FEZzWT?=
 =?us-ascii?Q?7xiYEMbQ5622arSfaFbcxG2N95mgP1rjeFUgkfX9WCzK3Rpv0iiJdp4hIhLv?=
 =?us-ascii?Q?nj2pb3EQ948P8qUWWSdhUMWpmo/PU8ji1F/hT3TJiUWVMHuZz2KBSBft6P/g?=
 =?us-ascii?Q?qTny2gnFihdT2Ti/JeqEosTkFbJt/8CzEBmePlQ8OUgh2Bns7ZF8+n4lN9KB?=
 =?us-ascii?Q?5vg60512GmtA0WTVLfOKRt5uyzlB3ct7M/FK4VK4kckr4PjlTLHsIx1GV7aT?=
 =?us-ascii?Q?7EgdM4DBoriLBnjcVjc3DgGoXt1dABNsHF21G+kvPOCFW4wMKakoVBkoEqSo?=
 =?us-ascii?Q?uBfUkrGX2vELzzek4f6pS7TIe0PnbvNCXqcmp5qy9I9XNbCAFSKWiT0mmSjE?=
 =?us-ascii?Q?hGksepexoabPGV6E/C1IsxNi86sGNhPxHazGecmmsc/aZqr+Alze4/PbbxB5?=
 =?us-ascii?Q?goKEnbYVL+/8ZH+qCnVUbCmP+jbJuDpMlafOAI+3nvhW6r97AkmtihBX1yEl?=
 =?us-ascii?Q?1P/IueCEAkHNRctoRb+oytHvtpbJVzMNpy1gXYoPk41A4jkTLrkn2HKE/Onc?=
 =?us-ascii?Q?2YSlRaMn3CxGv5HaBWbQVLciebu+3C8rHwW72VwGiqgTrUJuNhPmoP9WEa+y?=
 =?us-ascii?Q?tA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?8KVUu5Qa4XcoSmzZneGlLdQcYX9jSHZXIhJQr/RK6AomJpRERt8AwzAyrB6/?=
 =?us-ascii?Q?sSvVzkYsYW0wn7MjZeKTMPP1SbUKeF7jpXhafLSrL2A1v4RPSCF9D5ToWwPP?=
 =?us-ascii?Q?aO0kuJmfyz+yZAYWMs5J2CLEDDO9HKjG73eox7enD5sdSZUfcH+LL9oPdiHF?=
 =?us-ascii?Q?KcX8xXF/+nqM63Sgn46BuV+664gE09Q2cadQjcma9GNHNwyP8REUSRlmnYgL?=
 =?us-ascii?Q?+8MIbyXKF12uGpgB3ifhSq4J/FlKe6anqdKhl4IyDP1eo6bPRMF74nU/iM0f?=
 =?us-ascii?Q?zszG6mbmqfVVYBPMMNObaoqY5GQFfeB5HYtmN65HLIF2lNKU2EfEvuVKBeYo?=
 =?us-ascii?Q?rOPA3q43xL5kCi2dCyV6CFwtYSUxzxf2Qa7Np5F6fJ5mFSY9GG5SaZl4agrc?=
 =?us-ascii?Q?LQZpLQWieWTNVL35k8YriU8MDKHDCsrp+gb5frc7hIoWZeODODeiPDONtKvR?=
 =?us-ascii?Q?KNB1m3xDbbxkbGGbzDxYBW8ZGY8mwNRda8aciziC8HddUYwmpFhcmOsYkhNP?=
 =?us-ascii?Q?EcRkJ3gUAIuJ9x8/qhc9QtO1P/yP82/08JDCJZGh/RU/79uoIwwCfaKO0evv?=
 =?us-ascii?Q?UFba35jslMkzRQAijBz697oUSInrPgX8LrvP+/JkdaZgnjKL6YC+PxjJ01hS?=
 =?us-ascii?Q?KZ0y/acPhxwyLJa3RkM7LuzFWqu5vTkSMSQ0p+Bo6g9de0c0lG7t8uuSWt5D?=
 =?us-ascii?Q?vVvxhb9KClA4e7BY6NafCkr/IHhWlmMeMFoTuNgybMMy1gIxV5yl7c1Wib6e?=
 =?us-ascii?Q?2MSnGEES7rHSOYq5sFdWlgCRLANxtr1FoBW32gyXSzmy/1cQe61X4grg0/lN?=
 =?us-ascii?Q?Whgf3v/YHsrd6ALeLZ8uqchbAleOBPtgeAz6sx7ME8VrFK5zjT2UbDMsCorQ?=
 =?us-ascii?Q?Zm4lfdaD9IzBha+e+cFyTvYb+Cq5T61REYcuMvZIK/mkJ3lIw+oatpj2qFXA?=
 =?us-ascii?Q?sz4XNREFRnrsYkn+AUY0ecf/q8xLlgHjV/zcN3CdYUtxZmHuRX1nMMjB1Yox?=
 =?us-ascii?Q?+JFf6WaG72r/PGXXcX9xszS5blohs+b/HGsgMdidB3xQUrUp6Dpr5gdrBIbu?=
 =?us-ascii?Q?SCNlESzfoNn9JmOTw6CyvZ2YGtCT6C3KQ1rYs6rY9JH7+UxBiJOQVPa2TT0D?=
 =?us-ascii?Q?KpVLXGw4KwPc?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a34e43f9-967e-4cc4-24c6-08db937ae634
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 17:07:06.1466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RTqA5Oag0UwBRUuPG1sHZsHwEVJoT1hZRyhDTEwUVl61ag9Eeuq/pNrJ29Ag7VNVJY2wn8ucrSnIj9zIPU7QMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7101
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-02_13,2023-08-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2308020151
X-Proofpoint-GUID: 1BCQ5YoW6EUAMizRXrR7uyH67SMkfvgI
X-Proofpoint-ORIG-GUID: 1BCQ5YoW6EUAMizRXrR7uyH67SMkfvgI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Suren Baghdasaryan <surenb@google.com> [230801 18:07]:
> When CONFIG_PER_VMA_LOCK=n, vma_assert_write_locked() should be equivalent
> to mmap_assert_write_locked().
> 
> Suggested-by: Jann Horn <jannh@google.com>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  include/linux/mm.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 406ab9ea818f..262b5f44101d 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -750,7 +750,8 @@ static inline void vma_end_read(struct vm_area_struct *vma) {}
>  static inline void vma_start_write(struct vm_area_struct *vma) {}
>  static inline bool vma_try_start_write(struct vm_area_struct *vma)
>  		{ return true; }
> -static inline void vma_assert_write_locked(struct vm_area_struct *vma) {}
> +static inline void vma_assert_write_locked(struct vm_area_struct *vma)
> +		{ mmap_assert_write_locked(vma->vm_mm); }
>  static inline void vma_mark_detached(struct vm_area_struct *vma,
>  				     bool detached) {}
>  
> -- 
> 2.41.0.585.gd2178a4bd4-goog
>