Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1228712rwo; Wed, 2 Aug 2023 10:31:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlGcXB5FGvUCSZtzIdCy9xmajCpNGOfSur0H16DE05d0cJyXsetNoS7xO1JzV331M29NSMHV X-Received: by 2002:a05:6a21:3e01:b0:134:80b3:896 with SMTP id bk1-20020a056a213e0100b0013480b30896mr15243175pzc.17.1690997513913; Wed, 02 Aug 2023 10:31:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690997513; cv=none; d=google.com; s=arc-20160816; b=QUZyp/mIDiKUpqOZMQ1qgbZZjS7hrwczrMyglKEUBi4vP7b8O92Z2CMLH/t5jFyo1Y Slv3WdRh3JLMQza1RADjM/oY/D+oCOB2BsJJhUQFBcXsaJBPSWDPrzKfhG54jm5nyF5E Wcpb5Dsx1TxSyBPzWDlpUGFlwbe5Iz2pzcnO2Ocy1zcJ8g6dMk7uR2Zl1FMR0JnWFtIx T6weZorUICNcPgYnWiMQrPTBgA92h6DjfG1LUkg2gZQgqwBexH1cBuTJ5lmSh/tuB+90 5uuZ4AEfmrLt8cTfEZM/FJMRfr4DSiDzXc0CeCDHI68Wy3xTDTKnh+Qx7D2/uZFXSIpr OvHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tfKkoXa7+kBOyCwMU8T00sJTcJ4VkfjJ/hsTco4Kb4w=; fh=f+ph7VIwhX7iLJOrfHJ1YQ1ojo0XBG5+jaAb/hL4mCY=; b=V1+5UaECpfDIlSWSzDqp8BwYVbFQTCIDOdrnJ7NF9InCcYTIvEbqGFL+Vcl0ldVR8a L9TcyZOpOe9aDBKbJ6E8eaNWKRTPpQ7lZff5Ix3nqqMvcD6MWEuTze0fLol3mpxNp2wk /B1MayEGmBlRk8DyCei3OvI1eFYk1rTYMtTD6cQ2YgOK/O5kJIi1JMcnqqVSXN1H9/fq 57j5tPTaDdYvr8z8Rx5em1bmaqQgiPUDncWoTOP2f/M14fI8mxq5fwj+F3qTQDCNLzll zNNOmenIdLTZy+aWB56MvEfYQ/hHKxN6XT91rumBrBeoLUoWTn/BcXJrf15QQBvlqrwn YKAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b="hT+nD43/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cd9-20020a056a00420900b00643ba887601si11109484pfb.307.2023.08.02.10.31.41; Wed, 02 Aug 2023 10:31:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b="hT+nD43/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234797AbjHBPAy (ORCPT + 99 others); Wed, 2 Aug 2023 11:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234663AbjHBPAl (ORCPT ); Wed, 2 Aug 2023 11:00:41 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3172690 for ; Wed, 2 Aug 2023 08:00:35 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bc0d39b52cso22498105ad.2 for ; Wed, 02 Aug 2023 08:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1690988435; x=1691593235; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tfKkoXa7+kBOyCwMU8T00sJTcJ4VkfjJ/hsTco4Kb4w=; b=hT+nD43/E+Kv1QbuZjiqSWxMesbtkoQmPihv+chtZ8HvmZRxOH5fa7vnp6ppyDsqMo fDORcMAl6lIY+ApBzphm8qFqBveteN2ckvFdGe1jeZ8F9MADqEzwMbQC+rLC+rR8ImhV /Bud6UflnE9M0L2jQgBaTjIpwThDO9ik26AHIB3Kj4BhuvVHxK/h5SwPzIRsuVcX0hl3 FRexBaF2OcZm0CsY55ybFrP4HPFABD3h0k3kMHSrbs/k0sxtTRTPf58t1G9BlvogdAGF Tv2fJGJMbwr3m6RHt3wlUBzv3p4pVkdC/n7xOvOxeT8z5SHhs/u92Ku/wXqaT8Hrg3fL WEYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690988435; x=1691593235; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tfKkoXa7+kBOyCwMU8T00sJTcJ4VkfjJ/hsTco4Kb4w=; b=Gq7b06K3bAzrsVR1xDCVrWHO5uLZv9C833h95pbG+v1v3fu73K2z1RnxO7jB7wU8O/ frgHw8Cr4sBjVBptkcgcKJJ2JdvzsDl2x3kWkz6INp0Ebncyp1gMzEsBmp2ymL9yPxXu uoATOLdbAhd7xtPJ3OQ0cVPjqus5alWFE9iBnZR9k6zP7bmu4LBPVdxHeTopTt/p5PU/ lNtI2gDdgYi775lx12q9mFO+IMzBjl5b6qd7R9tA9XPeMAyTinmU/btPOUp/hQ2HtXx0 Hk+w29ajN0BEZtaPz994BPSjG1telWnwOteVllcgKCKswFvkt/4A39g7955GCcouYMqx d6Gg== X-Gm-Message-State: ABy/qLbdR2S7nZbRGEwjvOoSbc0guA7/c9xHgWK9aANqx22LZCJkbbKp ktxXJexcSGE9RH/KUN2dMSkLwA== X-Received: by 2002:a17:902:cec5:b0:1bb:d7d4:e0d with SMTP id d5-20020a170902cec500b001bbd7d40e0dmr18658909plg.64.1690988434697; Wed, 02 Aug 2023 08:00:34 -0700 (PDT) Received: from anup-ubuntu-vm.localdomain ([103.97.165.210]) by smtp.gmail.com with ESMTPSA id v11-20020a1709028d8b00b001bb99e188fcsm12503963plo.194.2023.08.02.08.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 08:00:34 -0700 (PDT) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley Cc: Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: [PATCH v7 00/15] Linux RISC-V AIA Support Date: Wed, 2 Aug 2023 20:30:03 +0530 Message-Id: <20230802150018.327079-1-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RISC-V AIA specification is now frozen as-per the RISC-V international process. The latest frozen specifcation can be found at: https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf At a high-level, the AIA specification adds three things: 1) AIA CSRs - Improved local interrupt support 2) Incoming Message Signaled Interrupt Controller (IMSIC) - Per-HART MSI controller - Support MSI virtualization - Support IPI along with virtualization 3) Advanced Platform-Level Interrupt Controller (APLIC) - Wired interrupt controller - In MSI-mode, converts wired interrupt into MSIs (i.e. MSI generator) - In Direct-mode, injects external interrupts directly into HARTs For an overview of the AIA specification, refer the AIA virtualization talk at KVM Forum 2022: https://static.sched.com/hosted_files/kvmforum2022/a1/AIA_Virtualization_in_KVM_RISCV_final.pdf https://www.youtube.com/watch?v=r071dL8Z0yo To test this series, use QEMU v7.2 (or higher) and OpenSBI v1.2 (or higher). These patches can also be found in the riscv_aia_v7 branch at: https://github.com/avpatel/linux.git Changes since v6: - Rebased on Linux-6.5-rc4 - Updated PATCH2 to use IS_ENABLED(CONFIG_SPARC) instead of !IS_ENABLED(CONFIG_OF_IRQ) - Added new PATCH4 to fix syscore registration in PLIC driver - Update PATCH5 to convert PLIC driver into full-blown platform driver with a re-written probe function. Changes since v5: - Rebased on Linux-6.5-rc2 - Updated the overall series to ensure that only IPI, timer, and INTC drivers are probed very early whereas rest of the interrupt controllers (such as PLIC, APLIC, and IMISC) are probed as regular platform drivers. - Renamed riscv_fw_parent_hartid() to riscv_get_intc_hartid() - New PATCH1 to add fw_devlink support for msi-parent DT property - New PATCH2 to ensure all INTC suppliers are initialized which in-turn fixes the probing issue for PLIC, APLIC and IMSIC as platform driver - New PATCH3 to use platform driver probing for PLIC - Re-structured the IMSIC driver into two separate drivers: early and platform. The IMSIC early driver (PATCH7) only initialized IMSIC state and provides IPIs whereas the IMSIC platform driver (PATCH8) is probed provides MSI domain for platform devices. - Re-structure the APLIC platform driver into three separe sources: main, direct mode, and MSI mode. Changes since v4: - Rebased on Linux-6.5-rc1 - Added "Dependencies" in the APLIC bindings (PATCH6 in v4) - Dropped the PATCH6 which was changing the IOMMU DMA domain APIs - Dropped use of IOMMU DMA APIs in the IMSIC driver (PATCH4) Changes since v3: - Rebased on Linux-6.4-rc6 - Droped PATCH2 of v3 series instead we now set FWNODE_FLAG_BEST_EFFORT via IRQCHIP_DECLARE() - Extend riscv_fw_parent_hartid() to support both DT and ACPI in PATCH1 - Extend iommu_dma_compose_msi_msg() instead of adding iommu_dma_select_msi() in PATCH6 - Addressed Conor's comments in PATCH3 - Addressed Conor's and Rob's comments in PATCH7 Changes since v2: - Rebased on Linux-6.4-rc1 - Addressed Rob's comments on DT bindings patches 4 and 8. - Addessed Marc's comments on IMSIC driver PATCH5 - Replaced use of OF apis in APLIC and IMSIC drivers with FWNODE apis this makes both drivers easily portable for ACPI support. This also removes unnecessary indirection from the APLIC and IMSIC drivers. - PATCH1 is a new patch for portability with ACPI support - PATCH2 is a new patch to fix probing in APLIC drivers for APLIC-only systems. - PATCH7 is a new patch which addresses the IOMMU DMA domain issues pointed out by SiFive Changes since v1: - Rebased on Linux-6.2-rc2 - Addressed comments on IMSIC DT bindings for PATCH4 - Use raw_spin_lock_irqsave() on ids_lock for PATCH5 - Improved MMIO alignment checks in PATCH5 to allow MMIO regions with holes. - Addressed comments on APLIC DT bindings for PATCH6 - Fixed warning splat in aplic_msi_write_msg() caused by zeroed MSI message in PATCH7 - Dropped DT property riscv,slow-ipi instead will have module parameter in future. Anup Patel (15): RISC-V: Add riscv_get_intc_hartid() function of: property: Add fw_devlink support for msi-parent drivers: irqchip/riscv-intc: Mark all INTC nodes as initialized irqchip/sifive-plic: Fix syscore registration for multi-socket systems irqchip/sifive-plic: Convert PLIC driver into a platform driver irqchip/riscv-intc: Add support for RISC-V AIA dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller irqchip: Add RISC-V incoming MSI controller early driver irqchip/riscv-imsic: Add support for platform MSI irqdomain irqchip/riscv-imsic: Add support for PCI MSI irqdomain dt-bindings: interrupt-controller: Add RISC-V advanced PLIC irqchip: Add RISC-V advanced PLIC driver for direct-mode irqchip/riscv-aplic: Add support for MSI-mode RISC-V: Select APLIC and IMSIC drivers MAINTAINERS: Add entry for RISC-V AIA drivers .../interrupt-controller/riscv,aplic.yaml | 172 ++++++ .../interrupt-controller/riscv,imsics.yaml | 172 ++++++ MAINTAINERS | 14 + arch/riscv/Kconfig | 2 + arch/riscv/include/asm/processor.h | 4 +- arch/riscv/kernel/cpu.c | 26 +- drivers/irqchip/Kconfig | 25 +- drivers/irqchip/Makefile | 3 + drivers/irqchip/irq-riscv-aplic-direct.c | 326 +++++++++++ drivers/irqchip/irq-riscv-aplic-main.c | 240 ++++++++ drivers/irqchip/irq-riscv-aplic-main.h | 53 ++ drivers/irqchip/irq-riscv-aplic-msi.c | 285 ++++++++++ drivers/irqchip/irq-riscv-imsic-early.c | 258 +++++++++ drivers/irqchip/irq-riscv-imsic-platform.c | 328 +++++++++++ drivers/irqchip/irq-riscv-imsic-state.c | 523 ++++++++++++++++++ drivers/irqchip/irq-riscv-imsic-state.h | 67 +++ drivers/irqchip/irq-riscv-intc.c | 46 +- drivers/irqchip/irq-sifive-plic.c | 200 ++++--- drivers/of/property.c | 32 ++ include/linux/irqchip/riscv-aplic.h | 119 ++++ include/linux/irqchip/riscv-imsic.h | 86 +++ 21 files changed, 2879 insertions(+), 102 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,aplic.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,imsics.yaml create mode 100644 drivers/irqchip/irq-riscv-aplic-direct.c create mode 100644 drivers/irqchip/irq-riscv-aplic-main.c create mode 100644 drivers/irqchip/irq-riscv-aplic-main.h create mode 100644 drivers/irqchip/irq-riscv-aplic-msi.c create mode 100644 drivers/irqchip/irq-riscv-imsic-early.c create mode 100644 drivers/irqchip/irq-riscv-imsic-platform.c create mode 100644 drivers/irqchip/irq-riscv-imsic-state.c create mode 100644 drivers/irqchip/irq-riscv-imsic-state.h create mode 100644 include/linux/irqchip/riscv-aplic.h create mode 100644 include/linux/irqchip/riscv-imsic.h -- 2.34.1