Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 18:47:36 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/13] rust: init: make `#[pin_data]` compatible with
 conditional compilation of fields
Message-ID: <20230802184736.76eb0843.gary@garyguo.net>
In-Reply-To: <20230729090838.225225-3-benno.lossin@proton.me>
References: <20230729090838.225225-1-benno.lossin@proton.me>
        <20230729090838.225225-3-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Qb2FO5okc2Vb/GZuAs9tghMRD+AdB6OnCOycTLkD6/9jk1re+7eWa7P/IBU?=
 =?us-ascii?Q?UKgI3iGlxETb9hAYSfVIpoAEKpPVNj4Jwnk8zSTdfMm1/L//ygWmCTzby2kx?=
 =?us-ascii?Q?CXU046lqE3sm5nRylSy57NtsejIY2klA2o6EOzFrfbQyW3NYbl5J4elunHaT?=
 =?us-ascii?Q?tlLCChSwiO4RIClYFs/dfS2JqhVxP5OsD8TOagtyRzMhxesJ72cXWG6VLiJz?=
 =?us-ascii?Q?T1wQrqpQgtbso4JnH59sJP8AnKbt6UaNse2pypVucRVM/ySzbwzN+QwtcqiO?=
 =?us-ascii?Q?UgpMgZ2Y1+payfj+KG0/ERhh0oO89+w0wkMvds0o1u9NMTZql5AF+H3ItG0/?=
 =?us-ascii?Q?kuZ1B+tvy5rPH1Sw3+DBIMa+QDcguvLb0iRLpO/8rTJk22zDAJF0p75JYtAL?=
 =?us-ascii?Q?ImV7Hy3l3Yh2pDdvu07bTSZEN9b/r8bVbES2VmhaR3OPcT6NOs4g9hpvi9Ef?=
 =?us-ascii?Q?KLYWxdXarpMpyxHxDCgqBxULzTnenY+mkRsKk3SOmfRyGYHm+03akcY4agDw?=
 =?us-ascii?Q?x1VHIUHSIhKAoptoo8zKIB6RJhHC2HSYWLV774G06weK3u8x29TPbogYyOWH?=
 =?us-ascii?Q?PAK413JNKsSAevF3fNU/vRSIwb3XIB4mrSvZQh+dESvMwvU5NSPwGyfUvVCf?=
 =?us-ascii?Q?q71JX2fO3wWDkGXWmO9NB2tCzg3JCH3phi94M910nm4gdr/UQDCzbuD9S5vq?=
 =?us-ascii?Q?aVSa4AkDH+LE9vdwHp3Z6qD9TZ9lU2+y3s8z2xvXaGaeqUU62kQvN3oYHA9N?=
 =?us-ascii?Q?OJKbIayq+4f6P9iw9MbZYys6JXDvGe+yZupOQJBYcuuDa3UcTInGK/4uS3gX?=
 =?us-ascii?Q?18OKeQGrLXBXeDZuNHp82YtP8MwXbRXlqkuntYJVOgZpAq+CcLgmd4GT5IgJ?=
 =?us-ascii?Q?lkxtmyQCB4uJqobsPPUcge/mK/dncL7f20GOCj634bjgivweuYkFWkA6EIrm?=
 =?us-ascii?Q?W4dOLBbQ8pmkXfcciJCiZuMmnOZdJhb4LcLWsok+dlrU4GUZn/Xz7z73r87h?=
 =?us-ascii?Q?UWHF2AnlA5yGeM4QqWqmU4ThqWTAudV2SICDZvTJpQubNO+AwPqRTPl/Ijeh?=
 =?us-ascii?Q?nRSvC/k6Dgt2OK2AgFoDOZpGkA+6tI3wpCimHaZ9/sTYhAV4AAmOJMbSCCzm?=
 =?us-ascii?Q?2CXi+QWGXVkf9JUP8TzXihnIjggdyvyPV4Jjf+OZ4opTUT+rilN9HM9MJ329?=
 =?us-ascii?Q?f3Fr0BYsrPAiWpqvmIWkYqZayzrmcQY4NpX0XD0HmhuWmYxks7XJ5ZdRZAoh?=
 =?us-ascii?Q?hGyBFQl3NytVOzkTXiLGPXv95/cOH76Rg2AsbOC2mZf0IaF7rVDK2vpNll3B?=
 =?us-ascii?Q?EDr7rpWM4q5DA9eE+p1AmMv9CSMMJSyd290a2ZBZZAySZMaK4VUU5FK6LTgs?=
 =?us-ascii?Q?lr+mpHPtMF6RxJyu319RIidT6iMZokvwooCzGgcHVlmqbkiUtjxUVj4MtNG3?=
 =?us-ascii?Q?yd3kuML4bJEdJps/+t7XewnRQby4UHoz2XHgOLFEkAoiDozNQOtRJYwgFXbI?=
 =?us-ascii?Q?5ZWpjssb8eaD3tFo83bP0YLOJG406EOClmMX1Gkj1KMcRrlPh0pO3O8CHs+q?=
 =?us-ascii?Q?MzQIj3AfttbiPCd9KLJsLmOvGCAKou1HSuVlvfeJ?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: fada76c6-62a8-4ab2-40e2-08db9380929e
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 17:47:42.9663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I8mRluUgqCEx3wevsxvoqikJIy/evM00JxLw07RE5qDQioJGqGNgiN+n2WXu5WLFE6eKqq4e8gQ3xpvauF8RyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB5396
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 29 Jul 2023 09:09:23 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> This patch allows one to write
> ```
> #[pin_data]
> pub struct Foo {
>     #[cfg(CONFIG_BAR)]
>     a: Bar,
>     #[cfg(not(CONFIG_BAR))]
>     a: Baz,
> }
> ```
> Before, this would result in a compile error, because `#[pin_data]`
> would generate two functions named `a` for both fields unconditionally.
> 
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/init/macros.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs
> index fbaebd34f218..9182fdf99e7e 100644
> --- a/rust/kernel/init/macros.rs
> +++ b/rust/kernel/init/macros.rs
> @@ -962,6 +962,7 @@ impl<$($impl_generics)*> $pin_data<$($ty_generics)*>
>          where $($whr)*
>          {
>              $(
> +                $(#[$($p_attr)*])*
>                  $pvis unsafe fn $p_field<E>(
>                      self,
>                      slot: *mut $p_type,
> @@ -971,6 +972,7 @@ impl<$($impl_generics)*> $pin_data<$($ty_generics)*>
>                  }
>              )*
>              $(
> +                $(#[$($attr)*])*
>                  $fvis unsafe fn $field<E>(
>                      self,
>                      slot: *mut $type,