Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 18:52:58 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Subject: Re: [PATCH v3 05/13] rust: init: wrap type checking struct
 initializers in a closure
Message-ID: <20230802185258.08a2a8d7.gary@garyguo.net>
In-Reply-To: <20230729090838.225225-6-benno.lossin@proton.me>
References: <20230729090838.225225-1-benno.lossin@proton.me>
        <20230729090838.225225-6-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jeX6ny0p814RAWdVUD9jOPKADrIv3WetHvFaE3u3xdD3ra9F3PV3EUZRhWrI?=
 =?us-ascii?Q?bx6Id+qg8mP5NB0VWMj0syCljO/SUwLk+Qn1TQwqnHteHm+MwKq2n7ZhEQxK?=
 =?us-ascii?Q?DcXSTCk4xTBrMsbpSqo6h2wpThVfs5kdukAuv+HIAe4p3V3xhdwFSJEfOMJ1?=
 =?us-ascii?Q?Yx5NLcp03oSG8yl0txULEQj+M+1VnZ8AW2YE0mNyCmOP9EA+JdDmSiwuKEyv?=
 =?us-ascii?Q?dMiGNEUUBkXPDBbS9LIv+udS4bhw2X6C2U2WuE9BYKvJSIcwGuw8wUWssFVR?=
 =?us-ascii?Q?6G6aJbz6/fA3eOwYjoc+pj5ZGofcxY9qxkEtmUEPNRNqw6vSecF80e+aOkvI?=
 =?us-ascii?Q?2LaY3DBPxtAZnVSTkpJWStZeCoC90KL0L8+jDz8g/zg8aVz6Fj/ChZYXfcMQ?=
 =?us-ascii?Q?0bq7ebGExFv5bBPCVf5kcOo6aMFR3IH4WUV0DDpf1NaSehVOaUGjRlK3jT91?=
 =?us-ascii?Q?OOWOaaIbbRep+pG2jb/s8lguzIgV21KP7UVanP4sCfJAdGFDUdhwOH9G0i7y?=
 =?us-ascii?Q?RqCxQk3XobIJO94IEbwvfQiAB/EsWsDie0bHCchkNefHVOfEtYdW3L8oS/Gp?=
 =?us-ascii?Q?KZhi3dl3YKQXXl5j89hO3T3d7F2z3pQxBf3gXXC+pG6ExbUy+IMRiylEQsxs?=
 =?us-ascii?Q?1R1nnltqGzV2R7xCCxG3lduuDQA70TLUY0P27hJmzfrIp3gBRnVP6x0jOWql?=
 =?us-ascii?Q?pVCrHQvcGYAokFFb0l/OEBx/QjXy7rZRv1Xpo2m0P4FR32AhrblbMwnj7iM1?=
 =?us-ascii?Q?W0T4yecHI8SqHyq4XPq7/3H2SLyhkRAKtcIM3HTwOao2+j/WSfHQUBA7WJ1p?=
 =?us-ascii?Q?JohWaV4ApbehbnLuvcb5Wq43K9NANdRXC5cJ2aXiVPdb1QQfuU4qK3iBJJy+?=
 =?us-ascii?Q?xZ81BrIhqy/ZyAV3S9lLY+FDDCSC1+bEq9/x3fcNsNzcc8QiCEpZX+c+gqgS?=
 =?us-ascii?Q?DY5jFZAYzVq5ASOTVBXoZnJDWbjEmiqxZ+Mfjjsb/yddr9aXyglBWp3lmP43?=
 =?us-ascii?Q?6RN6zDakcwvvuSR4ClOFPGMuXR7ZUxIcqrKqkyeQwzyR/LMVAienMW3B6KQX?=
 =?us-ascii?Q?gqvM3ozeNvs56Euy4iyI4RuoHtfz3CqcPOoYMpflC7KNr+XTOPKJbMWaZnxr?=
 =?us-ascii?Q?m0aZAmPW4FrcuVePSH0mNHg1MVs9hLXW4Zu2K1686H+rRG+iWJhx6OJwFSQw?=
 =?us-ascii?Q?hhvwF5niPgX43OamICVd2o19kdHqqTqQJGvEWEVgj49eZ/hEepBG4bT+uPXz?=
 =?us-ascii?Q?VC6U/ZBha0JofYZ1eDUHSbNiZB5UHMa25mTcDQJOXJ1X0rk05uazJYxBPbAd?=
 =?us-ascii?Q?+TMPBxt6SIOR/WXFOj6QjyD7tPTMcNdyzfdrIoX/DRBj6+9QIKMWHIh9MPlJ?=
 =?us-ascii?Q?T+Fy1VMVODO0sWB9/jFwhqi2bDEQSsr3G7tfCBdJ4QJwRf004LUgndmDG8GK?=
 =?us-ascii?Q?T/2TRiUC9LUgQyQHUw+q8vvBWvvRa28XUyl3ptBtRTawSn4g4yCYfi6V6YeG?=
 =?us-ascii?Q?XJZ8OI4msbiV2/UZVruLBDebLXuW2/WzNaKjwOvURXjMEeBc3nVByJlQwshH?=
 =?us-ascii?Q?QllNT7KXWtddKsdmuBpCP69buLW5rOwwnE5lT0AZ?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: c89cbe1b-e2a7-40b2-6263-08db93815008
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 17:53:00.7274
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jNj6Leevx7ymOu/YcatgPmwkpwBrw50tCltZ79OyW0+0Dno82Ws8KNyWw4DxGfNdHiCjI7EZCKwGHjHBrn6/aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB5396
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 29 Jul 2023 09:09:46 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> In the implementation of the init macros there is a `if false` statement
> that type checks the initializer to ensure every field is initialized.
> Since the next patch has a stack variable to store the struct, the
> function might allocate too much memory on debug builds. Putting the
> struct into a closure that is never executed ensures that even in debug
> builds no stack overflow error is caused. In release builds this was not
> a problem since the code was optimized away due to the `if false`.
> 
> Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> v2 -> v3:
> - added Reviewed-by's from Martin and Alice.
> 
> v1 -> v2:
> - do not call the created closure.
> 
>  rust/kernel/init/macros.rs | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs
> index 454f31b8c614..2bad086cda0a 100644
> --- a/rust/kernel/init/macros.rs
> +++ b/rust/kernel/init/macros.rs
> @@ -1040,14 +1040,14 @@ macro_rules! __init_internal {
>                      // once, this struct initializer will still be type-checked and complain with a
>                      // very natural error message if a field is forgotten/mentioned more than once.
>                      #[allow(unreachable_code, clippy::diverging_sub_expression)]
> -                    if false {
> +                    let _ = || {
>                          $crate::__init_internal!(make_initializer:
>                              @slot(slot),
>                              @type_name($t),
>                              @munch_fields($($fields)*,),
>                              @acc(),
>                          );
> -                    }
> +                    };
>                  }
>                  Ok(__InitOk)
>              }
> @@ -1168,8 +1168,8 @@ macro_rules! __init_internal {
>          @acc($($acc:tt)*),
>      ) => {
>          // Endpoint, nothing more to munch, create the initializer.
> -        // Since we are in the `if false` branch, this will never get executed. We abuse `slot` to
> -        // get the correct type inference here:
> +        // Since we are in the closure that is never called, this will never get executed.
> +        // We abuse `slot` to get the correct type inference here:
>          unsafe {
>              ::core::ptr::write($slot, $t {
>                  $($acc)*