Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 19:26:05 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <ojeda@kernel.org>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev
Subject: Re: [PATCH 2/2] rust: enable `no_mangle_with_rust_abi` Clippy lint
Message-ID: <20230802192605.5ddb32bb.gary@garyguo.net>
In-Reply-To: <20230729220317.416771-2-ojeda@kernel.org>
References: <20230729220317.416771-1-ojeda@kernel.org>
        <20230729220317.416771-2-ojeda@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZAoKiVR6GyDgj99u8NTQ1DZA6awC4x9qSejkN92z78rNJHdIDSffu332qv7S?=
 =?us-ascii?Q?2vzMGsllgqZakjoOvnyFHlrhhLWp1sAfcOJ7rbNNwiwRnKshVAJZCwfmUgpE?=
 =?us-ascii?Q?a/jewVAMHdJfsg7kyIls+GjecrwAOCEw25rl0h85VM+sOdw/mW+Uvd4FWCGV?=
 =?us-ascii?Q?TpdT+UpW2w4gYjs2+Mbj6cWWfgLvrJrK5BJVfmuQV82EnQgFuvanY+kKjeIQ?=
 =?us-ascii?Q?YhHKyRm91MjxkToi5NEqiA4PbzpjUbG831pAI2uOrJJ+zKhhgLE2iSaUOKbe?=
 =?us-ascii?Q?o4UXbi1A2SAhvZRW7PZMu80LrtudOAhupXUvRZQXUWArNc0i08sVtUg7kyCQ?=
 =?us-ascii?Q?LgwWGmvVWbCUO2BEhGcPD36kVaYayeZESNcUBJGDug70JflVM942G+pMigiQ?=
 =?us-ascii?Q?giVnfT/YofgEIdtclVGuCEohufJsxEsPKQvcR+jeoL/GiN4x6aAszALERg6b?=
 =?us-ascii?Q?Vx6Jh22ZcHX4r9eS/6DE74r5HRdPtCX1oiuQs4AAvsVOCO3ozuZyaLK1kPyQ?=
 =?us-ascii?Q?j4l2cMnGsbHNNkvAVEQkA9IAHnqqBlO7LJT0B7Jc9AxnNXbovmTsoSc4dj/W?=
 =?us-ascii?Q?lEgHSJIq/J3vXZvFRvWV0zYzMoGMuXcSU6laJ0s88xoW0isP5pg8teKHJUVY?=
 =?us-ascii?Q?7oqAmm45Q/kbAUEjtN1SgYmn4iYcqoRxCFAZP1Afkw5y2+FmeNhmIWLT2UpY?=
 =?us-ascii?Q?GTG/1ibaJJeiHjJ+46g4ETUqIWZrnX+T5rjktEmaY+uvNVG7iaxqPRKrvjer?=
 =?us-ascii?Q?doGpiz2XeUbI4h3Wn4p0VXEFM40q1H/mTk3TB/RNW233tNiZaB+p9izI7D5A?=
 =?us-ascii?Q?xPclJGu/IJRm7e3CwwSA2GTTujGipyGL+sVAlrfbpCVbHrH3Q2vKjUIlqQUR?=
 =?us-ascii?Q?y4xZBcIIi+Z1jucnBz/Y243yfSR8mQTMnaIOuSWG1H3VG5574enRsxiWwT4b?=
 =?us-ascii?Q?jdnoEs+V6a0t6UwKOlZcqV58VMjiZhKPa9zYA4tAlgo4kMl8SMx7zyhGjHtd?=
 =?us-ascii?Q?1syreZWC2NXV85cVhWNi9D916vaUe0xdqFsD1vlOxKSHpjzCz+gZiAR/GJqR?=
 =?us-ascii?Q?xHar6rtQrGy/eGcNh0//8iFbgr75l9Wox6GLyahwdh1/ynfhah2Yl5RkMHiT?=
 =?us-ascii?Q?dmYxEa+xPOLHwUSTSTS688onrMuENoB3+MxalqVomveHQ39qvUskFrGTha6c?=
 =?us-ascii?Q?cqpWycYvAF7RMtRFoxS5JmEuMCqJATBJKjSCcQOGZI/FP72tryCVRH3kcHl0?=
 =?us-ascii?Q?MoUtof2Kd/VayKzSkzhEby6E2sWGyt4DR8FH2np4vEQJkrnNMsPRCo3zm8na?=
 =?us-ascii?Q?QprgymqGAnTVlLjhB7itG6Pm7a3e1HtMozc/fzYSHzRSDqne5EECc7wEjdvn?=
 =?us-ascii?Q?8u/YQKXbm+gmwecwGn2au6Z0HmQ4i8bbD/r029pmkSVVdPNQg36icciromD9?=
 =?us-ascii?Q?fXjyM6QMT0uxgHEcQCsoPAob75ldkDWsO/lg7wn1SG0f9bIvKSKHOyAOa2yF?=
 =?us-ascii?Q?gl4aOevCegl0yWutUGcnIBtmfW+0S/4uWcTwESxmQLDskmiFntUw5pyCBBt5?=
 =?us-ascii?Q?mwvigi9AdN/RDeMjREHSHcjXbJj9lmpCJhxpcMx1?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: ed1249da-2129-4928-801d-08db9385f066
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 18:26:07.7693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7cJlHA/uMqgzvATnUUMii02/ESZSM/REMTp4wr11A/khN0CgJmlp+KutjX1oEOnVoLlTWRPaRScnvx8pU/XPLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB6632
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 30 Jul 2023 00:03:17 +0200
Miguel Ojeda <ojeda@kernel.org> wrote:

> Introduced in Rust 1.69.0 [1], this lint prevents forgetting to set
> the C ABI when using `#[no_mangle]` (or thinking it is implied).
> 
> For instance, it would have prevented the issue [2] fixed by commit
> c682e4c37d2b ("rust: kernel: Mark rust_fmt_argument as extern "C"").
> 
>     error: `#[no_mangle]` set on a function with the default (`Rust`) ABI
>       --> rust/kernel/print.rs:21:1  
>        |
>     21 | / unsafe fn rust_fmt_argument(
>     22 | |     buf: *mut c_char,
>     23 | |     end: *mut c_char,
>     24 | |     ptr: *const c_void,
>     25 | | ) -> *mut c_char {
>        | |________________^
>        |
>        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_mangle_with_rust_abi
>        = note: requested on the command line with `-D clippy::no-mangle-with-rust-abi`
>     help: set an ABI
>        |
>     21 | unsafe extern "C" fn rust_fmt_argument(
>        |        ++++++++++
>     help: or explicitly set the default
>        |
>     21 | unsafe extern "Rust" fn rust_fmt_argument(
>        |        +++++++++++++
> 
> Thus enable it.
> 
> In rare cases, we may need to use the Rust ABI even with `#[no_mangle]`
> (e.g. one case, before 1.71.0, would have been the `__rust_*`
> functions). In those cases, we would need to `#[allow(...)]` the lint,
> since using `extern "Rust"` explicitly (as the compiler suggests)
> currently gets overwritten by `rustfmt` [3].
> 
> Link: https://github.com/rust-lang/rust-clippy/issues/10347 [1]
> Link: https://github.com/Rust-for-Linux/linux/pull/967 [2]
> Link: https://github.com/rust-lang/rustfmt/issues/5701 [3]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 658ec2b8aa74..93bf3eca3ead 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -467,6 +467,7 @@ export rust_common_flags := --edition=2021 \
>  			    -Dclippy::let_unit_value -Dclippy::mut_mut \
>  			    -Dclippy::needless_bitwise_bool \
>  			    -Dclippy::needless_continue \
> +			    -Dclippy::no_mangle_with_rust_abi \
>  			    -Wclippy::dbg_macro
>  
>  KBUILD_HOSTCFLAGS   := $(KBUILD_USERHOSTCFLAGS) $(HOST_LFS_CFLAGS) $(HOSTCFLAGS)