Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Jose Abreu <joabreu@synopsys.com>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>,
        Simon Horman <simon.horman@corigine.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
        Fabio Estevam <festevam@gmail.com>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Wong Vee Khee <veekhee@apple.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Andrew Halaney <ahalaney@redhat.com>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Revanth Kumar Uppala <ruppala@nvidia.com>,
        Jochen Henneberg <jh@henneberg-systemdesign.com>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
 for fix_mac_speed
Thread-Topic: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
 for fix_mac_speed
Thread-Index: AQHZw8rncXkT+tBv7kuTZDED3nHZB6/U/amAgADJUBCAABaEAIABiuKA
Date:   Wed, 2 Aug 2023 19:33:36 +0000
Message-ID: <PAXPR04MB9185058330F81CA73EBFD944890BA@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20230731161929.2341584-1-shenwei.wang@nxp.com>
        <20230731161929.2341584-2-shenwei.wang@nxp.com>
        <20230801-portside-prepaid-513f1f39f245-mkl@pengutronix.de>
        <AS8PR04MB9176FC45B9663B5BF964F58A890AA@AS8PR04MB9176.eurprd04.prod.outlook.com>
 <20230801125828.209c5e88@kernel.org>
In-Reply-To: <20230801125828.209c5e88@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qjju14odn7ndoelrr+mgirvG02gqy+9s7hr9Wyon3qhApEmu+W8uNinR5U8U?=
 =?us-ascii?Q?gCO2UkDz1Idlu+e2OMBd+DNKlMsj5DpAxVsnZ4ZJkkux1QuAizj5qruxBZ1B?=
 =?us-ascii?Q?Y93IKPf9t+/WZQj0KJCMJkvbo3ARTUmII5zoKhpgaJNKc3PakhddzYKq4oH5?=
 =?us-ascii?Q?uvxsOP2wnRDkfD9aqjAa/D/wWfUjr3SADD86vyD5Y5O+U5ll4BCW+isEcf9x?=
 =?us-ascii?Q?66rmpy81H/S5b9qmZYYh+CBc/x4B3OQ2BvH5A215i8VegB5BQlEkfrJuDwja?=
 =?us-ascii?Q?xk5g8+/+Kf/piW7olv7cLo2EA72C95LvccubzmoClXCjFjYqoNzxiEqSFy+b?=
 =?us-ascii?Q?W0ozChPaVGJ+6JHXXIdGGBo6iuDS7OQ2MwAaL4YNHVm/8yGA9pIFGHFLy7TU?=
 =?us-ascii?Q?4GjRGEymBv8H+YdwgqL4xsZEhyPBg0REWPeY9TAHdD4IbbnQIDoZA8NYThlk?=
 =?us-ascii?Q?5xLXTCLfHF328laVTKO4esMd4ZX30mqu2gVF7GXQ4KxrhK5BVSs1GQgQlOET?=
 =?us-ascii?Q?xpXf2QKECiz9GNV70uTmMoAsNvLD1r+MFsLlZo4Evpy3sS2E55yBIusKWX0n?=
 =?us-ascii?Q?ymfcWTvXwvF2tfToYRhTEa+dXOzcpVqkIHOgjypqGT/25dg56WSw7h3a6h8P?=
 =?us-ascii?Q?9VwYHdFfnx/N5QlU0R7xR6hHTX8H0XYUwJyVXc/ooMvFq+5IT/tHIda20TJG?=
 =?us-ascii?Q?zg6E8RGMQldLzcGEsoUm23Wztc7tWe6hCg1yZ9hUTYy9jBt9D8YtmP4XUAnf?=
 =?us-ascii?Q?HuazWpNU1tG3e/JVwzgqy13/xDnBH6U7wPEmJ6GooKC0H6laS4RSPYEUCfmA?=
 =?us-ascii?Q?kSHIBaYb8Zl0K70nMXmJCZ8HNg1Z5HduaDLercWl6rQcWkcLPdvOBrUl4VAc?=
 =?us-ascii?Q?ZgO5dE6lGZRzeS41KJkFfumLCd4nU4WfVIs75lEZnMxksh3H+fryPwc/V/ZN?=
 =?us-ascii?Q?h/gW+VNXLdv3UBUouf4G9vC84CY5kMjTaS5CbYfjYzbZRoKpNRj1L33UErwQ?=
 =?us-ascii?Q?AQ9F1+0qsltL5xclu7rC60feNEwS6SN2zWONPgk3UCJmSgwhK+Er5tGWRgIw?=
 =?us-ascii?Q?/tjQyqIxL/C4CwwklpbhxgA42U12ttnCSjv6ndrxrnTcEyPCk+J4HqoDDpZL?=
 =?us-ascii?Q?7FgeUmdejvopQsYthFnU5VYqLSu/x4K/5A4IU/gYRt5ln8rv304TgMItOg1o?=
 =?us-ascii?Q?7otmWXoHLE5bGeH02OH+zHlDmelwJBLjfWOBpsyJyQInrNOAxVU96fP+n/vH?=
 =?us-ascii?Q?pX8CP7BVBDS6Z4S4djUFr60HhS+fktzB4Ndm56N/Ep8e6kR0xNVEBZYrXk74?=
 =?us-ascii?Q?8BEpbMBL9PGzX0VmejRcQbhwX6Fm82wXOL4iYHsJgyZIc728rrdxDXVnrLsk?=
 =?us-ascii?Q?gOrgB4VLot2oz8IxamhFuVjWvI5gedL//xcbIEsA1lj2MvjD+OcgjeBlEFVs?=
 =?us-ascii?Q?mwtCgGxSmmxiy78JWNgf6gAJl4ISenzVXQbAm8sGndkng7NLErAjwN+V/n0/?=
 =?us-ascii?Q?kOVVvZYRpUS4JOVbMdrGS3K7iaAeaw3/6J04nCPGrHA3frUlZJll30idF/sO?=
 =?us-ascii?Q?I6gw1uaq5xrqXuIQPk+laYZLBBG4udoXUpGbn481?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 653b02aa-24f1-43e7-9ccc-08db938f5dff
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 19:33:36.9357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X6CWnXA5E9cNs/ZiGT3cjTIu7FNPd7iBE9ecq/GRmkWsq3lGBSuSkafFtVpihla4Mb3McDegMgyOD8L+aYBwcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9327
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, August 1, 2023 2:58 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> > > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode
> > > parameter for fix_mac_speed
>=20
> Why is this quote included? Please get a sane email client.
>=20

I have no idea. We are using Office Outlook.

Regards,
Shenwei

> > > On 31.07.2023 11:19:28, Shenwei Wang wrote:
> > > > A mode parameter has been added to the callback function of
> > > > fix_mac_speed to indicate the physical layer type.
> > > >
> > > > The mode can be one the following:
> > > >   MLO_AN_PHY      - Conventional PHY
> > > >   MLO_AN_FIXED    - Fixed-link mode
> > > >   MLO_AN_INBAND   - In-band protocol
> > > >
> > > > Also use short version of 'uint' to replace the 'unsigned int' in
> > > > the function definitions.
> > >
> > > There are not many users of 'uint' in the kernel and it's not used
> > > in the stmmac driver so far. From my point of view I would not
> > > introduce it and stick to the standard 'unsigned int'.
> >
> > Using 'uint' makes the code look cleaner because adding one extra
> > parameter may cause some function declarations to span multiple lines.
> > This change keeps function declarations compact on a single line.
>=20
> Marc is right. Just do it.