Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 02 Aug 2023 22:23:14 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Simon Ser <contact@emersion.fr>, Janne Grunau <j@jannau.net>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?ISO-8859-1?Q?Christian_K=F6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/uapi: document the USB subconnector type
User-Agent: K-9 Mail for Android
In-Reply-To: <20230802191351.GA1407@pendragon.ideasonboard.com>
References: <20230729004913.215872-1-dmitry.baryshkov@linaro.org> <20230729004913.215872-4-dmitry.baryshkov@linaro.org> <20230802185547.GC32500@pendragon.ideasonboard.com> <a32ce695-038f-0ef8-3584-5bd1ba528131@linaro.org> <20230802191351.GA1407@pendragon.ideasonboard.com>
Message-ID: <DE2B4523-D16C-4AFC-8352-212B23548DD5@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2 =D0=B0=D0=B2=D0=B3=D1=83=D1=81=D1=82=D0=B0 2023 =D0=B3=2E 22:13:51 GMT+03=
:00, Laurent Pinchart <laurent=2Epinchart@ideasonboard=2Ecom> =D0=BF=D0=B8=
=D1=88=D0=B5=D1=82:
>On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote:
>> On 02/08/2023 21:55, Laurent Pinchart wrote:
>> > Hi Dmitry,
>> >=20
>> > Thank you for the patch=2E
>> >=20
>> > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote:
>> >> To properly define the USB-C DP altmode connectors, add the USB
>> >> subconnector type=2E
>> >>
>> >> Suggested-by: Simon Ser <contact@emersion=2Efr>
>> >> Signed-off-by: Dmitry Baryshkov <dmitry=2Ebaryshkov@linaro=2Eorg>
>> >> ---
>> >>   drivers/gpu/drm/drm_connector=2Ec | 1 +
>> >>   include/uapi/drm/drm_mode=2Eh     | 1 +
>> >>   2 files changed, 2 insertions(+)
>> >>
>> >> diff --git a/drivers/gpu/drm/drm_connector=2Ec b/drivers/gpu/drm/drm=
_connector=2Ec
>> >> index a6066e4a5e9a=2E=2E9e96b038f5d0 100644
>> >> --- a/drivers/gpu/drm/drm_connector=2Ec
>> >> +++ b/drivers/gpu/drm/drm_connector=2Ec
>> >> @@ -1050,6 +1050,7 @@ static const struct drm_prop_enum_list drm_dp_=
subconnector_enum_list[] =3D {
>> >>   	{ DRM_MODE_SUBCONNECTOR_DisplayPort, "DP"        }, /* DP */
>> >>   	{ DRM_MODE_SUBCONNECTOR_Wireless,    "Wireless"  }, /* DP */
>> >>   	{ DRM_MODE_SUBCONNECTOR_Native,	     "Native"    }, /* DP */
>> >> +	{ DRM_MODE_SUBCONNECTOR_USB,	     "USB"       }, /* DP */
>> >=20
>> > Should this be DRM_MODE_SUBCONNECTOR_USB_C and "USB-C", in case we ge=
t
>> > another USB type later ?
>>=20
>> Hmm, which id should I use for micro-USB then? (consider anx7808,=20
>> SlimPort)=2E I thought about using DRM_MODE_SUBCONNECTOR_USB for both o=
f=20
>> them=2E But maybe I should add another subtype for SlimPort=2E
>
>I suppose it depends on whether userspace needs a way to differentiate
>those=2E Do you have a good visibility on the userspace use cases ?

No=2E I'm not even sure, which userspace handles subtypes properly=2E

For the reference, SlimPort is mostly legacy hardware, think about Nexus 4=
, 5, 6, 7 (2013)


>
>> >>   };
>> >>  =20
>> >>   DRM_ENUM_NAME_FN(drm_get_dp_subconnector_name,
>> >> diff --git a/include/uapi/drm/drm_mode=2Eh b/include/uapi/drm/drm_mo=
de=2Eh
>> >> index 92d96a2b6763=2E=2E0f74918b011c 100644
>> >> --- a/include/uapi/drm/drm_mode=2Eh
>> >> +++ b/include/uapi/drm/drm_mode=2Eh
>> >> @@ -398,6 +398,7 @@ enum drm_mode_subconnector {
>> >>   	DRM_MODE_SUBCONNECTOR_HDMIA       =3D 11, /*            DP */
>> >>   	DRM_MODE_SUBCONNECTOR_Native      =3D 15, /*            DP */
>> >>   	DRM_MODE_SUBCONNECTOR_Wireless    =3D 18, /*            DP */
>> >> +	DRM_MODE_SUBCONNECTOR_USB         =3D 20, /*            DP */
>> >>   };
>> >>  =20
>> >>   #define DRM_MODE_CONNECTOR_Unknown	0
>