Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1397619rwo; Wed, 2 Aug 2023 13:25:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlF3/oIB8VDDWiKmdrXqYSIQBZUlv6Qr1bSEqRmVcQEDA5T5mbWcG1PdlY0fpXkOlh2GrmRJ X-Received: by 2002:a17:902:9a06:b0:1bb:edd5:4644 with SMTP id v6-20020a1709029a0600b001bbedd54644mr14818217plp.68.1691007903587; Wed, 02 Aug 2023 13:25:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691007903; cv=none; d=google.com; s=arc-20160816; b=Tih9JNvkid6YXbyQ97VoiDwcfEuIVvtcJ/20ZRzIPjUs8jwNS4m8Rt0lBSHlapm30M KH/udx/G/x8TPYAIhc2Tle4s9SV1un+8aIShaSPjTiJsNTZCvhutW+FrpvrNcTMd+KnG eXUyZ9yGnN7X0NSjJuHS/wHBpv13M6B4nCHebvINyn5s4rO7G2wLTXsIIAYLNFMN4n/1 Zd5bSLKHVbRSI5WQtBqWEQj9Gek6r8RQMBDZLOWNK0tIRvT7nxdkF1/ZoGDEAvqXypEy KcD/iXHji0CufIGwHjtdMcPKqBaVvpILex257BT817uYgPuumuCIhn4YNTEfi5rN9n0r MKEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Bcc/dvU+IoBzJoJT5KOMgzntMrDVmFFfurWTVJnJ+Q0=; fh=fmxruWGt2hapz4lbtzQE695w/hcldq88xJ4YxuB/nb4=; b=L+xwGlqVvsHC6epGlNrRlRO59CRIspJZUyiIWkaUy2mm1J6XjZNbG0tsPUM4xCELzi bLnTrigB18qChkkh17sWusibh1MIhxzJyguhi46lPx9UNBGyl/FkT3w2u6gRQIVlYdn0 qbqga5Dmtz4sd3+0RHAzIHsCXNrnzmRIVdOf2vNdH+JmUFVqa6S4w5krMCdmrlRagIpH MtN982BPOZtnqqAbe/nullmBFey+ENEjnC+E0IB/psi+t0HdER52WGdx2EpefNUpOfW6 Im7WSIesibJ+QPX0mzj117iA6HR6/jo8Z6viekL8auK8ig7H7xE4oTpQ1uEteqP+tHVK 9Gfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=epEV6mxm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a170902cec900b001b89bfd0c2csi11390583plg.647.2023.08.02.13.24.51; Wed, 02 Aug 2023 13:25:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=epEV6mxm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231269AbjHBTKZ (ORCPT + 99 others); Wed, 2 Aug 2023 15:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjHBTKY (ORCPT ); Wed, 2 Aug 2023 15:10:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A8626A6 for ; Wed, 2 Aug 2023 12:10:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E16AB61A73 for ; Wed, 2 Aug 2023 19:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4CD1EC433C8; Wed, 2 Aug 2023 19:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691003422; bh=46PMWe3e0Io+gQooYpA8G1g0Au2bYDA8kL63f8rshnM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=epEV6mxmHAP26amC1DCeKHFEhfnkdOIvng7Mr4jy2Z03x8AV+XARbZx5jV8uzKH+r JWKnE0V5zagpXOcG34JsFU0ptNc8je+p2xLlX+yt2JCFUrvGe+5hcs4m5jHsBohUDE wPHIkDmzILdWX1L1/iTNuBW9tHzc8b74FysohM2nugEaf/suELfO9mFrcfd4uIo/QQ RbSjAQaZzDNtf3JA6dfaeEfitTeQXCiY3o9CPScfiC3SBuiLqIl/um5wol3xgr9E1I 7aZj7GX4BoY16W9ua31o1Q3tdoY0xCzIdfDW27CPJ/JLgtjTAGhh1Ywq//J6wl5dyv eqH3KdtCSr3QA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 2F103E270D1; Wed, 2 Aug 2023 19:10:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH -next] net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169100342218.23440.15408447758503116058.git-patchwork-notify@kernel.org> Date: Wed, 02 Aug 2023 19:10:22 +0000 References: <20230731073858.3633193-1-ruanjinjie@huawei.com> In-Reply-To: <20230731073858.3633193-1-ruanjinjie@huawei.com> To: Ruan Jinjie Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 31 Jul 2023 15:38:58 +0800 you wrote: > There is no possible for platform_get_irq() to return 0 > and the return value of platform_get_irq() is more sensible > to show the error reason. > > And there is no need to call the netdev_err() function directly to print > a custom message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. > > [...] Here is the summary with links: - [-next] net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq() https://git.kernel.org/netdev/net-next/c/ae1d60c41e58 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html