Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1398228rwo; Wed, 2 Aug 2023 13:25:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlH59xpVc8irCvAaxrxYNZ+77IbU4V8CTWb5FRBUtSk35TYSskcY5ADofxe301ikDYqMEB4F X-Received: by 2002:a05:6a20:3d27:b0:13f:53b1:c063 with SMTP id y39-20020a056a203d2700b0013f53b1c063mr536962pzi.49.1691007953952; Wed, 02 Aug 2023 13:25:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691007953; cv=none; d=google.com; s=arc-20160816; b=r+/UMHcGOwghIyfNkL1oFFjJgRpI4C4nbpiVR/X4DfFws0KxLDJR/z1la9/pFN28YI pec7v61Xnl7QN1UY65go8EchRMTvsRiSKtgB7TLu6CtT13EjCSwJXzKiZBOSM/QpKIqn pFWQ3u8O+fRd/3Lg7qq0tL3/Kh5fCN84dxG/1XZstOOW8k4TBAhSyZTfINSv65dpfysc NVYCdimyBgYWUby0h1l3+LMsERjwfsiZfpDCYTU14t+oAF0bBf9jp7bLs+MhrjNdGJQy YQIuM6/0A790jHojiTK1lRsAoCAdBntlOpxmFJyF8GWUMfJYs4kBt7cOEUMRDIPw8B/A ctfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=6EP+ECIbnoSVXJVNR+pMqQ7Mnk9oSCWj0/9Nsr0rkRo=; fh=9Oij728STVDG8CecToTsGOvhKQcFgnQogJB0PF77D+E=; b=U4Se55QA9G+2kB6Q/qhG26B31Bx2RGerEg4enZKWaZl2pjJ10wEsrknDq/xiMjeH/y 2XeHwKtF6fyO4vKki8qHdG/dH/QwgQjPHtBK16mmV0xe1pgzbnnqa+uKKz3PJanC4ScM fo/fzmGbQTwWmJgXIQHWxDvdj3C/K6I/I/+fJfpe1JL3UIEN5hhU03irkvepLBu6pn73 ij/UDSFQPgcLw6beMdaMgypXuFSPfRgJZtJuo7B9U9J1jZ/EJgNr9NXWzeAQZZfBhjD7 1w/1KYuspIxvuW+PpwNJFdfOVhbsQIMVczeFRA3jhmXUq0oDJ9qafz28Fr4/qys2lb/O 240g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BvOQGBGz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l20-20020a635714000000b0055337ca9cefsi10946272pgb.857.2023.08.02.13.25.41; Wed, 02 Aug 2023 13:25:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BvOQGBGz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbjHBUC0 (ORCPT + 99 others); Wed, 2 Aug 2023 16:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231616AbjHBUCT (ORCPT ); Wed, 2 Aug 2023 16:02:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F18D2103; Wed, 2 Aug 2023 13:02:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CBBE61AE0; Wed, 2 Aug 2023 20:02:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E190BC433C7; Wed, 2 Aug 2023 20:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691006537; bh=To4qV8uagUTfxBX0+FvsF8yldldpPIgLm37jKxynVdA=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=BvOQGBGz2AfowOxx/aG1f/XwgCsLT0mhPw8iigA9XzXY7aHjoYzUpVmFzbtY0R2jj 2mZUBc4U+wptdIQp4EPOvKKTSTIoUwkABWxw+p8+x8NRmmm+B7NEjMmdNFbimbNicl 37LiYs0rPll477nZoVsGB2qbyQ6W3BxSOZ/L1xwW+QyjQ/LaEnAoHj/uiitEg2rfMt bLkz+S2FD/1e5oFXgmX4Z5J4uX3emJLHDc1tVwDdu5SQKMhejN10UCojzhRDUVhCgs fKKBxQnxDw5WeHQxK8V1kYwlnfbljsdRSpIzUo6DI4YzOEeoKQduyeMAFNARRKKfSV o5qVlByGa7WWA== From: Andi Shyti To: aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, carlos.song@nxp.com Cc: xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20230726092238.3424116-1-carlos.song@nxp.com> References: <20230726092238.3424116-1-carlos.song@nxp.com> Subject: Re: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work Message-Id: <169100653443.1957828.8137836216322906699.b4-ty@kernel.org> Date: Wed, 02 Aug 2023 22:02:14 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, 26 Jul 2023 17:22:38 +0800, carlos.song@nxp.com wrote: > On MX8X platforms, the default clock rate is 0 if without explicit > clock setting in dts nodes. I2c can't work when i2c peripheral clk > rate is 0. > > Add a i2c peripheral clk rate check before configuring the clock > register. When i2c peripheral clk rate is 0 and directly return > -EINVAL. > > [...] Applied to i2c/andi-for-current on https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Please note that this patch may still undergo further evaluation and the final decision will be made in collaboration with Wolfram. Thank you, Andi Patches applied =============== [1/1] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work commit: a83c167c8210a9f289e867bbc084174252f7433f