Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed,  2 Aug 2023 12:17:26 -0700
In-Reply-To: <20230627042639.12636-1-likexu@tencent.com>
Mime-Version: 1.0
References: <20230627042639.12636-1-likexu@tencent.com>
Message-ID: <169084279326.1259481.1489304678823959902.b4-ty@google.com>
Subject: Re: [PATCH] KVM: x86/mmu: Move the lockdep_assert of mmu_lock to
 inside clear_dirty_pt_masked()
From:   Sean Christopherson <seanjc@google.com>
To:     Sean Christopherson <seanjc@google.com>,
        Like Xu <like.xu.linux@gmail.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On Tue, 27 Jun 2023 12:26:39 +0800, Like Xu wrote:
> Move the lockdep_assert_held_write(&kvm->mmu_lock) from the only one caller
> kvm_tdp_mmu_clear_dirty_pt_masked() to inside clear_dirty_pt_masked().
> 
> This change makes it more obvious why it's safe for clear_dirty_pt_masked()
> to use the non-atomic (for non-volatile SPTEs) tdp_mmu_clear_spte_bits()
> helper. for_each_tdp_mmu_root() does its own lockdep, so the only "loss"
> in lockdep coverage is if the list is completely empty.
> 
> [...]

Applied to kvm-x86 mmu, thanks!

[1/1] KVM: x86/mmu: Move the lockdep_assert of mmu_lock to inside clear_dirty_pt_masked()
      https://github.com/kvm-x86/linux/commit/e19314998321

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes