Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230626085811.3192402-1-puranjay12@gmail.com>
 <7e05efe1-0af0-1896-6f6f-dcb02ed8ca27@iogearbox.net> <ZKMCFtlfJA1LfGNJ@FVFF77S0Q05N>
 <CANk7y0gTXPBj5U-vFK0cEvVe83tP1FqyD=MuLXT_amWO=EssOA@mail.gmail.com> <CANk7y0hRYzpsYoqcU1tHyZThAgg-cx46C4-n2JYZTa7sDwEk-w@mail.gmail.com>
In-Reply-To: <CANk7y0hRYzpsYoqcU1tHyZThAgg-cx46C4-n2JYZTa7sDwEk-w@mail.gmail.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Wed, 2 Aug 2023 14:02:39 -0700
Message-ID: <CAADnVQJJHiSZPZFpu1n-oQLEsUptacSzF7FdOKfO6OEoKz-jXg@mail.gmail.com>
Subject: Re: [PATCH bpf-next v4 0/3] bpf, arm64: use BPF prog pack allocator
 in BPF JIT
To:     Puranjay Mohan <puranjay12@gmail.com>,
        Florent Revest <revest@chromium.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        bpf <bpf@vger.kernel.org>, KP Singh <kpsingh@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jul 30, 2023 at 10:22=E2=80=AFAM Puranjay Mohan <puranjay12@gmail.c=
om> wrote:
>
> Hi Mark,
> I am really looking forward to your feedback on this series.
>
> On Mon, Jul 17, 2023 at 9:50=E2=80=AFAM Puranjay Mohan <puranjay12@gmail.=
com> wrote:
> >
> > Hi Mark,
> >
> > On Mon, Jul 3, 2023 at 7:15=E2=80=AFPM Mark Rutland <mark.rutland@arm.c=
om> wrote:
> > >
> > > On Mon, Jul 03, 2023 at 06:40:21PM +0200, Daniel Borkmann wrote:
> > > > Hi Mark,
> > >
> > > Hi Daniel,
> > >
> > > > On 6/26/23 10:58 AM, Puranjay Mohan wrote:
> > > > > BPF programs currently consume a page each on ARM64. For systems =
with many BPF
> > > > > programs, this adds significant pressure to instruction TLB. High=
 iTLB pressure
> > > > > usually causes slow down for the whole system.
> > > > >
> > > > > Song Liu introduced the BPF prog pack allocator[1] to mitigate th=
e above issue.
> > > > > It packs multiple BPF programs into a single huge page. It is cur=
rently only
> > > > > enabled for the x86_64 BPF JIT.
> > > > >
> > > > > This patch series enables the BPF prog pack allocator for the ARM=
64 BPF JIT.
> > >
> > > > If you get a chance to take another look at the v4 changes from Pur=
anjay and
> > > > in case they look good to you reply with an Ack, that would be grea=
t.
> > >
> > > Sure -- this is on my queue of things to look at; it might just take =
me a few
> > > days to get the time to give this a proper look.
> > >
> > > Thanks,
> > > Mark.
> >
> > I am eagerly looking forward to your feedback on this series.

Mark, Catalin, Florent, KP,

This patch set was submitted on June 26 !
It's not acceptable to delay review for so long.
Please review asap.