Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 02 Aug 2023 13:59:23 -0700
From:   Kees Cook <kees@kernel.org>
To:     Palmer Dabbelt <palmer@dabbelt.com>, keescook@chromium.org
CC:     justinstitt@google.com, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, ndesaulniers@google.com,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] RISC-V: cpu: refactor deprecated strncpy
User-Agent: K-9 Mail for Android
In-Reply-To: <mhng-724de287-da99-4f58-af50-5d728a28d4ab@palmer-ri-x1c9>
References: <mhng-724de287-da99-4f58-af50-5d728a28d4ab@palmer-ri-x1c9>
Message-ID: <6A03714C-8C92-4E05-8FAD-D2C5A4745E7D@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On August 2, 2023 1:47:14 PM PDT, Palmer Dabbelt <palmer@dabbelt=2Ecom> wro=
te:
>On Wed, 02 Aug 2023 13:41:52 PDT (-0700), Palmer Dabbelt wrote:
>> On Wed, 02 Aug 2023 13:36:03 PDT (-0700), keescook@chromium=2Eorg wrote=
:
>>> On Wed, Aug 02, 2023 at 12:21:58AM +0000, Justin Stitt wrote:
>>>> `strncpy` is deprecated for use on NUL-terminated destination strings=
 [1]=2E
>>>>
>>>> Favor not copying strings onto stack and instead use strings directly=
=2E
>>>> This avoids hard-coding sizes and buffer lengths all together=2E
>>>>
>>>> Link: https://github=2Ecom/KSPP/linux/issues/90
>>>> Cc: linux-hardening@vger=2Ekernel=2Eorg
>>>> Suggested-by: Kees Cook <keescook@chromium=2Eorg>
>>>> Signed-off-by: Justin Stitt <justinstitt@google=2Ecom>
>>>
>>> I like it! ;)
>>>
>>> Reviewed-by: Kees Cook <keescook@chromium=2Eorg>
>>
>> Thanks, I just queue it up for fixes (might take a bit to build test,
>> I'm a bit backed up)=2E
>>
>> Reviewed-by: Palmer Dabbelt <palmer@rivosinc=2Ecom>
>> Acked-by: Palmer Dabbelt <palmer@rivosinc=2Ecom>
>>=20
>> If you wanted to take it for some hardening thing, though -- otherwise
>> it'll likely end up on my fixes later today=2E
>
>Sorry this is for-next as it's not a fix, I was just looking at other=20
>fixes=2E  It's queued up aimed at for-next=2E

Awesome; thank you! :)


--=20
Kees Cook