DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=XJmM5thZKA2//4iYB4pudGFqi7hT229AGD7SOSNI+D7fFvYdNtv4C+1EIgiPMzMULZ0qrer2UrS1VxYkQa4UTaJTd0VxfQXb9di4reKHHoZgdaEKNf6Mqt+LAAOpH2r9ZEAsNUxrOsA+s+2O6SEzRZ67SQGeTqI2AsAhPtHHPGg=  ;
From: David Brownell <david-b@pacbell.net>
To: Bryan Wu <bryan.wu@analog.com>
Subject: Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing
Date: Tue, 30 Oct 2007 13:24:07 -0700
User-Agent: KMail/1.9.6
Cc: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <1193735885-8202-1-git-send-email-bryan.wu@analog.com>
In-Reply-To: <1193735885-8202-1-git-send-email-bryan.wu@analog.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200710301324.07691.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 830
Lines: 24

On Tuesday 30 October 2007, Bryan Wu wrote:
>  - BF54x supported
>  - multi-port supported
>  - bunch of bug fixing 

OK, I forwarded these with some more checkpatch.pl fixes.

But as I commented elsewhere, please work harder to make sure
that your patch comments actually match the patches!!

And also, pay closer attention to when you may be making
changes that make device drivers work differently over
your spi_master controller driver than anyone elses ...
such platform-specific behaviors are undesirable, and when
they go against specified behavior they are also bugs.

- Dave


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/