Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Patrick Whewell <patrick.whewell@sightlineapplications.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Taniya Das <tdas@codeaurora.org>,
        Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        William Gray <william.gray@linaro.org>,
        Patrick Whewell <patrick.whewell@sightlineapplications.com>
Subject: [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
Date:   Wed,  2 Aug 2023 14:04:00 -0700
Message-Id: <20230802210359.408-1-patrick.whewell@sightlineapplications.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N+2LmO6ZI94UdMNk3mygVY1kxWqlhbcAi2gHNX5I/U9MNFCz2xK/cj1R4pJR?=
 =?us-ascii?Q?GpjK4kS9xpG9J3sMRzJzkegqb030w/sXaSbaUpdUC/6i4HtvjL4GFSAhchsy?=
 =?us-ascii?Q?nA6kvoKiIHxBo+IdDavK7uf2QK34YQw6ROhbzXr3Mbp2kwfuZpQK5i61ufi0?=
 =?us-ascii?Q?WEfNq74LbhzIEub4nDnb61zK7ncyrErBnjLSk3vGX9PCPMja41tSfxpxm8Bc?=
 =?us-ascii?Q?fR5Nkge41LVtz3/HJYcC3RkZY7SLOuIwGmbC+T7PrYYg2+BEc+ytGmioXjXg?=
 =?us-ascii?Q?dVnJ+88uVHvt+1ij8QAA+jqW+dpsENL//d2RsQGCjWO6jtJb9zAYrHgr18il?=
 =?us-ascii?Q?5QlHD1C5nUyMXeFWI0StzI7OVgfGSGJ7/QjbdBYQNeKstCwR6Iff6tyQxQ0N?=
 =?us-ascii?Q?mxaUgZb5z6St4Eh0OL4+Q6hwlhbcX36v58CKkv6GGhKKuTtfQuqaNCWfUkC9?=
 =?us-ascii?Q?CAh8ZOf0ZBiT6MwecH2Bzc8BJaAhn7hPZIbyEIhYI0Ijr1ChbulwOR7Q8ayE?=
 =?us-ascii?Q?R3e7cNVUB/nG+EHZLG3NiZ4seyZusNbVKZ1xhW4+TLz1PZIY6MBjAC5yEfEu?=
 =?us-ascii?Q?KNueirrLS9K9QLD/b35d4DfyqXimIWF1WnOH29Pwvrb+Dn9Sr2IcBmJgb72w?=
 =?us-ascii?Q?QmoRJAw4WjlszbGyISPugZzmw+Ri9LX3lKYiyJV2qdE9/xjzQ5o9Mxsf45I7?=
 =?us-ascii?Q?pzxdg48Hb+V0sokUtSpQ3c676EjYEl8NojGYq5HCybJgS+bGvAGi0pgw6tyh?=
 =?us-ascii?Q?JFtgDC008tt1LJnXrH2r59xVQ91nfBVd547yk+QxZMYuMqGY/7pVYVpEyX6B?=
 =?us-ascii?Q?UrbR0BY1A+pXUxRdGJie3AHXuP5eQIw50z5iYubRUvIS8j4gClLmapIah/qB?=
 =?us-ascii?Q?NBsSp4HnKQonb3JS8s+0lZb1/bpzSOAkOq3Meuo1pirGEGQ751SD7CMuGz+t?=
 =?us-ascii?Q?RO3XUbbCtqDMW8gQgmpcUD4MiwowcTeX6yav6Y3c1xle7MlpFFKUo/EyB82w?=
 =?us-ascii?Q?Y4igkdneNrmiXvyXV7loLMZeYCYjOqZ0UB1fHD2uqeIjY0TWYs83KSzsX59m?=
 =?us-ascii?Q?u95w3YhIuplMNulESOEv9W+sf7gV03DO3RR+Ot+itNRhEW1Bg6Ub82IpRu5D?=
 =?us-ascii?Q?WK7zhGhF9Hb9bs+Zl8lEerdodoQ3V/oAY8tdsOfvqdabCnbz05DLb47RjezL?=
 =?us-ascii?Q?H7kYA8nY3WC1ILWuhG/BOxml7Vyxo5X491RLtj13vSwSPE2ls43TxHyc+nzK?=
 =?us-ascii?Q?awG2nBaYKJ3m1xP9oUZn2tShP4ETWAB+vzguVGg79WgDr8VtJJdsuFCIMP02?=
 =?us-ascii?Q?ddkX4R3Idjhwz9Lqrbl9cW64kmB/PSLtMjKKf3zjMXeM+mV+cYogKL8ORLUv?=
 =?us-ascii?Q?iDIB2j59KIAK3nv3Sll5K96GuFQ5pox4yu8raR0csahJgkyDar6kM56O4k8N?=
 =?us-ascii?Q?1KB3FqAsV1My1zoUPAQ2J8DkG0rnfZzPnuleKAkuuDpjtpuDooG5YedH7oGx?=
 =?us-ascii?Q?f4og1rhFSdEYUYi0fzO6Dg5lHZiKkfNP8ds2Me6kobSru9T4zgIT0uyhynRp?=
 =?us-ascii?Q?pZDHOs+e+TEWU+IVnGnibFiytjR1x2VRGkoRpH61AUGZce8d4p62IR7QdjCg?=
 =?us-ascii?Q?tHz+g31N1FaBxG5hMXwmycxyv2GddsB2ycysh8rdbODw?=
X-OriginatorOrg: sightlineapplications.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23dd95ea-d005-4471-32d2-08db939c3c37
X-MS-Exchange-CrossTenant-AuthSource: SN4PR18MB4918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 21:05:43.9870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6f56283c-2197-4913-9761-239c8b420cf0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: seNAaPxU1SOlbagMeg72ertTobyZiLJpgMqtRAPhUln2dI9Nz3BpfSoXiXPNohhH2FuCiz4f72TIXqof5mPP8KQhzHVQt0KJDgqv+IPJh8taLEDqFfHAgLHyhVXJWo7ac92gOq9Wll4ohBL/Kkj/NA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB5653
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
didn't update its configuration" error when booting. Set .flags =
CLK_OPS_PARENT_ENABLE to fix the error.

Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
---
Changes in v2:
    - Updated commit messaage to mention GPLL9 not being on by default
      being the cause of error
    - Moved Signed-off-by line to the bottom.

 drivers/clk/qcom/gcc-sm8250.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
index b6cf4bc88d4d..d3c75bb55946 100644
--- a/drivers/clk/qcom/gcc-sm8250.c
+++ b/drivers/clk/qcom/gcc-sm8250.c
@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
 		.name = "gcc_sdcc2_apps_clk_src",
 		.parent_data = gcc_parent_data_4,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_4),
+		.flags = CLK_OPS_PARENT_ENABLE,
 		.ops = &clk_rcg2_floor_ops,
 	},
 };
-- 
2.25.1