Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f301cd6c4009248c5eb6af00f12f36f3127ca10.camel@redhat.com>
Subject: Re: [RFC PATCH v1 0/2] Deduplicating RISCV cmpxchg.h macros
From:   Leonardo =?ISO-8859-1?Q?Br=E1s?= <leobras@redhat.com>
To:     Andrea Parri <parri.andrea@gmail.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Wed, 02 Aug 2023 18:51:47 -0300
In-Reply-To: <ZC7/LzV53KsZ/cSn@andrea>
References: <20230406082018.70367-1-leobras@redhat.com>
         <ZC7/LzV53KsZ/cSn@andrea>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-04-06 at 19:19 +0200, Andrea Parri wrote:
> On Thu, Apr 06, 2023 at 05:20:17AM -0300, Leonardo Bras wrote:
> > While studying riscv's cmpxchg.h file, I got really interested in
> > understanding how RISCV asm implemented the different versions of
> > {cmp,}xchg.
> >=20
> > When I understood the pattern, it made sense for me to remove the
> > duplications and create macros to make it easier to understand what exa=
ctly
> > changes between the versions: Instruction sufixes & barriers.
> >=20
> > Thanks!
> > Leo
> >=20
> > Changes since RFCv3:
> > - Squashed the 6 original patches in 2: one for cmpxchg and one for xch=
g
> > https://lore.kernel.org/all/20230404163741.2762165-1-leobras@redhat.com=
/
> >=20
> > Changes since RFCv2:
> > - Fixed  macros that depend on having a local variable with a magic nam=
e
> > - Previous cast to (long) is now only applied on 4-bytes cmpxchg
> > https://lore.kernel.org/all/20230321074249.2221674-1-leobras@redhat.com=
/
> >=20
> > Changes since RFCv1:
> > - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build err=
or
> > https://lore.kernel.org/all/20230318080059.1109286-1-leobras@redhat.com=
/
> >=20
> > Leonardo Bras (2):
> >   riscv/cmpxchg: Deduplicate cmpxchg() asm and macros
> >   riscv/cmpxchg: Deduplicate xchg() asm functions
> >=20
> >  arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------
> >  1 file changed, 67 insertions(+), 252 deletions(-)
>=20
> LGTM.  AFAICT, this would need to be rebased, cf. e.g.
>=20
>   a8596dda1fbf7e ("arch: rename all internal names __xchg to __arch_xchg"=
)
>=20
> from the tip tree.
>=20
>   Andrea

Thanks for the heads up!
I will update this and re-send!


And sorry about the delay :(
For some weird reason neither the cover letter, nor your message reached my
gmail, and just now looking at lore I could find your message.=20