Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bfcad832-d5d0-e38b-e2c8-3c1cf2d59242@intel.com>
Date:   Wed, 2 Aug 2023 18:30:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH] prestera: fix fallback to previous version on same major
 version
Content-Language: en-US
To:     Jonas Gorski <jonas.gorski@bisdn.de>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Vadym Kochan <vkochan@marvell.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230802092357.163944-1-jonas.gorski@bisdn.de>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230802092357.163944-1-jonas.gorski@bisdn.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWlVakxNeDA0MHQ3TDJhMkZKbXpTMmJ6Q3FxNUp0ZTQ4RnZDcnUyMWE4RlY4?=
 =?utf-8?B?UUF2TlIxdC9OUnNHNURuNEVYWTBXZXY4aThKRFcwRmlZbVlGSHQxQnAwS3li?=
 =?utf-8?B?Y3ZxdUNEczBQTE5NVUdNVmJlMjRxZEgzL2pTeHpzdnhFbklVd0I4eHQ2eHll?=
 =?utf-8?B?YWYwTW9PWkh6ajA1Sy9rRzUwK1Vid1I1VndoeWc0ZTd5Tml1aWxPOHZFd2VC?=
 =?utf-8?B?K1E5amJiSHBidStvbWt0bVZvWDNVMm1UQUpOOEhkNDNtSE5KM01Lc1gwUnFL?=
 =?utf-8?B?NXZWV0hVZVc4eEpHSXIwcUxHUzh3d0UySktmSUFoM3d6NkJEUWl2NUlQaHpp?=
 =?utf-8?B?UGJxakZiZmIzbmlIM1lxS3lhUDIrWTVMWkcwc2VTZnFYT1MwVU5rWEZ1ZzZV?=
 =?utf-8?B?ZkxhUFloZ3Z1TkpSMzhoQUswQXhjbXJFNlgvZDFFVHlHaFgwRDB1Z3NNTlR3?=
 =?utf-8?B?anpvbERmUXZuNHpnVWRLK3NhVVNkeDdhZU9peTA0Qy9lMUQ1VlErbjZZdjNZ?=
 =?utf-8?B?REpqalpLdnRiYUFCTkZHUnFWcmZHWnJNWm5LQVBrWEFtZXBEUzVXTzAyYWRM?=
 =?utf-8?B?dXdqdmNpSVBjdm1iN3hxa2dKV3dNRnVVUmkxcHJRcmlXa3F5Qm0vWlNmVXZB?=
 =?utf-8?B?KzdtaUdvcEFjZGpNNi85Qmx1UDdwUWFSMUN4ZVVMK0ZZakh3cVpiNDBnN1ph?=
 =?utf-8?B?bnhpMTdiZDZrTlk2b2daeFJVOEdkeVhlNVVyL2JJZG5RMWYyYWR0YS9hbm5a?=
 =?utf-8?B?Rndla3hFYk43Q1dWYWk1MGs0VVdoVVM4c0JYZFZkbWdmR203bWRUSTY5NExx?=
 =?utf-8?B?NHhxTE5LdWVyaVMyWlBvaTZ3ZVhNRDZXamVtMVBMeEM5b3FKc2hBcXBJSnhE?=
 =?utf-8?B?WXZ1bjlqMXJMUlNDemp0U09iRnlxS0NFc055dElYc2x5c3VLZ0lwSlZkTUhL?=
 =?utf-8?B?U0NoWU5MV0RUNHZzVTN2U2lEcXU3UklHdUhZcWRjdGlML0QxZnFZSE8vK05F?=
 =?utf-8?B?clllTnhkZHdncHhyclhBNmI2NWpGVmtxVDlSc0tEeVJSeUpPNFl2QTZYclk1?=
 =?utf-8?B?Y2hIM0VVZ0hFUm1vSmF6cy9aV1pzeVhKWGZrSlJBTDhlU09jeVhrbkhsZnY3?=
 =?utf-8?B?SkZpQ1Y0R0dEaDJFSmhCR2JzcU5TT3hmU2dLRUZuL3VnVzdjZDBHaWU2SWJu?=
 =?utf-8?B?aGFBN2M0Q1FOdnN4RE9tV1IwRk91SzFKaVhQZ0hpdzJxemxObTl1NzVZdm96?=
 =?utf-8?B?L0JwQVpBcHVqK1ArMVNKMWQ0VkJibjFTaFV1bGV6NURJUWVPWnJYamVVaTdE?=
 =?utf-8?B?NWFyVEhNdEViRmIrVlpsMS95bkVwNlQ3dVJDVWgxTk50cXQwTnRyRTVLVEZ3?=
 =?utf-8?B?Mk1aWkZJaTYzYWNEaFgwQ1ArUjRNdTU3UFF3dXhuZnlVZDFaUlIrTlNTVnBS?=
 =?utf-8?B?Y01VWU9HMkNsNGxncHAvZkk1NEp3eEFVMkxpMmkyZWdYeDFodDY4aWdvekJn?=
 =?utf-8?B?alZVV0svY01pQk5rY1pFMnJEajJYZkl3MGpjQ1cwYVNjTElFVnJpeERmVjIw?=
 =?utf-8?B?S3RkUnlQL0U5b0dMMUJmRFJ6NUtkZ21mN05sNGZJSmN2alowYnBzUXZUeWJZ?=
 =?utf-8?B?TlM1ekZOWEhzUjQwTFlic29mLzZJeTJFcUxIRVJEY2p6QnlqbVJsMlZUemFB?=
 =?utf-8?B?RURyRktIZW0vcTArWjVZam9IYjlUc05mMmhTZ2hnZWxvMVlEcSt5aDZTWisv?=
 =?utf-8?B?UWI4OGFvTlN3VjdMcnl5djBOWERpekdLWXZwNmFGd00vVHNvV0w3bnhUVURz?=
 =?utf-8?B?cmZyWEp1ZXJ6Sko4VWUzOGhGT1prVHd1OVYyWmRRSy9kbjU4RWl5TzkrZjRi?=
 =?utf-8?B?YlFRUTNHNS9Ia2l3ZzlCQWJjR3E0Qld6SzVQRDZURGNNYmEwSkNlZXJSak5r?=
 =?utf-8?B?b2JNSmNGWkMxMytOQlBCcEp5MWlFcENQbTRmMkU2THc3cXlMRDEvRWJKMHhV?=
 =?utf-8?B?N2tORDR5Ulg1QkxWNjF4QldUUStQSkN5SlQwd2htV0orbkpKc1lJdlllL1h4?=
 =?utf-8?B?ZFFjQkdGWVFEbThtWmMzSkN1ZG1QRVhVVERwSGh3bEk5b0FtSHplUm9VbTRh?=
 =?utf-8?B?cnExSm1CVTVjaU1GWjAxSW1uQncrWHVjRGl3QWZWQ2tsZGtSQUFvQUtBYmVx?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0d8bafd-e2c1-494f-46df-08db93c1455a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 01:30:50.6980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wW3DRvgNqH+8aS+tCBqOhjGGdIy1gWWb2MqLHEO1KUIeooOxOx1nKsHhOwZ07kldzrkz1aabBuGixk1BXc89LYS047QOYSjR0LwDRDAzVGY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6201
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/2/2023 2:23 AM, Jonas Gorski wrote:
> When both supported and previous version have the same major version,
> and the firmwares are missing, the driver ends in a loop requesting the
> same (previous) version over and over again:
> 
>     [   76.327413] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.1.img firmware, fall-back to previous 4.0 version
>     [   76.339802] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.352162] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.364502] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.376848] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.389183] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.401522] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.413860] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     [   76.426199] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.0.img firmware, fall-back to previous 4.0 version
>     ...
> 
> Fix this by inverting the check to that we aren't yet at the previous
> version, and also check the minor version.
> 
> This also catches the case where both versions are the same, as it was
> after commit bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0
> support").
> 
> With this fix applied:
> 
>     [   88.499622] Prestera DX 0000:01:00.0: missing latest mrvl/prestera/mvsw_prestera_fw-v4.1.img firmware, fall-back to previous 4.0 version
>     [   88.511995] Prestera DX 0000:01:00.0: failed to request previous firmware: mrvl/prestera/mvsw_prestera_fw-v4.0.img
>     [   88.522403] Prestera DX: probe of 0000:01:00.0 failed with error -2
> 
> Fixes: 47f26018a414 ("net: marvell: prestera: try to load previous fw version")
> Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>