Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1f01beae-3468-030b-1627-5f5ed4f26595@intel.com>
Date:   Thu, 3 Aug 2023 08:41:25 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH 1/3] mm: add functions folio_in_range() and
 folio_within_vma()
Content-Language: en-US
To:     Ryan Roberts <ryan.roberts@arm.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
        <yuzhao@google.com>, <willy@infradead.org>, <david@redhat.com>,
        <shy828301@gmail.com>, <hughd@google.com>
References: <20230728070929.2487065-1-fengwei.yin@intel.com>
 <20230728070929.2487065-2-fengwei.yin@intel.com>
 <f1d07ca4-3d69-67cd-a14d-333e4be699b9@arm.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <f1d07ca4-3d69-67cd-a14d-333e4be699b9@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWoyWE1wL09obm9ia1FlczV2NkpjUE5rVnd6QUdRTjVaQXlrbE9UTlFRRkcw?=
 =?utf-8?B?OFJsV2J0WUdKczhmK2FRTXhhSFpzUkpUdkh0TC8xZlNaOTZsMFF2UWd4K0E3?=
 =?utf-8?B?VDhTY0JIN3JuaWVvVFV1ODdXQmxhOE1qQlA4d3NJaXdCRUhWTmJ2NzN2QzJy?=
 =?utf-8?B?NTExcjVFTXQxMGM1aEZpbWVXc0k2bjV1emZ6ZUdCQ2diR0JpZFBWU0RpQ2pD?=
 =?utf-8?B?ckxBRHJCdzlxcEhVK1lGd1JIa29BeFM5WjB4L1J6OWRVVFpkbEcyVGZ0L3ln?=
 =?utf-8?B?V1VGLyt4MSt6MVdPb3YyWEJaQWxRZTFUOVlQbi8yWS9YY3ZUVldaQ2h6K1BN?=
 =?utf-8?B?K1JNbU1ObWhEc1FtQk82Rjc2Skx1V0U3Z25ERXRIcGdBSXY1WExrckhGMldK?=
 =?utf-8?B?WXQvcGFUa0loSXBCalFFSndaMmllR0QrNm1rY1J3SFhsRnU3c2phZDYyTWFt?=
 =?utf-8?B?Q3pKQmZwci9vQm1TMnNrTi9mVnFWUjJ1RjA1by8xakR3NWRuUG45NlFnSFdB?=
 =?utf-8?B?T2hHSGJEU0t0RFRNeHBCTTU5MlBrZ05makcwek91cGFHNEhQbkpaZTRiaGRl?=
 =?utf-8?B?a3lFL1NWdHBlZ0JpdStNcUwwQVFiOE9OSFh4NERnWllQNzlRTmJCMkdyWkNM?=
 =?utf-8?B?M1NFbUpqNVZHRUpWQnMzcmpOOWhLcUdKTjkzLzBHWE1BUGxCeFFBSWF0YndD?=
 =?utf-8?B?bDRMNGtFdmhmVTM1TEVPeFd4SUk1MG82dlB0bnZkVE9ySmJMQ29Xd2FqeUVx?=
 =?utf-8?B?WnhHRTlXTXRTazhSRmR4enRxcXVTNkJ6V3RTRVRxdzNmQTBIZnVZd2VtRFlm?=
 =?utf-8?B?SkNrYVZmVnlhWEFPM25ZdmNCSjY4MTg5K0pWVkN2c3psU0wyOEx5U3RjTUlR?=
 =?utf-8?B?Q1dhenBnYnRVZHNhZjRnYWJMUTYrQzF1aWhNTjh6aGt6dW5QN0c5Qm9UVVpv?=
 =?utf-8?B?RG1XZ2NXby80endPTndEdVRSam95NGxFUnZFcFlTWEd0NEdFODRsOGpjdDNZ?=
 =?utf-8?B?WFNHL1pXSC9LMDE0bmpUWlNBVXFrOVVkV3NBOGhadnRnMVZXL1A4dXVIY3Bj?=
 =?utf-8?B?U0QwS2tIWHpWdVhaZkFYbzY3bEl0QVNZSm1pMFI3cnBsYlpsYmtySWdvNzAy?=
 =?utf-8?B?WDhiM3JFbEhFZVFCdU1CczVxNFFBY3VldE5xdUdQeVJFb3VCT3Q5bVNzY3VK?=
 =?utf-8?B?aXcvbTc4UnJzWFg2VTQ2NzAwUUgvM0VDM1BjeXM4T1ZRV3kvaXl6aHNMeVBC?=
 =?utf-8?B?alpZakZqYk9MdWtjc3dGTjF3Sm9BeXZsdEExY2FJNXRQd2dBc2F2eFhwZmV1?=
 =?utf-8?B?VStkd1A2Q1VyaVVKZGEvRWV4aDNJWEZrbE55emZxZTY1VDIxZUhJR01tQnFI?=
 =?utf-8?B?aHdZUEF2OUt0UVRYWWJHTklHaThOSUJqb1pMbVJtV2dQZU9jM1dvenVRL1ph?=
 =?utf-8?B?WFFPY1F2bUlGa1lidDJ6WndVREdaWEk5SHY3NkNGTkt0dFZjbU92SGUvc3Jm?=
 =?utf-8?B?dzhNNDVIaVpsZC9GaWI1L0FOeWw4YmJXTms2QUhKUGVFY0ExYVhNRFlDK0Mr?=
 =?utf-8?B?SGFNNXdNQTJWd2ZLRWloMEdVMEZrSWxHUVAxZ0NaV2taZ1AzdGhkQlhhUXVs?=
 =?utf-8?B?UnNBUXJYWDh5VUJGcTBidU1kWG9rNm16WFFneGUydGRpNFV4S1V0LzdYOFNB?=
 =?utf-8?B?NDFBRjc1dW00cTR2MlhuaVl2NWNiUGprcUNxNFJOV1gwcWdsdkg3cFAwcGho?=
 =?utf-8?B?S3NpeENZc1pBV2NxaHFEZ0YyckdXVGkrYUZLVEYyVXNxdmdmaVJWamxla2Ra?=
 =?utf-8?B?bjU1WUJtV3pVV1czMlIxQlpmeXpJSUhtejc1SU9NeGlUZFBsay9EUE53V1J1?=
 =?utf-8?B?T0VDUXFnQjlnMGIrMDBXVGJJL2ViaHVBV3VUK0JMQ1lRUlR1dEZtaWlQdkZD?=
 =?utf-8?B?ZVJMOTFQYjJsTEJLOWxBazZFNmo1WXo3TmZybE1oYnY1TEduTkFRc3lCTHdk?=
 =?utf-8?B?RW93bUdYanFnbFJnWFRiRjZyRzBuczNXSHA2U0g3b0ltY2NLYzM2LysrcXRy?=
 =?utf-8?B?T0RxS1Flei80dXBUVkcrZzVsTkhpbk1HazYwQm5WeDlySktocnU4V3lhRER1?=
 =?utf-8?B?UmxSMVpDR0F1RzV2K1dLRXI2MGxlYmcvTDVtaWNDTG1YT0ZHUi9PcnBWbEpM?=
 =?utf-8?B?enc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5afd7c3-1978-472c-b260-08db93ba943b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 00:42:56.4515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gZWoKFzOZNH1y0uAr6TZvnSw5BSXA7bTq2P8axi+iMIWNyH/Sys0SMoUuKtjnpR8YjYK7dtzSWgzKTCZazah3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7891
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/2/23 23:15, Ryan Roberts wrote:
> On 28/07/2023 08:09, Yin Fengwei wrote:
>> It will be used to check whether the folio is mapped to specific
>> VMA and whether the mapping address of folio is in the range.
>>
>> Also a helper function folio_within_vma() to check whether folio
>> is in the range of vma based on folio_in_range().
>>
>> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
>> ---
>>  mm/internal.h | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 69 insertions(+)
>>
>> diff --git a/mm/internal.h b/mm/internal.h
>> index 5a03bc4782a2..63de32154a48 100644
>> --- a/mm/internal.h
>> +++ b/mm/internal.h
>> @@ -585,6 +585,75 @@ extern long faultin_vma_page_range(struct vm_area_struct *vma,
>>  				   bool write, int *locked);
>>  extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
>>  			       unsigned long bytes);
>> +
>> +/*
>> + * Check whether the folio is in specific range
>> + *
>> + * First, check whether the folio is in the range of vma.
>> + * Then, check whether the folio is mapped to the range of [start, end].
>> + * In the end, check whether the folio is fully mapped to the range.
>> + *
>> + * @pte page table pointer will be checked whether the large folio
>> + *      is fully mapped to. Currently, if mremap in the middle of
>> + *      large folio, the large folio could be mapped to to different
>> + *      VMA and address check can't identify this situation.
>> + */
>> +static inline bool
>> +folio_in_range(struct folio *folio, struct vm_area_struct *vma,
>> +		unsigned long start, unsigned long end, pte_t *pte)
>> +{
>> +	pte_t ptent;
>> +	unsigned long i, nr = folio_nr_pages(folio);
>> +	pgoff_t pgoff, addr;
>> +	unsigned long vma_pglen = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
>> +
>> +	VM_WARN_ON_FOLIO(folio_test_ksm(folio), folio);
>> +
>> +	if (start < vma->vm_start)
>> +		start = vma->vm_start;
>> +	if (end > vma->vm_end)
>> +		end = vma->vm_end;
>> +
>> +	pgoff = folio_pgoff(folio);
>> +	/* if folio start address is not in vma range */
>> +	if (pgoff < vma->vm_pgoff || pgoff > vma->vm_pgoff + vma_pglen)
>> +		return false;
> 
> I'm struggling with this logic. What happens for an anonymous folio in a
> (private) file mapping? Wouldn't the folio's pgoff be 0? In this case you could
> return false incorrectly?
You mean cow page for a file mapping?
I suppose the pgoff of folio (folio->index) is not 0 unless the folio is mapped
to vaddr 0. __page_set_anon_rmap() will set the folio->index based on vma->pgoff.


Regards
Yin, Fengwei

> 
>> +
>> +	addr = vma->vm_start + ((pgoff - vma->vm_pgoff) << PAGE_SHIFT);
>> +	if (addr < start || end - addr < folio_size(folio))
>> +		return false;
>> +
>> +	/* not necessary to check pte for none large folio */
>> +	if (!folio_test_large(folio))
>> +		return true;
>> +
>> +	if (!pte)
>> +		return false;
>> +
>> +	/* check whether parameter pte is associated with folio */
>> +	ptent = ptep_get(pte);
>> +	if (pte_none(ptent) || !pte_present(ptent) ||
>> +			pte_pfn(ptent) - folio_pfn(folio) >= nr)
>> +		return false;
>> +
>> +	pte -= pte_pfn(ptent) - folio_pfn(folio);
>> +	for (i = 0; i < nr; i++, pte++) {
>> +		ptent = ptep_get(pte);
>> +
>> +		if (pte_none(ptent) || !pte_present(ptent) ||
>> +				pte_pfn(ptent) - folio_pfn(folio) >= nr)
>> +			return false;
>> +	}
>> +
>> +	return true;
>> +}
>> +
>> +static inline bool
>> +folio_within_vma(struct folio *folio, struct vm_area_struct *vma, pte_t *pte)
>> +{
>> +	return folio_in_range(folio, vma, vma->vm_start, vma->vm_end, pte);
>> +}
>> +
>>  /*
>>   * mlock_vma_folio() and munlock_vma_folio():
>>   * should be called with vma's mmap_lock held for read or write,
>