Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d87b30ae-8f4e-611c-1cb4-9fe02abd1845@intel.com>
Date:   Wed, 2 Aug 2023 18:35:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH V6 net-next] net: mana: Configure hwc timeout from
 hardware
Content-Language: en-US
To:     Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
        <kys@microsoft.com>, <haiyangz@microsoft.com>,
        <wei.liu@kernel.org>, <decui@microsoft.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <longli@microsoft.com>, <sharmaajay@microsoft.com>,
        <leon@kernel.org>, <cai.huoqing@linux.dev>,
        <ssengar@linux.microsoft.com>, <vkuznets@redhat.com>,
        <tglx@linutronix.de>, <linux-hyperv@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>
CC:     <schakrabarti@microsoft.com>
References: <1690974460-15660-1-git-send-email-schakrabarti@linux.microsoft.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <1690974460-15660-1-git-send-email-schakrabarti@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3dPRHZqSnppZjkvSzc3TGpHQVpGcmlJdnN4VlUxSEtVWEtObjVpTnpxZTBD?=
 =?utf-8?B?L21yb2QvVnRTN2JMSVowUGFlUkVUNG5CWU5RUi8wbTRkWXhJQ2c1ckpnOXF4?=
 =?utf-8?B?QUV6MjI3VGxHNnRsVjNjZnM0NGVkcnlLcWxyMEdUQm9zQ3R4Zk5ISnB1REph?=
 =?utf-8?B?V3JuQ1JzK1J5NUI3OUUzd1RIUmtFeTNXR3o2SEI1Zlo5VDJSTmU5bXRSdjM1?=
 =?utf-8?B?Tkl4WkJwdEJQNGtkWFhFdldKWlJGQkxGa2xNYU9WUkdXbHFXOWdSWkowbkRV?=
 =?utf-8?B?L0IwNGcxLzhWdzJhdlZsSklQS1RFNEVMdFlwY0JJaEZtVWk4S3ltN2FoZVds?=
 =?utf-8?B?YTVOUXdXU05kT2E4cmY1M3ZzQ2xzcDJDWEt4eXVJWDhoUzJ2ZXZRNXpJdmVh?=
 =?utf-8?B?YTVycDhReXFub05ndWE5M3F0R1MwSGxycWptaS9ac1YzTndPQkdXYWQrRlZD?=
 =?utf-8?B?blhKd0c1RkFEQ1EyZ3FIdDU5REtVb2JCeWJYbG5RRk5OTkFNUSs0cHdybFdB?=
 =?utf-8?B?Y0RhS0RtQnNUN3BCd3lXak9OS0RVU1NPNjd5Y05uQlN4MHlDWHVCNnpYWjJx?=
 =?utf-8?B?eWEzQ0lPOWV3QmxpWVl4MTFlV1BQcGdpODMrd20yd3VKUjU2U2ovQ3lyTzdZ?=
 =?utf-8?B?aEZSRWVIT0dJN09oVTljQWNYUktoMDZBRVdOa1BsbmI2QU9KYXRUNXpZRW9N?=
 =?utf-8?B?czUybkkxS1RPaCt6R2UvWGtKNVBNcG5wcDJsTnk1VzVCYm5HclVYNGNoYlI3?=
 =?utf-8?B?UWcwSXVEMk56cVdBT1JuWEhHYUJBVGcycXZmTVRTQ3pQcVNqNnFCcXFkcjBu?=
 =?utf-8?B?Z0ZJV1RNS2ZMYitoNlU3M3g5dUJnYU14MElad3RDdFd1ZllJazA3UytZcDc2?=
 =?utf-8?B?OE1VUkI1dFl5Y3VoN1BQR0NIcFBCTkJXSnFZbEtCVWhPb2NQU05LamcvYmcz?=
 =?utf-8?B?MG94UEJnSkJNKzhRbkUxMlRoY1FoTU8yaFcrTVB0ZzUwRzdIQlljN2grYW5D?=
 =?utf-8?B?dWNoTkNZOXJ4dWVzeW5JbFpPOGd5czdTcVhQSGVwZTNwUHdJRllrNDBXNDJK?=
 =?utf-8?B?RVI3SUhsL3h3TVgrUHlITXYyQjZ5b25rUzdacTJ1KzlOem1KNHJydXlaUS9T?=
 =?utf-8?B?b253enN0d2c0R2JlVjRRQ2VGMWJLd2E0WWgwVDN1cHpJRXcrUXFRRDB4bldR?=
 =?utf-8?B?VGovQnF4bktrYlNtajFwb0dMVldKK2dZdmI5YXZBYXRnRmM1aUtoeXIxL0Fu?=
 =?utf-8?B?YVhrdTczc050R2hJenlzMWxBeFRRZTBaOXBwc0tWSllrL09IZUtSSEdGQ2Iv?=
 =?utf-8?B?NXRoOVY4b0NFdEw5WTk5UU5NVjQrdGVITDJSSGkyOGRmUUNqMitPbUEzTm8w?=
 =?utf-8?B?YS9qVTdlYjBvYTZFd1duK2NqNjRLY083eTYyUTQrc2ZFbWRNT1RDVFhNcUda?=
 =?utf-8?B?dnh0MllGMCtCMnF4UkE3bTNpVXBNMnZ3Q0Zocy9QaWw3aFVxa09jQnJ5Y002?=
 =?utf-8?B?SXI2UGUydDA2eFZCR3QrYW0vS3YrTEg0TmRvMW9jZEJLbXJVS1BPMm95UUxp?=
 =?utf-8?B?RGw3M3YrekliOTVJQlAvMWFHR1NPRjhwOHN4RTdhK1RjYVFNTVlEOUpnMWV2?=
 =?utf-8?B?U2tUTThxYndtbWVkdnlRUEpkbkdCbVE4R2JRMlNwMStBa0NHR2RFQ0tTOWlR?=
 =?utf-8?B?QzNHa2FMckM4Z08vNkJiUTdsN0hLcTg4cThTeHQvNWl5cVY3dW1WZDdCR3FG?=
 =?utf-8?B?NzJ3UnJrU1htTkJGQzBzUDlDMU9GSThsZmFsVFd3SFVTWThNcUhERkt2Tm5D?=
 =?utf-8?B?cXIwdG1uTHdqeHdWSk9JanZXaEVJRWluc1lEaG5Ta0tkVWZERno0WUdvdXJn?=
 =?utf-8?B?NUxxcyt5eWYrYzFqaW1sdFAzTDZ0S2RvZjdIUDQycjhxdElPaHhhNTZmUjBC?=
 =?utf-8?B?eEx2aUhyNkkxT0pESDFwenVtOUlaWjVKZ004VnhFMEZqT1Z3QTJLN01DbEFx?=
 =?utf-8?B?YzJGaHFySTZtTmZKOVFwVFMrdDdVWTlzNWxleW5Mc1d5RkdTSEI0emdleUVB?=
 =?utf-8?B?UGJsaGdHTldHK3IvekFFcmZlLzBoMktrQmc5YUpabnk3endETERsY2k2d1Vv?=
 =?utf-8?B?ak04UkUvdEhWZGRWZHp0VmlXWWtvWXBwbEdRQ09ndzlIKzc4bVJlcUFMcU1N?=
 =?utf-8?B?V2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5843063-1a63-4835-c046-08db93c1f0fd
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 01:35:38.5352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F0Lz1H/xF65HvkSvACIdiAa3mFdXitBj/DRbs+YB81Fbh9Uk1I4U3ohW5ZJBMrE1JU84tEpCaOCM46odcvEMRczD+KjmCqxGItBenTbKnFY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8679
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/2/2023 4:07 AM, Souradeep Chakrabarti wrote:
> At present hwc timeout value is a fixed value. This patch sets the hwc
> timeout from the hardware. It now uses a new hardware capability
> GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG to query and set the value
> in hwc_timeout.
> 
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>

Looks sane, thanks!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

For future patches please use imperative mood for your patch
descriptions, no "This patch" [1]

[1]
https://docs.kernel.org/process/submitting-patches.html?highlight=imperative+mood#:~:text=Describe%20your%20changes%20in%20imperative%20mood%2C%20e.g.%20%22make%20xyzzy%20do%20frotz%22%20instead%20of%20%22%5BThis%20patch%5D%20makes%20xyzzy%20do%20frotz%22%20or%20%22%5BI%5D%20changed%20xyzzy%20to%20do%20frotz%22%2C%20as%20if%20you%20are%20giving%20orders%20to%20the%20codebase%20to%20change%20its%20behaviour.