Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1677809rwo; Wed, 2 Aug 2023 19:40:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlFsRLmkKtmRVWBFU+QkZ69Wwp82UQuJcJ0n5UcATuT9N4K08Xai6t1Ym48V07plE4DfUKlt X-Received: by 2002:aa7:dcca:0:b0:522:55cb:ad88 with SMTP id w10-20020aa7dcca000000b0052255cbad88mr6004662edu.6.1691030458218; Wed, 02 Aug 2023 19:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691030458; cv=none; d=google.com; s=arc-20160816; b=CK+EKcjKXhpo65W53Z8Bacm5TOC0uEN2mavzm3/NEh0OdjtT9iMvXtgoJnU3R7pcAi /7JPBLcae+fXo/3fVFc4a//+3XspiX5K2O3plGWTlP2rXY39wjRG5/RFNotaEDUp2/ol Vpj9sWWM6soVhbjV4P696IXa5ufcmxV0bwI2UkmSWZpJ6f8kCI1llwRV2pp9Vgdm9q3i diuVJKGoU2rvAaAtoyMxQoFEmou51cyZTq2kphS6o0PdYr8Q7swUNS7No/nUmZOV3C33 HH0Uly4rq3lAPaGl8VDPWDgS4Fa/CnnDLVz1SBxxEEVUG2RtBBBweHgbol8Qg1h8qwGI F8xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Pemp6gVRoadtWy3QkjFla+/TmubFa0l+7vR/RQVlub8=; fh=qg0hdM9XDdCkjBmYGSS/VM+QAasBkM7kfglSt8/HgRQ=; b=wX2gRHZPpOM/1S2l1xbrcMZoNBDvcF9gRb+ALW1tOpK69OiRKg2p6faTrYErBFJzDb 7QhzDttLl+T0gDfcFVHvYIy/vUo/47CQErsLm1nc5mlZMRvr5/blJxSkbIbki4dgaDwj 2UJARRTFoItdLf6BFsEChNtV6wPElsMZ8QVrQyUvMq4B9sg1EwtnRpNjzpZlJTV2s7EI eemvXiofmtmROmQnAlbiveXxHDovCndYv22Mhd49SE413/5p9WKxD4+5v6YLSyW/dA+6 6AJhi/r7pP0Ic9o4SqGDzVUH6LH8IIDZKDBVDXIVsIY5AXG7U+6Kbukj1Ou6SXBk9bCg m3oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cf3SYePT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020aa7d4c7000000b00523028f09f9si1476026edr.396.2023.08.02.19.40.33; Wed, 02 Aug 2023 19:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cf3SYePT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232274AbjHCCe2 (ORCPT + 99 others); Wed, 2 Aug 2023 22:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234016AbjHCCdX (ORCPT ); Wed, 2 Aug 2023 22:33:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8DF46180; Wed, 2 Aug 2023 19:30:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7492261BB6; Thu, 3 Aug 2023 02:30:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C0AEFC433C7; Thu, 3 Aug 2023 02:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691029821; bh=aOYpkIHh/DPbsxHUKna75zI7rjpRLM5Mkvu+b1TwdCc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=cf3SYePTjJjzCoHKr6jzywybKWLiWijzqWO7GEKNzaQbRKy3Citemkb0V/D3DEUzc JIWxXQxMaVLkAdJcmiIQgIp7lZX3X6gC+LPG1ZPumf62DB4l0yO1LkDbSSFZgUxamV qerPnacB/KZwef5wuFQr/Plij9BUyydZquQTmaDhoQUuQUUzpF9TEc1AL0Yjx2uSeN HPwf8cCtMmCFKIzdYWhAgznNN7vbskpk+5tB4Z9vCl/F4LmuLrAr60E8R+UHYfxc/N oVFnTQRYdNMKBJpb8Cw8HYqNBJIDm5EVhFMdZwxAZl8idm1n7NEGTaUOOZZUkj6saZ M6NpmDs7zWDtQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 9E318E270D1; Thu, 3 Aug 2023 02:30:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] udp: Fix __ip_append_data()'s handling of MSG_SPLICE_PAGES From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169102982164.22584.2159457611636116632.git-patchwork-notify@kernel.org> Date: Thu, 03 Aug 2023 02:30:21 +0000 References: <1420063.1690904933@warthog.procyon.org.uk> In-Reply-To: <1420063.1690904933@warthog.procyon.org.uk> To: David Howells Cc: netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com, syzbot+f527b971b4bdc8e79f9e@syzkaller.appspotmail.com, bpf@vger.kernel.org, brauner@kernel.org, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 01 Aug 2023 16:48:53 +0100 you wrote: > __ip_append_data() can get into an infinite loop when asked to splice into > a partially-built UDP message that has more than the frag-limit data and up > to the MTU limit. Something like: > > pipe(pfd); > sfd = socket(AF_INET, SOCK_DGRAM, 0); > connect(sfd, ...); > send(sfd, buffer, 8161, MSG_CONFIRM|MSG_MORE); > write(pfd[1], buffer, 8); > splice(pfd[0], 0, sfd, 0, 0x4ffe0ul, 0); > > [...] Here is the summary with links: - [net] udp: Fix __ip_append_data()'s handling of MSG_SPLICE_PAGES https://git.kernel.org/netdev/net/c/0f71c9caf267 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html