Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1726757rwo; Wed, 2 Aug 2023 21:02:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEJGHyXAujx9zytRWgLqNY91U+m2oU2+MDq9m2wRmC9t3f1kRcJ6e+eYFCNwPDOg0R8gwA6 X-Received: by 2002:a05:6358:9913:b0:134:e06a:ef40 with SMTP id w19-20020a056358991300b00134e06aef40mr9061359rwa.17.1691035341952; Wed, 02 Aug 2023 21:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691035341; cv=none; d=google.com; s=arc-20160816; b=Q7Ijdrcglb9dhsY8g+A2azPZWu3omVhmuWr/mXaJxw38KvT5md9l/3epUvHiBGBijT YOlc0pF++LcuOMJS0WKuBlkKSwmrHUTOSeNgfqbLa4Fiqr5YfaT9tYWWpv8N9jDlQgUh +JQm1tSTOsQz4uyF1dYiOBenSuT8RMLE3lMRg9pKjeOevpZ1eGQKBJdV5+EXJrI3hpqw WFnx0i7Ya8DCPzGiN9XOi9B4zbLHeinrKtKzpbnX0cgAiXYelCUTk83Dor+xWpTLKiG/ 5IhvW7gMMhNznS0vygj+URGrdWXrgaFk04BJf1Okea1LXqi8wibyjzEPIdpiV/MZUPWD I5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ellgk25mxUvJBoah1nNjM4dRfulsWpInzV7skfbNp8I=; fh=Kb7lPjdYBsgNhhrPBmQoI5mAFUva36XgZZdQdjSdvbo=; b=07sf/GlGAo5PhFunkydPkGux+fqk9I/ne9CXxQ/WRuxODUu3//O/NqN8tF/r+5tzup D6lZ9JFmW/5x+ky6jrBUF9tgijJ77XvNllMGcsqPjnREgvX7mNvW32E1iVQNAcvf+91i Ekugtrz9uWdhlrJ1yVHTKlsZRAOzyT6URO/4YSPUep4CtOs0HzZtNlsYr64vyc11yvtf R3V/JasoUDDdxrbcxdo3zc+Nshp/Lbd6By4gDc5aBzniKbFy6jkHWk97Y7X/l/nt0VFR K4E1MGV7jVTNVVSYqmigQb2yAdTmjEB8HXNNGNYz/IjZkhmKAYFapl6l4CP4tX5OSIWP F3hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a24-20020a637058000000b005642e996827si7949374pgn.508.2023.08.02.21.02.09; Wed, 02 Aug 2023 21:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233340AbjHCCy6 (ORCPT + 99 others); Wed, 2 Aug 2023 22:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjHCCy4 (ORCPT ); Wed, 2 Aug 2023 22:54:56 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CFC4A10A; Wed, 2 Aug 2023 19:54:54 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.201]) by gateway (Coremail) with SMTP id _____8Cxh+j9FstkOW4PAA--.39S3; Thu, 03 Aug 2023 10:54:53 +0800 (CST) Received: from [10.20.42.201] (unknown [10.20.42.201]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxzM78FstkEI1GAA--.51281S3; Thu, 03 Aug 2023 10:54:52 +0800 (CST) Subject: Re: [PATCH] usb: xhci-plat: fix usb disconnect issue after s4 To: Greg Kroah-Hartman Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn References: <20230802090642.1642-1-zhuyinbo@loongson.cn> <2023080243-matted-abnormal-0fb0@gregkh> <4ee866a1-39a4-3b88-20f6-108e605ab00e@loongson.cn> <2023080222-sizable-gauntlet-e658@gregkh> From: Yinbo Zhu Message-ID: <73446dc0-d2e0-1d80-8107-186b8c41bee5@loongson.cn> Date: Thu, 3 Aug 2023 10:54:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2023080222-sizable-gauntlet-e658@gregkh> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8DxzM78FstkEI1GAA--.51281S3 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/2 下午6:06, Greg Kroah-Hartman 写道: > On Wed, Aug 02, 2023 at 05:58:17PM +0800, Yinbo Zhu wrote: >> >> >> 在 2023/8/2 下午5:39, Greg Kroah-Hartman 写道: >>> On Wed, Aug 02, 2023 at 05:06:42PM +0800, Yinbo Zhu wrote: >>>> The xhci retaining bogus hardware states cause usb disconnect devices >>>> connected before hibernation(s4) and refer to the commit '547d55fa83 >>>> ("usb: ohci-platform: fix usb disconnect issue after s4")' which set >>>> flag "hibernated" as true when resume-from-hibernation and that the >>>> drivers will reset the hardware to get rid of any existing state and >>>> make sure resume from hibernation re-enumerates everything for xhci. >>>> >>>> Signed-off-by: Yinbo Zhu >>>> --- >>>> drivers/usb/host/xhci-plat.c | 21 ++++++++++++++++++--- >>>> 1 file changed, 18 insertions(+), 3 deletions(-) >>> >>> What commit id does this fix? Sorry, I misunderstood your meaning earlier. This patch is not meant to fix the bugs in the previous commit id. Actually, it was to fix xhci issue that refer to repair of ohci (commit id "f3d478858bec4"). >>> >>> Should it go to stable kernels? Do I need to add Cc about stable kernel for the above situation? Thanks, Yinbo