Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 22:05:56 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Alison Schofield <alison.schofield@intel.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] cxl/mbox: Add handle to event processing debug
Message-ID: <64cb35b4ef5cc_9473e29411@iweiny-mobl.notmuch>
References: <20230731-cxl-fix-clear-event-debug-print-v2-0-9bdd08d386e9@intel.com>
 <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com>
 <ZMqEY2qj8s8uKZlN@aschofie-mobl2>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZMqEY2qj8s8uKZlN@aschofie-mobl2>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WJyjSKtf75Djd6oJkWWnLZacJczTpkDyR6nmpsySY7I3ue1zUJKWRwzwbo0n?=
 =?us-ascii?Q?UXhgSu94HtU5N3aOyUJOrnrhfMduWv7iLuHbaKzz1Fd9tuP3u33rv0Va1yNG?=
 =?us-ascii?Q?0zNb0bQ9bGFZOhRrr2GC4IGZIamFOHoINUGLHxEXqw5KLzQqYym2Tmv9JCkq?=
 =?us-ascii?Q?dL0EKUBByhZUGGe198+cgOT2tNUglN4KzdrRn1TuOGQbJ9qvzUsnd6MYGKj8?=
 =?us-ascii?Q?5czPl1nmFBvhs6yR23RmqfczR+KujmW98A/AAzciF8nAdpW1/Le1+zfN4Zr4?=
 =?us-ascii?Q?zPE+Tiwy+2KrCsAS+dag8n6wGuPtz3Prb3+TZX8lzIVjU4e1ozt7uvhmQ50V?=
 =?us-ascii?Q?9VSEGuMSHuedB9ucANAUUzBOhxXVQYpjpmJ8qhhgJ1Uz7ghFEFJ2JPaJ+NlT?=
 =?us-ascii?Q?c8R/KDMJ9W9bTsm5A9jcvp/jwffP9jZtsurdMOno0XOR/7EyPw/iANovvLEZ?=
 =?us-ascii?Q?46nLBixBXrzdt540/s0HDlpK9z+jTc35SeZTrSBIFq4QSqHCm+C/aJhTXYFm?=
 =?us-ascii?Q?Ls7XD4t/TcV1SnmLn2ojL9WwR6qLm1RWgrI6p0pdOMh33+r9ZqxMChO7aMKO?=
 =?us-ascii?Q?QsuT9RS60fkMdhANLWVGw2WxUOJcCCLsU9/9WjlXx5CHP6ZcSjRwgkYy8oh4?=
 =?us-ascii?Q?TT/njdgy6fGNTuKMIwUT2h7JBA9qdgj4F0G2lIq659ky4aa4wTEZnaODyNIT?=
 =?us-ascii?Q?9dCswPx8hh5iDXuKrlsmxHrOnWzu33XxKvDfYGkfhTTnq3N/cdFg1IqHkEp2?=
 =?us-ascii?Q?QrVdaelX2HPRosDmqcJQayUOaLmE7yOdoYNCQ35cAWJi2YKQafRwOekUdvRN?=
 =?us-ascii?Q?7WGR+W5wtpT+ZpM8EfNK4dNr3S2J+ccL851rORga6WiwcGocMe1FzU4Fzusp?=
 =?us-ascii?Q?pOXIJ2hlxUixVz+3Wc6478Vea7e/I1xWStdy5jHZ9m948gnyFPPsmW3VfPz6?=
 =?us-ascii?Q?wIXAFPV8JIA4oc9nCJfJF2siADeIvofchyFfaxiDNrEc9w1HhDMAl+AvR3o7?=
 =?us-ascii?Q?xIkg2PNgCSKWZjZttA4kGl3LDuSmyHe6dushYZZsK462nvw33liT8Ud1CTQj?=
 =?us-ascii?Q?aNO2cnz4GTmYv6ibRw+Ul1OJq0gwCd8/pZdZPawWJWj/UGdoI5SbOf7G0GlJ?=
 =?us-ascii?Q?NJ2vnV0Nla938IZCRHaQtCHSDdRdbg8qdOPwvBuznLL62j1wPJC5uVeTABvR?=
 =?us-ascii?Q?rmVwoosY/wxf4P6FszSdwkAHK0Poaulqwh/dgcjIfM7aTQ3Qy92xTqaRiPm9?=
 =?us-ascii?Q?BRXgOYIKhuvX3BDWsVEX1ATLyoq4IqP2v+F4Tskw8ffUypB6kBgRY9h29S7E?=
 =?us-ascii?Q?/3NrvqL5l/7D4r5wOddOzSLZgRMbwo2Z4mH6Vsn1Q8bSvTvwVC9zlTMdCTob?=
 =?us-ascii?Q?FjmO6NNbskS0wo3kPjHb23vQGpq4VJYVuMxrU4s2ugvfoA2ZEfyfVahh7aBP?=
 =?us-ascii?Q?iSh2+TNiBvmLwN0WWe6YdXY/WMvFkJ0hz55MW8n06knpXrjd6YUrlchNddix?=
 =?us-ascii?Q?lgBWjn2hQNH7Z6A+Yr+CqyvSwUKKjv0xFuq4pbhehT/vAnnOr3DVmKkjNX4n?=
 =?us-ascii?Q?tKobFbU/2GAznERXx+0TgtLipuP6NU0unTps2cI+?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3a79b15-ab2d-4b08-651c-08db93df53ac
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 05:05:59.6699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1HbYrgVrAcVdo8QeuXtXGrl60mqds3CwxiBlNLL8uCZKZtCdm0kX1I4aZBzjxSPX2i6rrPtKtxFMBYSxic/vwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4915
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alison Schofield wrote:
> On Tue, Aug 01, 2023 at 01:13:29PM -0700, Ira Weiny wrote:
> > Knowing which handle is being processed helped in debugging new event
> > code.  Add a dev_dbg() message with this information.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> >  drivers/cxl/core/mbox.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index a1c490f66bbf..f052d5f174ee 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -947,9 +947,13 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,
> >  		if (!nr_rec)
> >  			break;
> >  
> > -		for (i = 0; i < nr_rec; i++)
> > +		for (i = 0; i < nr_rec; i++) {
> > +			dev_dbg(dev, "Event log %d: processing handle %u\n",
> > +				type,
> > +				le16_to_cpu(payload->records[i].hdr.handle));
> >  			cxl_event_trace_record(cxlmd, type,
> >  					       &payload->records[i]);
> > +		}
> 
> Is dev_dbg() overkill when the info is in the trace event?

The trace event will not happen if tracing is not turned on.

This was all part of my testing the DCD events which don't have to, and
likely will not, have tracing on.  So this helped to track which handles
were being processed from the cxl-test and qemu layers.

Ira

> 
> >  
> >  		if (payload->flags & CXL_GET_EVENT_FLAG_OVERFLOW)
> >  			trace_cxl_overflow(cxlmd, type, payload);
> > 
> > -- 
> > 2.41.0
> >