Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4CC3DEEB40C0DEC3+d4d7dfc3-0e9b-9185-d72a-419b36fc1f53@tinylab.org>
Date:   Thu, 3 Aug 2023 12:41:23 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] powerpc: pmac32: enable serial options by default in
 defconfig
Content-Language: en-GB
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
References: <bb7b5f9958b3e3a20f6573ff7ce7c5dc566e7e32.1690982937.git.tanyuan@tinylab.org>
 <88334e42-a3c2-dab5-fdcb-91305d672e5b@csgroup.eu>
Cc:     falcon@tinylab.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux@weissschuh.net, w@1wt.eu,
        npiggin@gmail.com
From:   Yuan Tan <tanyuan@tinylab.org>
In-Reply-To: <88334e42-a3c2-dab5-fdcb-91305d672e5b@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1
Precedence: bulk

Hi Christophe

On 8/2/2023 9:58 PM, Christophe Leroy wrote:
>
> Le 02/08/2023 à 15:41, Yuan Tan a écrit :
>> [Vous ne recevez pas souvent de courriers de tanyuan@tinylab.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Serial is a critical feature for logging and debuging, and the other
>> architectures enable serial by default.
>>
>> Let's enable CONFIG_SERIAL_PMACZILOG and CONFIG_SERIAL_PMACZILOG_CONSOLE
>> by default.
>>
>> Signed-off-by: Yuan Tan <tanyuan@tinylab.org>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Can this patch be merged into v6.6? There's another patch depends on it :)

Best regards,

Yuan Tan

>> ---
>>    arch/powerpc/configs/pmac32_defconfig | 3 ++-
>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
>> index 019163c2571e..3aae79afb9d9 100644
>> --- a/arch/powerpc/configs/pmac32_defconfig
>> +++ b/arch/powerpc/configs/pmac32_defconfig
>> @@ -176,8 +176,9 @@ CONFIG_MOUSE_APPLETOUCH=y
>>    # CONFIG_SERIO_I8042 is not set
>>    # CONFIG_SERIO_SERPORT is not set
>>    CONFIG_SERIAL_8250=m
>> -CONFIG_SERIAL_PMACZILOG=m
>> +CONFIG_SERIAL_PMACZILOG=y
>>    CONFIG_SERIAL_PMACZILOG_TTYS=y
>> +CONFIG_SERIAL_PMACZILOG_CONSOLE=y
>>    CONFIG_NVRAM=y
>>    CONFIG_I2C_CHARDEV=m
>>    CONFIG_APM_POWER=y
>> --
>> 2.34.1
>>