Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <VishvambarPanth.S@microchip.com>
To:     <richardcochran@gmail.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <Bryan.Whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>
Subject: RE: [PATCH net-next] net: lan743x: skip timestamping for non-PTP
 packets
Thread-Topic: [PATCH net-next] net: lan743x: skip timestamping for non-PTP
 packets
Thread-Index: AQHZw2rbMPoDf41Sy0CTnd7RT703zq/T5UkAgAK7ffA=
Date:   Thu, 3 Aug 2023 03:39:34 +0000
Message-ID: <SN6PR11MB3341B905C5D5705205A4D839EC08A@SN6PR11MB3341.namprd11.prod.outlook.com>
References: <20230731125418.75140-1-vishvambarpanth.s@microchip.com>
 <ZMe8To+Rw0/pcjLv@hoboy.vegasvil.org>
In-Reply-To: <ZMe8To+Rw0/pcjLv@hoboy.vegasvil.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MU5z/WoMW6BBCi1Jd6PLJ4fEiTmW8ChgsnXOx29u5LoqwW85CuNs09RMniZ+?=
 =?us-ascii?Q?v8Vcqbc9hIN2qtiS6yulp5HFqAkbbWCTMh8r+uUdxyML8lstGxX5swOWRslU?=
 =?us-ascii?Q?ps5FFRPGT6aQmBL8J9czOlh5mwPdSRCjO3NeKdOvvc/aNlZJd0B6CXZhPrTX?=
 =?us-ascii?Q?TH9YUsYmExTkePXmpwBdnnUMub1TiD5JAd0s7AftgqmfmGXIPK3kZpBSjN7N?=
 =?us-ascii?Q?IF99QtK6BzWMjGI0FJQogYYDTEeb3CW8WR6T4mFWGvaubDyQbpyOZelJzdti?=
 =?us-ascii?Q?hcFdnMnwW1igQZ380qRLhYMvRn6o/RuhxSlB5O1q+M0dv/XNH6T+pVYsdyr8?=
 =?us-ascii?Q?em2e/WgcWUUDw+bwtS4f9/g6uk4LHOa0HDiMUdoweDIqCrw1Gym4kzIcorMm?=
 =?us-ascii?Q?jtqN/Gw1qy2loE4JwX+HMhaYCQEz9Eov05HSsiPbb67ucmGEtd/PXUQ3KHJG?=
 =?us-ascii?Q?GQySiyWFo+Yv92PfrUVv9f3fppY3cgyJKa7zkzTtvu/0Pzg2bvObvWVo4RhF?=
 =?us-ascii?Q?wu66sC6C3mdef9u4DObqbukS+PfYuOSWCouBs4Ey2gkOWOkhBTPpbEPlsACG?=
 =?us-ascii?Q?mkBMbI3i2xohd0gVZinERpA2E9mqc9rnspyBg0DcgIe4Il7bYx51E6eFYCwy?=
 =?us-ascii?Q?yqDXKUrCA11bEyZ3P8e1yvbcwRiMK3KoPFmdXEH/p8M6KqrB5iycPUGsiCSG?=
 =?us-ascii?Q?ZKvHsI2krLI/BRqK49aU89bBPUGq33FKF1eIbH2r3iIYGitSBnoQZyNiJy38?=
 =?us-ascii?Q?9XzaBH8ITfP/emC4lWvZ5b8O+HpoecOuhM2qnzKB7raOVJeceDok5RVopFeJ?=
 =?us-ascii?Q?ZQkvmcVqRGPajPffQMwIU+RSYsX+VG/UPFXSUxYMwB8eIoTVCJrPeKc4W9jz?=
 =?us-ascii?Q?FT+T2H2AeA3ms5pMgea+l2NYv515UCJ7dVf9Vm8wv6R/nvMPUqxSO0RWu2Il?=
 =?us-ascii?Q?LMqRHZxNI8R2gyry2sJccBfvEMOjGI7jrOKBmYXxyY87JuB2aLtjMz5At8Gq?=
 =?us-ascii?Q?3W35m0A0mPgzP+Tm/7SHXo92op+ICxupqMKZoPMXIwaM+MegqWwl0qtSxP2b?=
 =?us-ascii?Q?wZkBAs2oPkaPUmId4q5eUvpRF5QWiqLHB66oxxJGiwrXkETgO4W0gSpNPDIm?=
 =?us-ascii?Q?82TM7x7FzXKP/H41gT+2mXVBVAesVw0tza1dYQ54YO99+uh/DEIZ4V5gz8f9?=
 =?us-ascii?Q?8KdVCej2daiLG0TriA73dczhzFCOKVxbzEk4wpT10Z7cQ/VcLPbh3F9mgM38?=
 =?us-ascii?Q?Fveebq7kuB1h/URlZnENazewiMsSw7eAiKy2X/DWU/K/4i64IE1q6+oDMnVW?=
 =?us-ascii?Q?KloV04hSes5rNF0eZwcpx11PmmcyvijWNTTOj1i4G6pGI43JCUGVsazxil6g?=
 =?us-ascii?Q?it1+gOIPMEYYZeZ/HGu0mL+K5jXNi7drppKp89LaBsAnwMWozbgJg/japm+w?=
 =?us-ascii?Q?96+SBhNd8q1i7mEceQT76LgS3T6i4AwqUdQPMu4VbtSvHT/vGzLZR9lDuURw?=
 =?us-ascii?Q?E2RpbzQ1WiYQZHLszyKxjW9Zgbr8kEjoIivRRmEtXvEZfOOGwGCuO7dMbvvR?=
 =?us-ascii?Q?7livvQSmx4Yc1u1MbNBlvm8Es+/c9z4MxYNEqh5jsRtXm0zyEhbD0K9x2G2I?=
 =?us-ascii?Q?3w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3341.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8504b372-d21a-40ff-c94a-08db93d34118
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 03:39:34.2244
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Fz9UVyke226dHaGvtjafTo31Rw5M8i16qNPJEeP7Hay7pXjmeN57124zsygGD7ZXLllBMWuHywKONpSqR/SNZee2VvGKg1GOAHhDdIl2Wq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6506
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Richard,

Thanks for your review comments.=20
We will work on configuring timestamp based on hwtstamp_config. We will upd=
ate in the next patch submission.=20

Thanks,
Vishvambar Panth S

-----Original Message-----
From: Richard Cochran <richardcochran@gmail.com>=20
Sent: Monday, July 31, 2023 7:21 PM
To: VishvambarPanth S - I69108 <VishvambarPanth.S@microchip.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Bryan Whitehead -=
 C21958 <Bryan.Whitehead@microchip.com>; UNGLinuxDriver <UNGLinuxDriver@mic=
rochip.com>; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pab=
eni@redhat.com
Subject: Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP p=
ackets

EXTERNAL EMAIL: Do not click links or open attachments unless you know the =
content is safe

On Mon, Jul 31, 2023 at 06:24:18PM +0530, Vishvambar Panth S wrote:
> Currently all the RX packets are timestamped and the timestamp is=20
> appended to the RX packet for processing, this reduces RX throughput.=20
> This can be optimized by timestamping packets only when the PTP messages =
are received.

No, you should not do this unconditionally.

Instead, you need to dial the correct setting based on the hwtstamp_config =
in lan743x_ptp_ioctl().

Thanks,
Richard