Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30b83376-0b0e-067f-ed87-a68a3c45086b@kernel.org>
Date:   Thu, 3 Aug 2023 07:20:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Content-Language: en-US
To:     oushixiong <oushixiong@kylinos.cn>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
References: <20230802022049.1674070-1-oushixiong@kylinos.cn>
From:   Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v3] tty: vt: Remove some repetitive initialization
In-Reply-To: <20230802022049.1674070-1-oushixiong@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02. 08. 23, 4:20, oushixiong wrote:
> Members vc_col, vc_rows and vc_size_row of the struct vc_data have been
> initialized in visual_init(), so it no longer to initialized them again
> in vc_init().

The patch looks correct to me. The duplicated code comes from some 1.x era.

The part after the comma should be something like:
"so it is no longer needed to initialize them in vc_init() again."

> Signed-off-by: oushixiong <oushixiong@kylinos.cn>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
-- 
js
suse labs