Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 11:28:46 +0530
From:   Jai Luthra <j-luthra@ti.com>
To:     Nishanth Menon <nm@ti.com>
CC:     Francesco Dolcini <francesco@dolcini.it>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx
Message-ID: <mhz63eszfuovzbrbzconkazzt3xvwtlko3nej7saimrilyfrm5@ok2kkggbapyi>
References: <20230731142135.108477-1-francesco@dolcini.it>
 <20230731142135.108477-2-francesco@dolcini.it>
 <itvg2zmmapbfmgbwos6c4y5zsc2rb3sffv2znhwz6i2vahe4y6@uu2547kcz5sd>
 <23C6E13C-3F10-490B-A18E-C67B91CBAF35@dolcini.it>
 <20230802133244.b66pg3mztotgqotm@steerable>
 <ZMpc7x8U91JLVakd@francesco-nb.int.toradex.com>
 <20230802140020.k233zqpjar5ag4iv@outbreak>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vphmbkt4zdnaykea"
Content-Disposition: inline
In-Reply-To: <20230802140020.k233zqpjar5ag4iv@outbreak>
Precedence: bulk

--vphmbkt4zdnaykea
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Nishanth, Francesco,

On Aug 02, 2023 at 09:00:20 -0500, Nishanth Menon wrote:
> On 15:41-20230802, Francesco Dolcini wrote:
> > On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote:
> > > On 13:37-20230802, Francesco Dolcini wrote:
> > > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scr=
itto:
> > > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> > > > >> From: Jai Luthra <j-luthra@ti.com>
> > > > >>=20
> > > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an in=
put to
> > > > >> external peripherals when configured through CTRL_MMR, so add the
> > > > >> clock nodes.
> > > > >>=20
> > > > >> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > > > >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > >> ---
> > > > >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++=
++
> > > > >>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++=
++
> > > > >
> > > > >Given currently none of the AM62A boards are using the refclks, ca=
n you=20
> > > > >drop those or just mark the nodes as disabled. Whoever is the firs=
t user=20
> > > > >can enable them.
> > > >=20
> > > > I can drop the 2 clocks from AM62A, however, should we really do it?
> > > > These clocks exist and they are just defined in the DTS, they are
> > > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also
> > > > not disabled for example.
> > >=20
> > > Overall, the SoC clock as such has nothing to do with board specific,=
 so
> > > leave it default (enabled) in SoC.dts - just want to make sure that t=
he
> > > clk-parent selection doesn't get in the way of platforms and is a sane
> > > default.
> >=20
> > When I looked into that, months ago, this looked to me the correct and a
> > sane default. I had the same in our downstream way before the addition
> > from Jai Luthra to the SoC dtsi.
> >=20
> > Not sure if Jai can add more on that regard.
> >=20
> > > pll2_hsdiv8 output - which looks like the default mux value anyways..
> > > I am ok for it being explicit, but wondering if that works for boards
> > > that do not use this default.
> >=20
> > IFF needed, it would be very easy to just override from the board dts,
> > using the labels that are already there (audio_refclk0, audio_refclk1).
>=20
> Jai: This sounds sane to me, if you are OK as well, I'd appreciate a revi=
ewed-by
>=20

Makes sense, most external peripherals would prefer that default PLL as=20
parent - for other usecases what Francesco said can work.

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> >=20
> > > (sidenote): Fransesco - your new mail client has line wrap issues ;)
> > Yep, I had the crazy idea to reply from my mobile phone while having a
> > walk. It's already a success that I did not top post ;-)
>=20
> hehe ;)
>=20
> --=20
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DD=
B5 849D 1736 249D
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--vphmbkt4zdnaykea
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmTLQhUACgkQQ96R+SSa
cUWv3g//Up4niurohAiYtx6RDrADpMcBRcNofI20ZBpN05GAEi9Rku4Ht1G52l0L
9mOC2nxhzJnBAPfFb8MaUHnD8eov0qb63+KorZwRz58/nwygedyIKAM1GYcAI7NY
t/p7nLgjenWbRRkEtX1ARpNcKou6zzIgy5n9EkLj+y3FQwNHHlkJIRVCKTuqwt4r
9h7o0DKCfNCXljjFlgYe/1sn617KMkfDUkelafKSTXd+PvblKEqvqO6ECrYB1VvT
7jBg491dE6DYayKcKKDGobtW0HUy8ex1GUsCNjyF1cgxVWsdg6l+JNCzMdeoENA8
5nrofUTZURg3M8i9siLtEVua2ygT0GxBf1oP3E+iOFdEpvq3I9lpySffsCM9ZX1R
DBUV26P5zSdJQ8lvNnJcMV7nyR8ve7oEFx9a2OAx5MGpvYXS2IeRunPDGZ3SGbA+
O73xaAKZOl1d4m+GIXxvRFqdJBUh0NBEh+Z2HJYzPDvU1fpcYco1OnCLLTQk7BaA
l8MyEhaLtx+BAow0dS7ZOSzM8KXxuYt2LbWY5oWA8aeV4xQOM69cJ6n1TZF+HmdO
seEofIjChxMxzkdTq9s1Dhp7zi/rVm4TCxV4uC3jfGU5h2KkM6HwuQn0Ani3k9eP
W257rnY1+LrDShBddHDNgymUmxuLiUsboIKbJLVnsYABi4R7OFM=
=Q0iI
-----END PGP SIGNATURE-----

--vphmbkt4zdnaykea--