Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1846247rwo; Thu, 3 Aug 2023 00:04:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFV0JUERh11fo3UnFjsjwe7nr8jCUYx8lq/3gPRs/VZrNNaWzaQdrVO2KcJMFb0QX7hvIU6 X-Received: by 2002:a05:6a00:1a94:b0:687:8dba:4ca8 with SMTP id e20-20020a056a001a9400b006878dba4ca8mr393854pfv.30.1691046287726; Thu, 03 Aug 2023 00:04:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691046287; cv=none; d=google.com; s=arc-20160816; b=c2v9ITpPB3mTfnFRC21BbAGEF2DEttQSKzbA7yA3aylNtctKhHSPhQ+oN7TcuxlSTv Fsf6CEM5OL2eB+WwGb2HNTHsFFeHATWAlBz9rJ1GNQ0Wr/yAnHAb4nxZucjNjfW/mA1Y vyCLCD1diJxuWyp63CEIFqQ8/4kWKGJBiOkmXLG/a1Zh0kPUINRi521J1mV88vLckhje 6QqqFq+LIh1z2qVirxy5SVE0LDzD1EFQ8+aAIfJj7rbSqvRtmkRjpKnC8j7essNp0zup z6WhBm4mAtyGSSHOdz/X3OcEcoS3mLcNk+Ufo+BM7hcJGtt38n2ViI5OmvVgHngabkmr 5wAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=liYUzcmIsR7cIFgJI5RRAqzsewH4ljA/vCamqY0XU5Q=; fh=/znxbH/1VhICjvWSWqjj5JS4cn9YDN1YA1et5iApeOA=; b=PTXlPAiQ1276d8OvghZMQDSzHzkaOLLBYLhh/27EiU6bP7ovnPbiHF8D2ruSwafRYD Uw8apJvTO7gRL3NPsQ8uLJz2VaUAdb3RFTCHCm2H9tQr8uVHlHeeCzZo7SU/sp/KrLiL aGIV560XQJHIkQJzDat/56Wvhqwo9zvzcfTX46RvVHayFGVhfoGoz+ELiqBaOR0JRxnV DjVzY5JVd8ZfBSfao0ZNFLQOrqWT6qpXZ4Zl94ibo3c7PA79uErXuuWPYWqh/dawvQM1 pyXuGpPs0V6oNBd21HRNMn5NPa8F4rFzr6tVzX5mNyv0+zn6fNMh8lDVDN2At8TasJAY ftzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v24-20020a63f218000000b0056357813fc2si7322040pgh.183.2023.08.03.00.04.35; Thu, 03 Aug 2023 00:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232387AbjHCGhO (ORCPT + 99 others); Thu, 3 Aug 2023 02:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231192AbjHCGhM (ORCPT ); Thu, 3 Aug 2023 02:37:12 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C6CD8E7D; Wed, 2 Aug 2023 23:37:08 -0700 (PDT) X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.47 by mg.richtek.com with MailGates ESMTPS Server V6.0(2288:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Thu, 03 Aug 2023 14:36:56 +0800 (CST) Received: from ex3.rt.l (192.168.10.46) by ex4.rt.l (192.168.10.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Thu, 3 Aug 2023 14:36:56 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex3.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Thu, 3 Aug 2023 14:36:56 +0800 Date: Thu, 3 Aug 2023 14:36:56 +0800 From: ChiYuan Huang To: Alina Yu CC: , , , , , , Subject: Re: [PATCH v5 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Message-ID: <20230803063656.GA19124@linuxcarl2.richtek.com> References: <1690355592-10920-1-git-send-email-alina_yu@richtek.com> <1690355592-10920-2-git-send-email-alina_yu@richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1690355592-10920-2-git-send-email-alina_yu@richtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 03:13:11PM +0800, Alina Yu wrote: > Add bindings for Richtek RTQ2208 IC controlled SubPMIC > > Signed-off-by: Alina Yu Hi, > --- > v5 > - Revise filename from $id > - Remove "regulator-compatible" for ldos > - Add missing "high" for "richtek,mtp-sel-high" > - Remove "regulator-mode" property > - Add and modify "unevaluatedProperties: false" and "additionalProperties: false" > - Remove "richtek,fixed-uV" > - Remove redundant space in "buck-a" and "ldo2" > v4 > - Modify filename to "richtek,rtq2208" > - Add more desciptions for "regulator-allowed-modes" > --- > .../bindings/regulator/richtek,rtq2208.yaml | 196 +++++++++++++++++++++ > 1 file changed, 196 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > new file mode 100644 > index 0000000..63453f2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > @@ -0,0 +1,196 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/richtek,rtq2208.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Richtek RTQ2208 SubPMIC Regulator > + > +maintainers: > + - Alina Yu > + > +description: | > + RTQ2208 is a highly integrated power converter that offers functional safety dual > + multi-configurable synchronous buck converters and two LDOs. > + > + Bucks support "regulator-allowed-modes" and "regulator-mode". The former defines the permitted > + switching operation in normal mode; the latter defines the operation in suspend to RAM mode. > + > + No matter the RTQ2208 is configured to normal or suspend to RAM mode, there are two switching > + operation modes for all buck rails, automatic power saving mode (Auto mode) and forced continuous > + conduction mode (FCCM). > + > + The definition of modes is in the datasheet which is available in below link > + and their meaning is:: > + 0 - Auto mode for power saving, which reducing the switching frequency at light load condition > + to maintain high frequency. > + 1 - FCCM to meet the strict voltage regulation accuracy, which keeping constant switching frequency. > + > + Datasheet will be available soon at > + https://www.richtek.com/assets/Products > + > +properties: > + compatible: > + enum: > + - richtek,rtq2208 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + richtek,mtp-sel-high: > + type: boolean > + description: > + vout register selection based on this boolean value. > + false - Using DVS0 register setting to adjust vout > + true - Using DVS1 register setting to adjust vout > + > + regulators: > + type: object Just curious. It seems this PMIC only support buck/ldo ouput. Since Krzysztof already reviewed it, not sure whether to group it into one node is common or not. AFAIK, if there's no more function included, to put all on the top level may be better. > + > + patternProperties: > + "^buck-[a-h]$": > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + description: > + description for buck-[a-h] regulator. > + > + properties: > + regulator-allowed-modes: > + description: > + two buck modes in different switching accuracy. > + 0 - Auto mode > + 1 - FCCM > + items: > + enum: [0, 1] > + > + "^ldo[1-2]$": > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + description: > + regulator description for ldo[1-2]. > + > +required: > + - compatible > + - reg > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@10 { > + compatible = "richtek,rtq2208"; > + reg = <0x10>; > + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>; > + richtek,mtp-sel-high; > + > + regulators { > + buck-a { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-b { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-c { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-d { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-e { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-f { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-g { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + buck-h { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <2050000>; > + regulator-allowed-modes = <0 1>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <1>; > + }; > + }; > + ldo1 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + ldo2 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > + }; > -- > 2.7.4 >