Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1871467rwo; Thu, 3 Aug 2023 00:38:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlHCnLzCrO+YYXmVIvdy9Yi4biaBnecSJle6rdrgSlb5Nbfz/2bj16m3IifCpkj6KL1GuT6z X-Received: by 2002:a17:907:2bd7:b0:99b:c952:309b with SMTP id gv23-20020a1709072bd700b0099bc952309bmr6700670ejc.55.1691048288558; Thu, 03 Aug 2023 00:38:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691048288; cv=none; d=google.com; s=arc-20160816; b=PKUtDpGUhBB479AAoY3MhA3Sc27lKs+fBJ9l8SNQz35fOb3rj95Uci2YBNk0MSpYHr 7B7d0nH5M8TqYtLXxJi1PJBmMHYSfyGcGu8LCuTws2NmdL/1wm1gcX9iOhHc+KOZUbl5 ULfAKIRM8YvgJr3M59fHggNWsDIMyDqOKdVeSVgTomi/WWNWlbEOO9r1y6rA31r1z2X1 dOtWm8tzdsGldLINc76ET3MJmGQJMbq4eS/UuROaSDNyHLb2d3bpZeng4p6bU+4aN74U y5p6Mc8u9V+TV7b8trD0Omw6opqMJHg9nYaM5KXoC3XABsYL9eNIXytW56TXfZxLIE0V eqag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eOZfZyIZsMyMYYVza+Zx5fKk9qKU4yokIJpzlAAmQRc=; fh=nUZnQ3Yh5uLF4R44GmfoJYsoNXtDM6huxhVFHb/jTrQ=; b=WEyPAqI8THxyRQaeJZeH1pce35j/D+mpRNof6M+LrCF3VAYytNizJ5o3JDnfNrIbtc wPCwsNXtjahT/IhwzXNShDh+ytSfb0zUcR6MG5M0wxXcC+sYMoll3yCcg0d0zUPybIbh dZIA7GYvuXWgqvpZHpDl4qaVKLd9nEFasFkTe8Qcle0Q+4seiKkBEGLUNBfHgC1CniRE Hi9Do/fT3C1eYWl8JVwChM+KJkk7s4zqOo73x52Pj6foa3KiwYvjRL93AB4yfJR8kGrB nSjabGkWRsiK7vnKKtlRCmvSiOzhW+mhzIpKqKSb+EJGVAwDg833T/Jp+S9PFjQcXt83 DoaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="UM4vpu/5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf15-20020a170906b2cf00b009930d603e75si10052987ejb.905.2023.08.03.00.37.44; Thu, 03 Aug 2023 00:38:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="UM4vpu/5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbjHCGvM (ORCPT + 99 others); Thu, 3 Aug 2023 02:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjHCGvL (ORCPT ); Thu, 3 Aug 2023 02:51:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A52A92D64; Wed, 2 Aug 2023 23:51:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3EE5B61BF4; Thu, 3 Aug 2023 06:51:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BBB7C433C8; Thu, 3 Aug 2023 06:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691045469; bh=43k3EvbDnD0qrF1ZOik+dSjCAEk8l1OcVzga1U7RXGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UM4vpu/5tZk9q+Tqz9Abjqp/f132V1HhBguBhQIQWcQMje3n7qo6FKncCubHURu2m gTtDgRPXw5fQf68bShyxy+PIwVvfithi78umYXwaCyUkz3UD4WPMxMTZ9KnuvoJPhT EMYkx8XAudYc7mWsSyYMNBBB/R+sK8gT/UOK7P1c= Date: Thu, 3 Aug 2023 08:51:06 +0200 From: Greg KH To: Jiri Slaby Cc: Jakub Kicinski , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Max Staudt , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Paolo Abeni , Krzysztof Kozlowski , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data Message-ID: <2023080359-senate-expose-46b2@gregkh> References: <20230801062237.2687-1-jirislaby@kernel.org> <20230801062237.2687-3-jirislaby@kernel.org> <20230802120755.10849c9a@kernel.org> <6808de4a-6002-e8bc-5921-06b5938dc69e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6808de4a-6002-e8bc-5921-06b5938dc69e@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2023 at 07:08:07AM +0200, Jiri Slaby wrote: > On 02. 08. 23, 21:07, Jakub Kicinski wrote: > > On Tue, 1 Aug 2023 08:22:37 +0200 Jiri Slaby (SUSE) wrote: > > > tty->disc_data is 'void *', so there is no need to cast from that. > > > Therefore remove the casts and assign the pointer directly. > > > > Which tree are these expected to flow thru? > > The intention was through the tty tree. But I don't mind either way -- it's > up to you Greg. I'll take them, thanks! greg k-h