Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <227357c7-a1c2-a0f9-c57d-536c461f9392@linux.ibm.com>
Date:   Thu, 3 Aug 2023 09:48:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 0/6] KVM: s390: interrupt: Fix stepping into interrupt
 handlers
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Ilya Leoshkevich <iii@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        David Hildenbrand <david@redhat.com>,
        Sven Schnelle <svens@linux.ibm.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jens Freimann <jfreimann@redhat.com>
References: <20230725143857.228626-1-iii@linux.ibm.com>
 <ZMrXoQ0wN5ZyCf6Q@google.com>
From:   Christian Borntraeger <borntraeger@linux.ibm.com>
In-Reply-To: <ZMrXoQ0wN5ZyCf6Q@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk


Am 03.08.23 um 00:24 schrieb Sean Christopherson:
> On Tue, Jul 25, 2023, Ilya Leoshkevich wrote:
>> Ilya Leoshkevich (6):
>>    KVM: s390: interrupt: Fix single-stepping into interrupt handlers
>>    KVM: s390: interrupt: Fix single-stepping into program interrupt
>>      handlers
>>    KVM: s390: interrupt: Fix single-stepping kernel-emulated instructions
>>    KVM: s390: interrupt: Fix single-stepping userspace-emulated
>>      instructions
>>    KVM: s390: interrupt: Fix single-stepping keyless mode exits
>>    KVM: s390: selftests: Add selftest for single-stepping
> 
> FYI, the selftests change silently conflicts with a global s/ASSERT_EQ/TEST_ASSERT_EQ
> rename[1], but the conflicts are very straightforward to resolve (just prepend TEST_).
> If we want to proactively avoid mild pain in linux-next, one option would be to merge
> the full kvm-x86/selftests branch/tag once I've made that immutable[2] (will be done
> Friday if there are no fireworks).  Though we can probably just get away with doing
> nothing other than letting Paolo know there's a silent conflict.
> 
> [1] https://lore.kernel.org/all/169101245511.1754469.7852701829984104093.b4-ty@google.com
> [2] https://lore.kernel.org/all/169101267140.1755771.17089576255751273053.b4-ty@google.com

Thanks for telling. Paolo, do you have a preference?

Janosch, Claudio I think this series is good to go otherwise.