Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1909713rwo; Thu, 3 Aug 2023 01:28:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlGX2Dxaq9L68FkJfYF1EYDJIeqkjCmD2F63IKm9z7TsNuNBu9ZpZudGPXpsE+YpOpotktJE X-Received: by 2002:a05:620a:424d:b0:767:1b8e:811e with SMTP id w13-20020a05620a424d00b007671b8e811emr18441268qko.17.1691051284842; Thu, 03 Aug 2023 01:28:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691051284; cv=none; d=google.com; s=arc-20160816; b=gD2lUq9G2vr1ixYoA2mqCYGOtah+N1hSKhz+1vkMh5TQlwHq3L2Of/xaiQK4LxWg4X mZl+Ow8c8zVbN82U18i1fRFuLx7v51+NW2Ck2PuKGBRKbI6LxAX7BoicW6OHcgGwZpNx eCXJh4E4W1rszb8YYfEVl8gSCr+iuUF1627TbU1oRC22kBq7hLoakaqwEEp/ALvvKZfU /GY7OTcPQAqQQyQrAboIK/cAnIY711AANAWUqOpojXpwq2ykt4/goBMzscKEQBT3bUVx VSexeolbSS/Z83F0/SupeoQYeebL14/YwBxJ+4imliUVslZKhMwVQQk/LvSlzhR5Rp2K RXOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2YRUMenBfm1DNO3xCzrCF81+S+dhhcp57Sa5QB+3dl8=; fh=3gsU7EmUxjQ0xMpnkA5ESvs/kJ/pS9mUWhNWrzmlTIY=; b=AU/D1Hnor32uqMAzSixiMtl4ynFqbzajj/SxFoT0BdFN5uEvgPXU/5lM3bEZifn9Pm IknA05xJtf5+32TCgz4cXu/DxAbbr7m8ZnJlYL+YCg5p0IxwOU7SH2NkxhOQdcGf+5aX N8/DLjWuPWeC4+3HQsbfwK0l84qrpz5dsukFEgcjy11A7zqVDD4guxms43TywugJL3pA c2ZV2HvLXF11gRn4D8gHphKrxFe4nnCDXl9brYWudJPH5XiZfF9R0JV4RdHctzaBQ9dI B7MLTooZh/vJtQUgqpjillbbWFVBT4Qb9eoP0Yrqw9+mMaR/52GURTwMgYTtW2pmH+XQ wXCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="QYVyq/lN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m8-20020a17090a4d8800b0025979e8c246si2553682pjh.70.2023.08.03.01.27.51; Thu, 03 Aug 2023 01:28:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="QYVyq/lN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232496AbjHCGnR (ORCPT + 99 others); Thu, 3 Aug 2023 02:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231277AbjHCGnP (ORCPT ); Thu, 3 Aug 2023 02:43:15 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39F69E4C; Wed, 2 Aug 2023 23:43:14 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3736h4pf086188; Thu, 3 Aug 2023 01:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691044984; bh=2YRUMenBfm1DNO3xCzrCF81+S+dhhcp57Sa5QB+3dl8=; h=From:To:CC:Subject:Date; b=QYVyq/lNKKZ+DUeG364M+nI4eVWbteHVmbtrFAtkAotkKqgfMQ/66yYM4gLS7vwmo jc/7GxZfi/zr/W4xl6TmbF4mkqeiMq8/GlESmkJ34+z8z2S5UcvRocySCEr7EidJZ4 WJro7iIMCDPqq2/GkDoX/xYl0ODHuZB1iND64SfI= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3736h3BQ024804 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Aug 2023 01:43:04 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 3 Aug 2023 01:43:03 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 3 Aug 2023 01:43:03 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3736h23o053609; Thu, 3 Aug 2023 01:43:03 -0500 From: Dhruva Gole To: Nishanth Menon , Tero Kristo , Santosh Shilimkar CC: , , , Viresh Kumar , Praneeth Bajjuri , Tony Lindgren , Dhruva Gole , Vibhore , Kevin Hilman , Vignesh R Subject: [PATCH V6 0/4] firmware: ti_sci: Introduce system suspend support Date: Thu, 3 Aug 2023 12:12:43 +0530 Message-ID: <20230803064247.503036-1-d-gole@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Abstract ******** This series introduces necessary ti_sci driver functionality to support DeepSleep mode (suspend to mem) on TI K3 AM62x. DeepSleep mode is described in section "6.2.4.4 DeepSleep" of the AM62x Technical Reference Manual [0]. Summary ******* This V6 series is a fixup and rebase of the patch series by Dave Gerlach [1]. It applies on top of next-20230731. The kernel triggers entry to DeepSleep mode through the mem suspend transition with the following: * At the bootloader stage, one is expected to package the TIFS stub which then gets pulled into the Tightly coupled memory of the Device Mgr R5 when it starts up. If using U-Boot, then it requires tispl.bin to contain the TIFS stub. Refer to ti-u-boot patch [3] for further details. The supported firmware version is from TI Processor SDK >= 09.00 ie. tag 09.00.00.006 from ti-linux-firmware [4]. * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes system to use PSCI system suspend as last step of mem sleep. * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP message in order to provide details about suspend, so we must add the ability to send this message. We also add TISCI_MSG_LPM_WAKE_REASON and TISCI_MSG_SET_IO_ISOLATION messages as part of a new PM ops. These messages are part of the TISCI PM Low Power Mode API [2]. (Patch 2) * A memory address must be provided to the firmware using the above message, which is allocated and managed by dma_alloc_attrs() and friends. This memory address can be used by the firmware to save necessary context at that physical location in the DDR RAM. (Patch 3) * While entering DeepSleep, it's also good to take precautions inorder to prevent any external current from directly entering the internal IPs and potentially damaging them. Hence, we send a ti_sci_cmd_set_io_isolation which essentially tells the DM R5 Firmware to isolate all the I/O's or pads from the IPs that they were connected to in active state. This is also something that is required when for example we want an I/O daisychain wakeup to wake the system from DeepSleep. More on this in the AM62x Processors TRM [0] under section "6.2.4.11 I/O Power Management and Daisy Chaining" (Patch 1) * Finally, the ti_sci driver must actually send TISCI_MSG_PREPARE_SLEEP message to firmware with the above information included, which it does during the driver suspend handler when PM_MEM_SUSPEND is the determined state being entered. (Patch 4) It currently enables only DeepSleep mode, but even if any additional modes are needed to be supported in future, they would not require any changes to the TISCI LPM APIs [2]. The enabling of additional modes would be done via GenPD changes that is currently in the works. Testing: ******* In can be tested with the following branch: https://github.com/DhruvaG2000/v-linux/commits/lpm-upstream-6.5 Tested on SK-AM62B [6] here: https://gist.github.com/DhruvaG2000/8410fac048c677c40cd94f5169b5b0b4 Limitations: ************ Currently, DeepSleep is only supported on SK-AM62B with DDR4. Boards with LPDDR part like Beagle Play and AM62x LP have a known FW issue. Base commit: ************ commit ec8939156379 (tag: next-20230731) ("Add linux-next specific files for 20230731") origin: linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Changelog: ********** v6: - Loading of FS Stub from linux no longer needed, hence drop that patch, - Drop 1/6 and 5/6 from the previous series [4]. - Add system suspend resume callbacks which were removed in commit 9225bcdedf16297a346082e7d23b0e8434aa98ed ("firmware: ti_sci: Use system_state to determine polling") - Use IO isolation while putting the system in suspend to RAM v5: - link [5] - Add support (patch 3) for detecting the low power modes (LPM) of the FW/SoC with a recently introduced core TISCI_MSG_QUERY_FW_CAPS message. - Use TISCI_MSG_QUERY_FW_CAPS instead of misusing the TISCI_MSG_PREPARE_SLEEP to detect the FW/SoC low power caps (patch 4). - Take into account the supported LPMs in ti_sci_prepare_system_suspend() and handle the case when CONFIG_SUSPEND is not enabled (patch 6) that was reported by Roger Quadros and LKP. - Pick up Rob Herring's "Reviewed-by" tag for the binding patch. v4: - Fix checkpacth warnings in patches 2 and 3. - Drop the links with anchors in patch 2. v3: - Fix the compile warnings on 32-bit platforms reported by the kernel test robot in patches (3,5). - Pick up Roger's "Tested-by" tags. v2: - Addressed comments received for v1 series [1]. - Updated v1 patch 5 to use pm notifier to avoid firmware loading issues. - Dropped the reserved region requirement and allocate DMA memory instead. The reserved region binding patch is also removed. - Introduce two more TISCI LPM messages that are supported in SysFW. - Fixes in error handling. References: *********** [0] https://www.ti.com/lit/pdf/spruiv7 [1] https://lore.kernel.org/lkml/20220421203659.27853-1-d-gerlach@ti.com [2] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html [3] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=91886b68025c7ad121e62d1fc1fa4601eeb736cd [4] https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware-next&id=905eb58564581d951d148f45828e8c8a142a5938 [5] https://lore.kernel.org/all/20221128140522.49474-1-g-vlaev@ti.com/ [6] https://www.ti.com/tool/SK-AM62B Cc: Vibhore Cc: Kevin Hilman Cc: Vignesh R Cc: Tony Lindgren Dave Gerlach (2): firmware: ti_sci: Introduce Power Management Ops firmware: ti_sci: Allocate memory for Low Power Modes Dhruva Gole (1): firmware: ti_sci: Introduce system suspend resume support Georgi Vlaev (1): firmware: ti_sci: Add support for querying the firmware caps drivers/firmware/ti_sci.c | 336 +++++++++++++++++++++++++ drivers/firmware/ti_sci.h | 90 ++++++- include/linux/soc/ti/ti_sci_protocol.h | 44 ++++ 3 files changed, 469 insertions(+), 1 deletion(-) -- 2.34.1