Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 06/12] iommu: Make dev->fault_param static
Thread-Topic: [PATCH v2 06/12] iommu: Make dev->fault_param static
Thread-Index: AQHZwE5fZVS62dLiF0SVYTshX5iUe6/YQHng
Date:   Thu, 3 Aug 2023 08:08:30 +0000
Message-ID: <BN9PR11MB5276BE0DB32E8E7ACD84828E8C08A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230727054837.147050-1-baolu.lu@linux.intel.com>
 <20230727054837.147050-7-baolu.lu@linux.intel.com>
In-Reply-To: <20230727054837.147050-7-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oORZQYIgasdAc+LE2ZRVy/avf4v4De2ki461kfJLTIqp2ABMZ2dIb8ZDqsav?=
 =?us-ascii?Q?kCTLzPX0esZeEdo/RuU3l9FY2Pvx4MWWo/XKpdZDP8fi8dXuxTDQ1YrSXXBs?=
 =?us-ascii?Q?9scCx97zFuE7YZU4ySpyWIBtswwdrwbj1yfq5RSFsRtASTsmyHr09V4WupQB?=
 =?us-ascii?Q?QhBooo1hfipqPNyCZQTOWvSXzHmAmlaJb8u1f3v6x7KzuvZGGJAtSakBlVif?=
 =?us-ascii?Q?BfPMZVSjDaLLR7+beqIpHZMf3v4brAS1U2jZ6O/O9qzrLc1jJcvtJzs3V30c?=
 =?us-ascii?Q?K7vJfPgEEGBe/N9u/ECQblqj81xi2YOSuxhIyIVBEO6qS1NfOvXWADZGoy5A?=
 =?us-ascii?Q?OeKg2OjnVlFoYO6fcjz2d0Svx2bfwRCtBdHBypHdR+xqKHIKO83yxhGgwgpV?=
 =?us-ascii?Q?+gb8cxd9hQlD0GuDPxRUUJDMJnOGL3cSZha8nOACnw2xTXI3yF8765WRH/O5?=
 =?us-ascii?Q?15i7gmPXZVGqepvXDl8DVUGL9M7H6nnHVaBI1AuapWxqc0chj/ApqZKWricy?=
 =?us-ascii?Q?2s5PebYyvhoA6kTrSZIKd54RabqGYm97+qEwUvprJ/jdk6mvXxkXd9mzgRsv?=
 =?us-ascii?Q?7AFG5CwLmztd3ntSeNsnRusXnWkQayYf3r4/eAMT5uuSL/x2gqfe0s6+3o7H?=
 =?us-ascii?Q?e8ozgzNlhOWoKhuFHQoDSxka9XaE0PikaD5qM3bTqyjW3CsJmua/ehvXlhMg?=
 =?us-ascii?Q?D2n0FPSKz+Pa98aK4o7FaBjORos6O7QIoLSp95t10bayCj/6IArMsUHUjA9e?=
 =?us-ascii?Q?0xvk12sAi0CL3TGNWCQPc6wmCxcaesVGG7oN3DazyEVXQtC8jQFd0N1v46wp?=
 =?us-ascii?Q?drxR+RhxZBcn5y1Yj19HAOvyl/xAHVH08R2RAhgchdnHXVW9fKYviuubpAZh?=
 =?us-ascii?Q?ItmIbVlCPoJTxg8C6BEGQiEgsV1RvGYi3ULgJc9kdxd2zLyvnGfL51iiHJIv?=
 =?us-ascii?Q?zk082KW7LpV+EbCm1LVgiehXbWTQ2G2/DjPGauJiFmsKwU6/pU5WfR8dsZeK?=
 =?us-ascii?Q?LCYPYOXnJ5QjdtGeMn2tJ6K88LjYrCTsQVLLcAJ+FVU9z91UNG8VZFL9bA39?=
 =?us-ascii?Q?6LQ44DUfO+63QgEV0uRmoWnST8bLnLwMVuaEuL2MUZlyG1VY9ZFs1vsNPYwD?=
 =?us-ascii?Q?YoRGjPV8W4EcJ7GejWCFFk8g39eFB4Cr/vHlWU6Q/Ov9jfzdaVlbMnLtOPcD?=
 =?us-ascii?Q?+47HmiaaJY4DFUAPiVmFx/c9Mxure6EmcX6iN+hAL+4GQti7G0SDhkEtf2iy?=
 =?us-ascii?Q?+l78Zg39sVOkQ0aWXOfzplGggJJM0YCzGfg3bhcOL0xzDnwt6tYbmx3yz3Y0?=
 =?us-ascii?Q?gFUQLssXR4Z1Bqb64cttIsq0kq4DSCYYj2x8AqhT+tqYAlM5MmaZ1jD1D8Vx?=
 =?us-ascii?Q?qYU0kHWAV9pmBZY+cDeYXFIRMUKkPGmsZLc+HFZZFglT6yjv1AKQSYodZYv5?=
 =?us-ascii?Q?5KFnZYlxbLcINCcjiufKWpSayaR76iF0g+6mE6Q37Jr6UMxl6suPW7jSPZKY?=
 =?us-ascii?Q?T4sLlLQ+ZoxQWUBRPjzEoe+4raCIaH1tesBnJiUVyQH6v//s301np5ZnLN9l?=
 =?us-ascii?Q?ZGx03DDeanwp17XCRd12ldzy8XeRIbclRpRgV6m7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00ab3079-c1d2-4603-2954-08db93f8d33b
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 08:08:30.8004
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8wg3TRU0p/vPzQa4tWeUdih2/0C2DBcx4SPYVWl7hfn3IMeNEKU57tUTGcmA8gIdLAXeKdXaAnzLRNyDKoQvhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6346
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, July 27, 2023 1:49 PM
>
> @@ -4630,7 +4621,6 @@ static int intel_iommu_disable_iopf(struct device
> *dev)
>  	 * fault handler and removing device from iopf queue should never
>  	 * fail.
>  	 */
> -	WARN_ON(iommu_unregister_device_fault_handler(dev));
>  	WARN_ON(iopf_queue_remove_device(iommu->iopf_queue, dev));

the comment should be updated too.

>=20
>  	mutex_init(&param->lock);
> +	param->fault_param =3D kzalloc(sizeof(*param->fault_param),
> GFP_KERNEL);
> +	if (!param->fault_param) {
> +		kfree(param);
> +		return -ENOMEM;
> +	}
> +	mutex_init(&param->fault_param->lock);
> +	INIT_LIST_HEAD(&param->fault_param->faults);

let's also move 'partial' from struct iopf_device_param into struct
iommu_fault_param. That logic is not specific to sva.

meanwhile probably iopf_device_param can be renamed to
iopf_sva_param since all the remaining fields are only used by
the sva handler.

current naming (iommu_fault_param vs. iopf_device_param) is a
bit confusing when reading related code.