Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 09:52:56 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Tony Lindgren <tony@atomide.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dhruva Gole <d-gole@ti.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v2 1/1] serial: core: Fix serial_base_match() after
 fixing controller port name
Message-ID: <20230803-molecule-shelter-aa71b219af26@wendy>
References: <20230803071034.25571-1-tony@atomide.com>
 <2023080351-chaplain-headgear-bcbb@gregkh>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="SqrNJ+wWy5BRsFok"
Content-Disposition: inline
In-Reply-To: <2023080351-chaplain-headgear-bcbb@gregkh>
Precedence: bulk

--SqrNJ+wWy5BRsFok
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 03, 2023 at 09:50:03AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 03, 2023 at 10:10:32AM +0300, Tony Lindgren wrote:
> > While fixing DEVNAME to be more usable, I broke serial_base_match() as =
the
> > ctrl and port prefix for device names seemed unnecessary.
> >=20
> > The prefixes are still needed by serial_base_match() to probe the serial
> > base controller port, and serial tx is now broken.
> >=20
> > Let's fix the issue by checking against dev->type and drv->name instead
> > of the prefixes that are no longer in the DEVNAME.
> >=20
> > Fixes: 1ef2c2df1199 ("serial: core: Fix serial core controller port nam=
e to show controller id")
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Closes: https://lore.kernel.org/oe-lkp/202308021529.35b3ad6c-oliver.san=
g@intel.com
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >=20
> > Changes since v1:
> > - Leave out magic numbers and use str_has_prefix() as suggested by Andy
> >   and Greg
> >=20
> > - Improve patch description and add a link for Closes tag as suggested
> >   by Jiri
> >=20
> > - Check the name against device_type name since we have it and leave
> >   out the changes to try to define names in the header because of the
> >   issues noted by Jiri
> >=20
> > - Leave out Tested-by from Mark and Anders as the patch changed
>=20
> Thanks for this, now queued up.

Seems like I am a bit late, but FWIW this does fix my boot failures in
-next:
Tested-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--SqrNJ+wWy5BRsFok
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMtq3QAKCRB4tDGHoIJi
0hzrAPwNe3Aci1oYSam7q2JubnqG7pAXfKkMra6oE8XJJWnaAgEA+tcvAHd/Uxl6
hWtkS4rt9R1xmhsUfEj/FVcMrh8ZCAc=
=VAFL
-----END PGP SIGNATURE-----

--SqrNJ+wWy5BRsFok--