Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 10:43:26 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Nylon Chen <nylon.chen@sifive.com>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>, <geert+renesas@glider.be>,
        <pavel@ucw.cz>, <vincent.chen@sifive.com>,
        <emil.renner.berthing@canonical.com>, <aou@eecs.berkeley.edu>,
        <palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
        <conor@kernel.org>, <zong.li@sifive.com>
Subject: Re: [PATCH v4 0/1] Change PWM-controlled LED pin active mode and
 algorithm
Message-ID: <20230803-caretaker-voicing-e982f2334067@wendy>
References: <20230803085734.340-1-nylon.chen@sifive.com>
 <20230803-vehicular-leggings-2830239f818a@wendy>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="tzX8viRnXMQ13hWc"
Content-Disposition: inline
In-Reply-To: <20230803-vehicular-leggings-2830239f818a@wendy>
Precedence: bulk

--tzX8viRnXMQ13hWc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Nylon,

(I yoinked the reply to 1/1 to here, as it makes more sense in this
context)

> On Thu, Aug 03, 2023 at 10:15:10AM +0100, Conor Dooley wrote:
> > On Thu, Aug 03, 2023 at 04:57:33PM +0800, Nylon Chen wrote:
> > > According to the circuit diagram of User LEDs - RGB described in them=
anual hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1].
> > >=20
> > > The behavior of PWM is acitve-high.
> > >=20
> > > Removed patches: 1
> > > New patches: (none)
> > >=20
> > > Links:
> > > - [0]:  https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-=
7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf
> > > - [1]:  https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-=
e68ce76f4192_hifive-unmatched-schematics-v3.pdf
> > > - [2]:  https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-=
86ed8b16acba_fu740-c000-manual-v1p6.pdf
> > >=20
> > > Changed in v4:
> > >  - Remove previous updates to the PWM algorithm.
> >=20
> > Why? I don't recall the conclusion on the previous version being that
> > that patch was not needed.
>
> I apologize for forgetting about this update earlier. Just now,
> I tried to pull rebase master and noticed that other developers seem
> to have made some fixes to the algorithm. Upon closer inspection, I
> found that they addressed the part we previously discussed with Emil
> and Uwe, such as "first pwm_apply_state."
>=20
> Therefore, my instinct tells me that they have already taken care of
> the issues we discussed before.

I didn't see anything in linux-next that would solve this problem of
inversion. The last meaningful change is:
	commit 334c7b13d38321e47d1a51dba0bef9f4c403ec75
	Author:     Emil Renner Berthing <emil.renner.berthing@canonical.com>
	AuthorDate: Wed Nov 9 12:37:24 2022 +0100
	Commit:     Thierry Reding <thierry.reding@gmail.com>
	CommitDate: Mon Jan 30 16:42:45 2023 +0100
=09
	    pwm: sifive: Always let the first pwm_apply_state succeed

which predates your v3 by quite a bit.

> I will review the conflicting parts in the pwm-sifive.c code in my v4
> version once again to ensure there are no omissions. If I find any, I
> will submit v5 accordingly.

And if this patch is okay in isolation, please reply here explaining
which commit fixed the algorithm, so that I can pick it up.

Thanks,
Conor.

--tzX8viRnXMQ13hWc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMt2vgAKCRB4tDGHoIJi
0o+tAP9T2YoYk//o5k7MVQwS/3aSXKAO4fwzn4VO7kYKb3jOPgD+KA7Bv5tRvwou
PaimuCQYfr42wST7wH8mSiR9MZA7zQ4=
=Sx/n
-----END PGP SIGNATURE-----

--tzX8viRnXMQ13hWc--