Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230803075135.499536-1-yangyingliang@huawei.com>
In-Reply-To: <20230803075135.499536-1-yangyingliang@huawei.com>
From:   Lai Jiangshan <jiangshanlai@gmail.com>
Date:   Thu, 3 Aug 2023 17:50:42 +0800
Message-ID: <CAJhGHyDMoX6MfPiEBgJ_6CCCetCfFsas=TEQU8PfNuUjE9TH0w@mail.gmail.com>
Subject: Re: [PATCH -next] workqueue: use LIST_HEAD to initialize cull_list
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, tj@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 3, 2023 at 3:54=E2=80=AFPM Yang Yingliang <yangyingliang@huawei=
.com> wrote:
>
> Use LIST_HEAD() to initialize cull_list instead of open-coding it.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

> ---
>  kernel/workqueue.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 3ddd0d599dab..ae975a7c9f69 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2307,9 +2307,8 @@ static void idle_worker_timeout(struct timer_list *=
t)
>  static void idle_cull_fn(struct work_struct *work)
>  {
>         struct worker_pool *pool =3D container_of(work, struct worker_poo=
l, idle_cull_work);
> -       struct list_head cull_list;
> +       LIST_HEAD(cull_list);
>
> -       INIT_LIST_HEAD(&cull_list);
>         /*
>          * Grabbing wq_pool_attach_mutex here ensures an already-running =
worker
>          * cannot proceed beyong worker_detach_from_pool() in its self-de=
struct
> @@ -3875,10 +3874,8 @@ static void rcu_free_pool(struct rcu_head *rcu)
>  static void put_unbound_pool(struct worker_pool *pool)
>  {
>         DECLARE_COMPLETION_ONSTACK(detach_completion);
> -       struct list_head cull_list;
>         struct worker *worker;
> -
> -       INIT_LIST_HEAD(&cull_list);
> +       LIST_HEAD(cull_list);
>
>         lockdep_assert_held(&wq_pool_mutex);
>
> --
> 2.25.1
>