Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ff53a6d-4730-1fa5-740d-93dee35c80ea@gmx.de>
Date:   Thu, 3 Aug 2023 10:04:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1] parisc: pci-dma: remove unused and dead EISA code and
 comment
Content-Language: en-US
To:     Petr Tesarik <petrtesarik@huaweicloud.com>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     Roberto Sassu <roberto.sassu@huaweicloud.com>, petr@tesarici.cz
References: <20230802163321.1560-1-petrtesarik@huaweicloud.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230802163321.1560-1-petrtesarik@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:qf9lH98l+2c=;V/5kk4YjlbDHox1FyoRLl7ka4fI
 znxjlYC1DjkQm2ZioiBNMm8v1JNEfHk8IBLFK0Fp/fRnrO78LD3ffmsEKP576742/ZJjEC0VT
 zriAZlAF1yfy6YBhrk4X2yQbkjRWaCYiWqZsNULAV7cDZoF/o8n087G3h4FlghrtDYG7xKypu
 JsPmWN5zS5OgNXnSyrLGPjStnGLTjxHW39MM92+CqNmtYvlrLSM9oc9LbrC9L0+gTD/Ty8alZ
 MlwYMxFb8FPXd7PQch9JQqBI+A3Bm0fYQ6B5YFWxWsZhLJ16HqoDyG0NlZzj/V9+H7WUNf7hW
 8p575c6Zh4DnNB80JHR2SFYaSr7C6GGhc87jZoxAiI75d5iBwktEsmEfzDB43SU09zBASjyBv
 46rSQO16lijJZwiGOFsIEcdOY2nndyoM4JYMTVv7ZeNIblfP3RS55KiLdsYiDmUPUX1KgClMb
 Etr52i8wE28AbS5/9Vf3HNqP29aJ3RWYXbCVH9IrUD6mADYRuzmfgpvApbIYRcOz+k/u+qHyI
 A9efiXqA7Znu6d5EHUiSz60XmdaLKuT6OenYTX1HrspS+RtWzgiGh7EV3txAPfzLrMz0P0dk3
 qSRURAq9ZOs4emKVHE3MA0VtN2VT9Cukics6HMbZY+cwQJRQo+NAO5UP32OTsmsjsEl3gXoK/
 qlP48C9o6/VqnNjgHEWiqKozAosaV/V6RSqYQJspIKAAbLPKw+2Mm+Iqze2wT8llZZ0Zb+zH2
 k6hLZWdzMfZz+p1zCgg6hDkL/2x32axk298rSYXbhaa/seiR7oeDo32cebazG0YHuzqg6/N2G
 b5UbjjrIa6vhQ/hdzi2/9HJJyqQx/T98urMFKsiKRhSObNn0QlnM5Uh+KGpeIjqI7dbBdLMKL
 vAs1Lwhw0YLH2lvxn0aEYgx3upRnEeCz3Ksnc1JG+r55h4wA4nT1hTPEazleCkSxf2MhVPMMo
 D93Vk20ZbSz3gnnSQ2HaGopG1m8=
Precedence: bulk

On 8/2/23 18:33, Petr Tesarik wrote:
> From: Petr Tesarik <petr.tesarik.ext@huawei.com>
>
> Clearly, this code isn't needed, but it gives a false positive when
> grepping the complete source tree for coherent_dma_mask.
>
> Signed-off-by: Petr Tesarik <petr.tesarik.ext@huawei.com>

queued up in parisc git tree.

Thanks!
Helge

> ---
>   arch/parisc/kernel/pci-dma.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index d818ece23b4a..3f6b507970eb 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -417,14 +417,6 @@ void *arch_dma_alloc(struct device *dev, size_t siz=
e,
>   	map_uncached_pages(vaddr, size, paddr);
>   	*dma_handle =3D (dma_addr_t) paddr;
>
> -#if 0
> -/* This probably isn't needed to support EISA cards.
> -** ISA cards will certainly only support 24-bit DMA addressing.
> -** Not clear if we can, want, or need to support ISA.
> -*/
> -	if (!dev || *dev->coherent_dma_mask < 0xffffffff)
> -		gfp |=3D GFP_DMA;
> -#endif
>   	return (void *)vaddr;
>   }
>