Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ce18601-02d8-686e-ebe0-04c5dc29f6c9@tuxon.dev>
Date:   Thu, 3 Aug 2023 12:09:57 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree
 for sama5d29_curiosity board
Content-Language: en-US
To:     Mihai.Sain@microchip.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
        andre.przywara@arm.com, Andrei.Simion@microchip.com,
        Jerry.Ray@microchip.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Cristian.Birsan@microchip.com
References: <20230801111151.6546-1-mihai.sain@microchip.com>
 <20230801111151.6546-2-mihai.sain@microchip.com>
 <14d628cf-a40c-11e6-7743-e3ba3bd8aa2d@tuxon.dev>
 <PH8PR11MB68049899CFD7947B0B3A03EF820BA@PH8PR11MB6804.namprd11.prod.outlook.com>
From:   claudiu beznea <claudiu.beznea@tuxon.dev>
In-Reply-To: <PH8PR11MB68049899CFD7947B0B3A03EF820BA@PH8PR11MB6804.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi, Mihai,

On 02.08.2023 15:19, Mihai.Sain@microchip.com wrote:
>> +&macb0 {
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
>> +     #address-cells = <1>;
>> +     #size-cells = <0>;
>> +     phy-mode = "rmii";
>> +     status = "disabled";
> Should any phy/mdio container be placed here? Also, any reason this node is disabled?
> The board has no phy.
> We will add external phy boards to macb interface and they will be present in dt-overlay.
> 

Then remove the macb0 node from here and keep it in overlay.

Thank you,
Claudiu Beznea