Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2097332rwo; Thu, 3 Aug 2023 04:49:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlGG69kgYXDi3ehk6leL0njcRfefavGlgannllguQqmdnzYdVe5kcuL3VD58Jy5roGxUpmdH X-Received: by 2002:a17:902:d301:b0:1b0:6e16:b92c with SMTP id b1-20020a170902d30100b001b06e16b92cmr16729784plc.54.1691063356386; Thu, 03 Aug 2023 04:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691063356; cv=none; d=google.com; s=arc-20160816; b=Z252I7GJKjUb42324Ajcy8ahbD9Ucs0OI/Q2wZf5HE/hnLXdmPldjmCPvNee9KTSkS n/wOy7v/zyyexd6zVscIDDFSyf3xSMpWC3S6gFNRcuvNm0djvCB0BG4giRZdAzdIbJeh CmAAARWuJtzUhSSaYgI4/qQHB9Uvs9B/KrJwuVjjuy5GGqCeR6G/TeoGYyDY5ip/u9ME xyhy0sXFSnSPRs54+WP58q4BIXx3b4MjEDd7cupuIuY9xKr78PliIOg7QkolmXIK78La Mtf9DF816tmcdJWy1WOnMWZ1hho1f9EbE7bD4862awB29vWZ6W17VkB9l3m3P45X+CyI eI2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Xc/AH5l4Iyyp7OtLp1W+ayvZ64gdQJXoJlypwl+ahyA=; fh=NWEzFAZVRz25+ue9dsydvAiW929cQ8aKCXsE+drPkco=; b=x3UtIIPDCoD75JVplJ2cJP/mdey7EZbdVjVUcnA5tjr0o0rw2DHALobooUYkcSMqUc 7kSXNxt6IRQgp/GnosYhGDrRFZNNoWYjzbmuFoOsT2uxDeIlSZU2X0sNHJM5m2/5WO+7 8KD3rfV1RMapJ/i8t9kHIxwNr1UX39RCvZmF+gOpGa08vWqOScKXUMHhO9vGbaLOf8z5 FcmRoQSDK/CurUwP1NC/s9puEpGUxBBa9lnukTsiJl4cgC9iajzi/pj+o438iI2dHO5j jnmpY0CsErkYhF0dub1YyIIgLQdor8uQ5C8N7pba+fBC4Tzfi634bURT5wkr9tXhXhMr iORA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umich.edu header.s=relay-2018-08-29 header.b=DeWNFKCo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a170902e85200b001b9ea592e75si3394007plg.265.2023.08.03.04.49.03; Thu, 03 Aug 2023 04:49:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@umich.edu header.s=relay-2018-08-29 header.b=DeWNFKCo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbjHCJgY (ORCPT + 99 others); Thu, 3 Aug 2023 05:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235122AbjHCJfw (ORCPT ); Thu, 3 Aug 2023 05:35:52 -0400 Received: from keen-gwydion.relay-egress.a.mail.umich.edu (relay-egress-host.us-east-2.a.mail.umich.edu [18.217.159.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EB2F422D; Thu, 3 Aug 2023 02:35:34 -0700 (PDT) Received: from malleable-ellyllon.authn-relay.a.mail.umich.edu (ip-10-0-72-197.us-east-2.compute.internal [10.0.72.197]) by keen-gwydion.relay-egress.a.mail.umich.edu with ESMTPS id 64CB74E5.130B4C7C.1A239A93.70545; Thu, 03 Aug 2023 05:35:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=relay-2018-08-29; t=1691055327; bh=Xc/AH5l4Iyyp7OtLp1W+ayvZ64gdQJXoJlypwl+ahyA=; h=From:To:Cc:Subject:Date; b=DeWNFKCo8ElkOM9/673Zdqcd1BdgDA3AL++FK0+eUh/m2OHm7jnaiHet1/zV2lSmy xGc1Ttaoz7RYr0OM3etjwtW3D2tKmoVLUdhBcDGZyR3GQbpE813ZjX260sysIeZ95h rB/XUybT4aGPfDstPiT8SRJBB41oNZvwhh6PVV5y2LmNGuBzI8KG4BAQYo7GrW+he/ lMGb/gMhA0DNXhYwnaY4bW5xnRCSHc/cq6KobDha+R8MxGYIvS40BIl+TEIpp+6EkU EIYp/OL/KB6iArLHGGAo6JIYQIwZr9lBcjAQBZ12wmlFYyNpAjpEjr8yqqnsig4XAD zmpRQah2Or7Zg== Authentication-Results: malleable-ellyllon.authn-relay.a.mail.umich.edu; iprev=permerror policy.iprev=68.32.216.219 (unknown); auth=pass smtp.auth=tmgross Received: from localhost.localdomain (unknown [68.32.216.219]) by malleable-ellyllon.authn-relay.a.mail.umich.edu with ESMTPSA id 64CB74DF.146D9BAD.63148A9A.1340056; Thu, 03 Aug 2023 05:35:27 -0400 From: Trevor Gross To: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho Cc: Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Trevor Gross Subject: [RFC PATCH 0/2] Generate API documentation for 'bindings' crate Date: Thu, 3 Aug 2023 05:34:16 -0400 Message-Id: <20230803093418.51872-1-tmgross@umich.edu> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 'bindings' crate currently doesn't have API documentation available. With this change, it will be generated as part of the output of 'make rustdoc' (similar to the 'kernel' crate's docs, https://rust-for-linux.github.io/docs/kernel/). This patch is a RFC because there are a few questions: 1. Do we want to make this the default, or a separate target/ configuration? I don't think there is much downside to always generating. 2. The entire '.config' file could be included in the doc output, to make it easy to tell what settings the documentation was generated with. Would this be desired? Maybe with a '--cfg include-dotcfg=".config"' flag so published docs would have the option (unsure whether it may ever have sensitive information). Bindgen is currently invoked with '--no-doc-comments', I think this may be because some blocks were mistakenly interpreted as doctests. Once we upgrade our bindgen version we might be able to remove this. Side note, 'rust/Makefile' seems to have a mix of tabs and spaces - is this intentional? Trevor Gross (2): rust: bindings: generate API documentation for the 'bindings' crate rust: bindings: add warning about configuration dependence rust/Makefile | 14 +++++++++++--- rust/bindings/lib.rs | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) -- 2.34.1