Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ac4ec1d-f01e-6ddd-708d-6dec7ca4ea3d@quicinc.com>
Date:   Thu, 3 Aug 2023 16:41:44 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2
 boards based on IPQ9574 family
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230720084534.6461-1-quic_sridsn@quicinc.com>
 <20230720084534.6461-2-quic_sridsn@quicinc.com>
 <87c3a3db-d172-bc98-cf83-89b874c9fee7@linaro.org>
 <9e401641-1334-c0bc-c49a-481a8a9af2de@linaro.org>
 <c1903d09-f307-8e80-0482-2040c7af7a2c@quicinc.com>
 <b57e0199-141f-2a37-4d5a-b98da5276b89@linaro.org>
Content-Language: en-US
From:   Sridharan S N <quic_sridsn@quicinc.com>
In-Reply-To: <b57e0199-141f-2a37-4d5a-b98da5276b89@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/26/2023 12:51 PM, Krzysztof Kozlowski wrote:
> On 26/07/2023 07:03, Sridharan S N wrote:
>> On 7/20/2023 3:18 PM, Konrad Dybcio wrote:
>>> On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
>>>> On 20/07/2023 10:45, Sridharan S N wrote:
>>>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>>>>> family of SoCs.
>>>>>
>>>>> AL02-C3  - rdp437
>>>>> AL02-C7  - rdp433-mht-phy
>>>>> AL02-C10 - rdp433-mht-switch
>>>>> AL02-C11 - rdp467
>>>>> AL02-C12 - rdp455
>>>>> AL02-C13 - rdp459
>>>>> AL02-C15 - rdp457
>>>>> AL02-C16 - rdp456
>>>>> AL02-C17 - rdp469
>>>>> AL02-C19 - rdp461
>>>>> AL03-C2  - rdp458
>>>>>
>>>>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>>>>> ---
>>>>>    .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
>>>>>    1 file changed, 20 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> index dd66fd872c31..d992261da691 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> @@ -89,10 +89,20 @@ description: |
>>>>>            adp
>>>>>            ap-al01-c1
>>>>>            ap-al02-c2
>>>>> +        ap-al02-c3
>>>>>            ap-al02-c6
>>>>>            ap-al02-c7
>>>>>            ap-al02-c8
>>>>>            ap-al02-c9
>>>>> +        ap-al02-c10
>>>>> +        ap-al02-c11
>>>>> +        ap-al02-c12
>>>>> +        ap-al02-c13
>>>>> +        ap-al02-c15
>>>>> +        ap-al02-c16
>>>>> +        ap-al02-c17
>>>>> +        ap-al02-c19
>>>> Why? I asked once, but there was no feedback from Qualcomm.
>>>>
>>>> Why do we need to do this? What's the point?
>>> Another question would be, whether these boards are just one-off test
>>> prototypes of which there exist like 5-10 units, or are they actually
>>> going to be supported and useful.
>>>
>>> If it's the former, I don't think it makes sense to keep the device
>>> trees upstream.
>>>
>>> Konrad
>> These are all not test rdps and each rdps has its own configurations.
>> IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use
>> all of the interfaces and it will vary for each rdp. In next version ,
>> will post with each rdp's configuration explicitly
>
> So still no answer why do we need to list it as possible boards.
> Especially that it messes with compatible style, because c[1-9] looks
> like board version.
>
> I suggest don't add these board types and drop existing ones.
>
>
> Best regards,
> Krzysztof

Apologize for the late reply. IPQ bootloader doesn't need these info. we 
will send the patch to drop the existing ones

Thanks,

Sridharan