Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   liming.wu@jaguarmicro.com
To:     peterz@infradead.org
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        juri.lelli@redhat.com, Liming Wu <liming.wu@jaguarmicro.com>
Subject: [PATCH] sched: remove redundant check in __schedule_bug
Date:   Thu,  3 Aug 2023 19:26:28 +0800
Message-Id: <20230803112629.1139-1-liming.wu@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FOpiW+0qUCeKYBOEikeuO4x+xZ4utlvJ0YXEh4G5JNYNRF6SjMJb5ew3HYvu?=
 =?us-ascii?Q?u8o4aWS0SmqQrLqj6+DHX06NlNKRsH/3j9bHVtR8CG7X4lojofCR9beKhf+e?=
 =?us-ascii?Q?BSCnvyu9rxGSip/TJGbCVLJafK/CwVeN1bRUbEP+pVwkjM45KvRnDE9Csuwr?=
 =?us-ascii?Q?GUyFgMwpq5v5vOAjuzMaT8B7IW53hSqNrhts0Cg71HMYgFujojXRE1lFeYgY?=
 =?us-ascii?Q?jzwvqsyqzocqTnTx1HO690DHU07Jz71nqPz9j3RPyAn9e1aFs+rpubJeZbi5?=
 =?us-ascii?Q?tsv8pxEe9noaY+amh19MGBxVqSICdDP+UsWvw47vMi9rJgff73YiO4WoAdXC?=
 =?us-ascii?Q?tYxFbU8BsgF80rAA9lHSEmOCp6o4L7zeQipfk2xF0nye3XtK9hHIxiKvq7iU?=
 =?us-ascii?Q?WEsNbmYk8OVhCcWAfPLIHP4JNy+pcxEP9lv3qlPYV3kGckeeUWUDfIwVENw9?=
 =?us-ascii?Q?kmLdZkc9fJGBF7bNJ6uFpfmFnTg4urFD1825DjsoBRhOCDj8Pa/DANzEjJmT?=
 =?us-ascii?Q?gi9x2ERxRvs+cmucljocy/GjaKPCujjrER2QfuhyauwfjBLtZHg3Lchp8xKG?=
 =?us-ascii?Q?myBvr7ntgGk2Ow/hrjG0Q2h+FEAtBWVJyg9o6bPxSBD0JLOS81hnE52DXPFG?=
 =?us-ascii?Q?Y1xNtgjWjfmVhOelnuq0yJpaGs7PIbA8YiVQUJT6ONavGibzeIiVHJ05xENT?=
 =?us-ascii?Q?ZRauV/s1UBBxfbjCv6qjV/bYQl93PSN93GGwL4gShoMdSZq7KQbqSVn7gpMO?=
 =?us-ascii?Q?O3OW7GMpZioV0ijlyliktAn65CKxJgl+hfBkGWj2Vp0JtgfyKDY+koIHqhkU?=
 =?us-ascii?Q?11cJkpcr9TWIPDvhPhAZdmvU52yk/tOeBwPMaeoY2dE0YNtfOtHiCE7LXY/5?=
 =?us-ascii?Q?2SdCx3z/bbvLyQlb6hK0XB8nVNWqSxrl/SN1y57QJzUoVGnymneWiSt6Rcnz?=
 =?us-ascii?Q?caIGYxrPjcccaoc1Y3wEBbanAE/ttfzGkC1omGteu8k/Yu+5zeyr3ywtOGRc?=
 =?us-ascii?Q?NA0ZdQIv7CTgslbnH9B8cbpI5jhoI6Y/wNPFTl1C55YWQXIoLGYTJgY96ITm?=
 =?us-ascii?Q?CevYdRNu2ogQ7EziDTDK6JbBwfyJNWTxLf+T2LjTHIci+MZdJg3bPfRg7Io3?=
 =?us-ascii?Q?cjTUrSE+sEPFVnLBYU/5kXIUkAmpdiRKpCiNSyRxl2n7MVXbAnlGAi4LdMsX?=
 =?us-ascii?Q?mWhkHCi2LNatgksS0xB84eOZIaRj34EQIuMkDfZrUwSsBAIvCtBT1FHz9+Qg?=
 =?us-ascii?Q?jvDKFG2z+4uTUqyKFbbEF/vNsK8d/+1PlD9/sRluQf5xJkoHiEfpho4u1QV6?=
 =?us-ascii?Q?EUnGUff+Wpy5jYnd/x8EZrkiev/Ka4qzgjE3YUOgXGbmvVNbBKyd3qmdm7OL?=
 =?us-ascii?Q?fpavF6u+I8jLmkNnwT8RsZMEIYZhEP9lyXhiUtMx1cSOmagZOZ/spg6LAZgW?=
 =?us-ascii?Q?Xm7tah8J0q7CrmEeJUrT0GHDNua3EImloMqkeMysEbqXwTd57Ot359bc0jod?=
 =?us-ascii?Q?mMXiMe3Tu9A48AubCaNqAMDzImc7Sv91Rkx4XbV6QpaBeuHdBdmNWVQBoJAO?=
 =?us-ascii?Q?t96l18s2AvHPidAQ0Eddr1srBL/xFSgCse8OIKc/H8+Qb3TrdUIAkBX5T71w?=
 =?us-ascii?Q?ww=3D=3D?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2723f303-b042-4fe2-31f0-08db94149799
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB3942.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:27:16.9904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JdXfle994RdCtxpCNIOvZttf1r2CpLsuKqgrNpeVByFKpk+QJeDUsRrvG1g32rwfVGvCB/vnrq4DWDX5hyW5ZRvlO7scGtrtA9PM/37BKdc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6699
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Liming Wu <liming.wu@jaguarmicro.com>

in_atomic_preempt_off is checked twice in schedule_debug, and
__schedule_bug only called in schedule_debug. remove the redundant
in_atomic_preempt_off check in __schedule_bug.

Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
---
 kernel/sched/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a68d1276bab0..ae44958b3851
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5884,8 +5884,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
 	print_modules();
 	if (irqs_disabled())
 		print_irqtrace_events(prev);
-	if (IS_ENABLED(CONFIG_DEBUG_PREEMPT)
-	    && in_atomic_preempt_off()) {
+	if (IS_ENABLED(CONFIG_DEBUG_PREEMPT)) {
 		pr_err("Preemption disabled at:");
 		print_ip_sym(KERN_ERR, preempt_disable_ip);
 	}
-- 
2.25.1