Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d19d0e9a-a788-8b33-506d-8a080d566366@amd.com>
Date:   Thu, 3 Aug 2023 06:35:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/3] tpm: Add a missing check for
 TPM_CHIP_FLAG_HWRNG_DISABLED
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, peterhuewe@gmx.de
Cc:     linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
        Jason@zx2c4.com, dragonn@op.pl
References: <20230803015015.915-1-mario.limonciello@amd.com>
 <20230803015015.915-2-mario.limonciello@amd.com>
 <CUISBN0W36B2.1DXXNNGS6P7JC@suppilovahvero>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <CUISBN0W36B2.1DXXNNGS6P7JC@suppilovahvero>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTNpZ0dHWlU2U09pdURZMHdDTldTbnkzZjlqUVJ6bmF2NG5YbE1SRUc2TmJF?=
 =?utf-8?B?Qk1yS3RvK3J5MXlvZkY1TWNoYjdITlhjZW00YlNXcUVWRzNQMHRBTVYrNllD?=
 =?utf-8?B?bkhEa3IvUW0wMEp2aStiTkhhd0tUVjhUZDZkRkxDSHE2aWRDTGpYTzNicERy?=
 =?utf-8?B?QjFYNGE4RVdVNEJuTG02dWN0TnZGb1dObDhqaGUyVldPNVF6Mlp4L0thRnpo?=
 =?utf-8?B?elNFSXRaamJKR3BFbHBjaUQ3bTU2WUxGTFdVcTU1NUNIRHNhZEJHTDZYS0tQ?=
 =?utf-8?B?bTlxcWJYSm5DKzYzcW55V2NkaDJicmltcDI2U2RDQVcwS2RBRHcxRnJhTURF?=
 =?utf-8?B?VnFMVlo4a1VVR2dhTmxpa0hxY0ljL081K05GTk40Q0NoQ3pSdEdRbVozM0lr?=
 =?utf-8?B?VW9Xd01LYXg4OUR5d1dwLzJqbU9KRTNaNVVOR0NzcTM1RDlSNmZGalR0d1Jq?=
 =?utf-8?B?bDcrNVFFaUxWTGtlT01leUFtVEU4R00zSEgvZmpFeEFGemQ2OHZmcW1SVGJV?=
 =?utf-8?B?MEwyb25EWC93cEFncUFxejBTMWpJWEVhSnhZbUlmb0hjQmIzb3JzWnJtUnQw?=
 =?utf-8?B?alZPdFBFSDR0UmRiY1RQdHZ4SXpvSE1LL1lLQWk4akdFUVVzK1FDcGZBcEdI?=
 =?utf-8?B?VkUyOWJUQkc4Ni95RS91dEhZN1ZIMmYwTXhJRExQcm5yNkVzQTYzSWVhOHIy?=
 =?utf-8?B?a0dPV1ZZS3llSDBLNlE2U3BObTZqaUlQRm5xVGhtVSsvd1J4clN2ZU10aE5J?=
 =?utf-8?B?MnVSRFh4MnhyY2s3NEhxUW1lK3hUcXlQcTlBbklDN2tuYWtUQVhrNkpiZ050?=
 =?utf-8?B?MlVNTUhYcXJmVVFreHFiUzMzYmVmQTdRK3Z2QWMyNzVCbFJ5VDlyb0xVaUF3?=
 =?utf-8?B?NnpjWm9HRFkvcnA4ZGpIaVRPM2xlTFNDTHdlSmp0YmNabW9QT3NzL1NJdlBZ?=
 =?utf-8?B?QjVnNlhhQ1RQWWhwMVRCZyswdHNoVVM3Y2N4cjdCa3RkVHpEbGgra1hGaHBu?=
 =?utf-8?B?M0pUSG5iNThWT0xkOFBUcFBFaHQ5a1BTWXZSS1BzRVJ2eWJYRHlheG5vcFRS?=
 =?utf-8?B?QXRoeHlONHErSmZ5aWsvTklIWGpCK2srUmdzNDIxSjFVVEt5aFF5aTVhZmRS?=
 =?utf-8?B?c3B2L3JwWXRXdkRXSEVUaDhNNUk3N3pqbDdQYkN0WnpMZ2JFYytabVdLajJH?=
 =?utf-8?B?OW5sN1B0WDlQNVBaREdXaE1YQ1QzRmMzd2ljN3lEdzZ1SmR3UmNwdkNnOVFj?=
 =?utf-8?B?NFBMSnR2cGdpbTZOSlYyL0NyWG9IL1VIQUFhR3BpS2tPeXdFemhrd3hXS3VF?=
 =?utf-8?B?S0ZXY1lla0xQeXU2bkFXNGJlUTdDM1cvWlRUeUIvNGNZZTVPSDROU0xsMHR3?=
 =?utf-8?B?QXJVOStQUVlrY0R3S3QvZmpXWlZmYndFQ0VrSTd3Y1hvaDhDeTVDd1haNDdJ?=
 =?utf-8?B?bGJtWEM0RFI1TFNwYlBXY2REcW5Fd0dDL05lYUQxQjN5VUhDaHVCNUNpS3p1?=
 =?utf-8?B?aTdOMXRKQXh1UFMvQ1JTS1F3OFY2WWVzM1J3dnByTzJUNUZoVk9OZkFRVXM1?=
 =?utf-8?B?cjlKRkp6U3BVL3A4MnoxWGRDbXJyV2VHMUFWcm43N1h3UFE3b3QrZm9ER3cw?=
 =?utf-8?B?RVhPNzJIMzE2Z3FXM3ExaWV4dFpMRFRnWlBIdVU3NWpocnM1SWc2cDNvK0dZ?=
 =?utf-8?B?aDFPK1ltQkxOT0l5QkNSY0tDT2VpVHJxSmlNU3NEMVMxb3lXVTB2TURMTllN?=
 =?utf-8?B?S0xoQ3NKZ3pta0xtMFlOSTR4UytUcThpSVhJU3V0NkJjalZueEZxUkpUcE9u?=
 =?utf-8?B?ZDZlV2NqaE1LUWpIbkNsTzRXZzhObGtRN2tUdW93OVFySFVXM0EyQTZWdHd0?=
 =?utf-8?B?TWlwR0paaDJuZ3hucCtKV3ArWlU0N29Td1AvU0kzY3lZZEU1Zkh0dkNnWUpi?=
 =?utf-8?B?TitDNXhhNDRPQmk3YXg3K1QxeHVRUnE3SVo4K2hzcUVwL25aNUZDRkFOTlhV?=
 =?utf-8?B?MmJGZzcyRFA2MFBPVFNGNEdOeDA0MDVWS0x1M3ByZ1lvQ2tMRVVLY0JsdHJW?=
 =?utf-8?B?dDBUN3hteXdLWVRvb2htVEVRRFpmamdDekZubG5PV2x0cHJSN2FYRDZnak1F?=
 =?utf-8?B?bzRUT0RUczIwWGc2RG9nRGFjRE9OOUZDV0RLcmx6RkszZmFJWXN1S3h6R0xv?=
 =?utf-8?B?N1E9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e3bb26c-618f-416d-d360-08db9415c2f0
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:35:39.0819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W4BTVzotBve8YXbgNmH5H6QdfZsFr2CAKKbrHAHKSBDSAhej1+KNbon9gzzJ+0y8xc/IE+S2WrtvRFbQ7q+4+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8001
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/3/23 03:59, Jarkko Sakkinen wrote:
> On Thu Aug 3, 2023 at 4:50 AM EEST, Mario Limonciello wrote:
>> If the TPM is opted out of hwrng the error handling for
>> tpm_chip_register() needs to know this so it doesn't try to clean
>> up an uninitialized chip->hwrng.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/char/tpm/tpm-chip.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
>> index e904aae9771be..8f61b784810d6 100644
>> --- a/drivers/char/tpm/tpm-chip.c
>> +++ b/drivers/char/tpm/tpm-chip.c
>> @@ -629,7 +629,8 @@ int tpm_chip_register(struct tpm_chip *chip)
>>   	return 0;
>>   
>>   out_hwrng:
>> -	if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip))
>> +	if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip) &&
>> +	    !(chip->flags & TPM_CHIP_FLAG_HWRNG_DISABLED))
>>   		hwrng_unregister(&chip->hwrng);
>>   out_ppi:
>>   	tpm_bios_log_teardown(chip);
>> -- 
>> 2.34.1
> 
> Please add a fixes tag.
> 
> BR, Jarkko

I didn't add a fixes tag because you hadn't sent a PR for the other one 
yet so I wasn't sure the hash would be stable.  Also I thought it might 
just make sense to squash into it.

If the hash is now stable, could you just just commit and add that tag 
with it yourself?  Or do you want me to re-send as a v2 with that?