Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230803055611.2343011-1-xiao.w.wang@intel.com>
In-Reply-To: <20230803055611.2343011-1-xiao.w.wang@intel.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 3 Aug 2023 15:41:48 +0200
Message-ID: <CAMj1kXECv+JU-ahvWENk4XRrjxkfBmWoWHhOSdwGpfxC1LVLkg@mail.gmail.com>
Subject: Re: [PATCH] efi/riscv: libstub: Fix comment about absolute relocation
To:     Xiao Wang <xiao.w.wang@intel.com>
Cc:     linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 3 Aug 2023 at 07:48, Xiao Wang <xiao.w.wang@intel.com> wrote:
>
> We don't want absolute symbols references in the stub, so fix the double
> negation in the comment.
>
> Fixes: d7071743db31 ("RISC-V: Add EFI stub support.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>

Queued up in efi/next (without the cc stable)

Thanks,


> ---
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index b0f8c495c10f..ed6e8ebd89b4 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -146,7 +146,7 @@ STUBCOPY_RELOC-$(CONFIG_ARM64)      := R_AARCH64_ABS
>
>  # For RISC-V, we don't need anything special other than arm64. Keep all the
>  # symbols in .init section and make sure that no absolute symbols references
> -# doesn't exist.
> +# exist.
>  STUBCOPY_FLAGS-$(CONFIG_RISCV) += --prefix-alloc-sections=.init \
>                                    --prefix-symbols=__efistub_
>  STUBCOPY_RELOC-$(CONFIG_RISCV) := R_RISCV_HI20
> --
> 2.25.1
>