Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801074430.5179-1-aboutphysycs@gmail.com>
In-Reply-To: <20230801074430.5179-1-aboutphysycs@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Thu, 3 Aug 2023 15:47:17 +0200
Message-ID: <CAMRc=MdCmK4K-KNtnqzuSjgHu-Z1Aai2qAeXikp9mkdQJVuRFA@mail.gmail.com>
Subject: Re: [PATCH] gpio: sifive: remove unneeded call to platform_set_drvdata()
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-gpio@vger.kernel.org, paul.walmsley@sifive.com,
        palmer@dabbelt.com, andy@kernel.org, linus.walleij@linaro.org,
        Alexandru Ardelean <alex@shruggie.ro>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 1, 2023 at 9:44=E2=80=AFAM Andrei Coardos <aboutphysycs@gmail.c=
om> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Als=
o,
> the private data is defined in this driver, so there is no risk of it bei=
ng
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/gpio/gpio-sifive.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
> index c6a8d2374e31..0010f607a9ef 100644
> --- a/drivers/gpio/gpio-sifive.c
> +++ b/drivers/gpio/gpio-sifive.c
> @@ -259,7 +259,6 @@ static int sifive_gpio_probe(struct platform_device *=
pdev)
>         girq->child_to_parent_hwirq =3D sifive_gpio_child_to_parent_hwirq=
;
>         girq->handler =3D handle_bad_irq;
>         girq->default_type =3D IRQ_TYPE_NONE;
> -       platform_set_drvdata(pdev, priv);
>
>         return gpiochip_add_data(&chip->gc, chip);
>  }
> --
> 2.34.1
>

This patch does not correspond with the code upstream. Please verify.

Bart