Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 17:33:47 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, linux-kernel@vger.kernel.org,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Maxim Georgiev <glipus@gmail.com>
Subject: Re: [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio
 can only be attached as root
Message-ID: <20230803143347.7hhn27hzjymdvvw6@skbuf>
References: <20230801182421.1997560-1-vladimir.oltean@nxp.com>
 <20230801182421.1997560-10-vladimir.oltean@nxp.com>
 <87pm4510r0.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pm4510r0.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fBo2/9i06RqPl6appxR4OlstDaJap+/j6yjWDvKE71DeAQ3lIFsHt5FPKWNX?=
 =?us-ascii?Q?3b18JIiQXCWSnfcrm7k6QBECoLlVAGQKFyHMU8DGNIIPQF94DRV5IznmJxhs?=
 =?us-ascii?Q?mDE444qCowwkjIFXw2y988cEy5dtSv+DTvsgFYzmqHVRC0OTZK5g4DrtTwNh?=
 =?us-ascii?Q?9YV/5niqfdhnIUDWIUwpbKbJuU4E3zlJUQfrFNQUqFgIgIHNhe+DGqt3BKxZ?=
 =?us-ascii?Q?CWO8lQ4yU8seaDpzzjMhcRednYY01fyQ7+2nztfw74Y29KVQ6XEK8f7Lc0Q2?=
 =?us-ascii?Q?QBqLH8NRMwmKIYccy5geTGqsuWLqBSCCVLmCWsOW2DHHN+Ooer0UPcyuyWx8?=
 =?us-ascii?Q?RURUCnrY6PCMrYCaYAldFVqyCTxqEmGuZCpbCm6ryr1jr186I/u4OasyIYAR?=
 =?us-ascii?Q?ZeMza4Sk91Jmn1egy4VP+YA7T8b9/ykKBu1Ahs5sBIOIMJ1SlHVtgpU7wxO9?=
 =?us-ascii?Q?YY1jVsm9EBC8QHZZhlkdHYu5xULQQlsU0TQxQ+R4JOgLXqIn6NkeqUMJdcM7?=
 =?us-ascii?Q?eBlU9OHgxcd7eRJ7D6t2FWqgA9//mY019NoYti9AFGxI9Q0YzlxobxVJTqST?=
 =?us-ascii?Q?mL/4AufZdXf8dNwTGQ9osz9z+29pqZ0rqUp0S47KyFAf4q33zKxTnRYw+iPz?=
 =?us-ascii?Q?na3d8pg4ALx9hLabgVjyQ9g0TObEUv3WjkNRIH5Z3NAdBsPGD5hJsd6oZFZs?=
 =?us-ascii?Q?ncAbFn0M2eNp0CvvoqyCyblHFRrGKQmf1UisLQto3Ghe/VFVw5GJW43OmDjr?=
 =?us-ascii?Q?61BWyJWUuLKzVAFc+RmIBisX8oyGv5wHy00plq0+pwm37dos3Od81qbq2AXH?=
 =?us-ascii?Q?pyoZVeG4BiRgFY95RW2E+8KIGOZVabwPBJCSsVh2wl18CCymuYNhc8uEKCsl?=
 =?us-ascii?Q?QB7ZvOOzzzGLv77uCYU+sGEhY3+Hg1jfMKnal5E+CFBB6eIWdxGNmMjM+21B?=
 =?us-ascii?Q?/lHGlJdadAXbNspPl2XEwGljUQKGIBGlpExf5U4lfcqE6LLAKlNcwwdKYCnk?=
 =?us-ascii?Q?Z47/KyxIIoZVfURDtf4lpbJ9jPnXXZ08uflp1PY35kwLU85XjyWY4Bi86x7p?=
 =?us-ascii?Q?VGjI4ejVMeDMiN5akPEHIbVKAk4aOkUVOqS3CZbysLoFgqmqtHx9rfS8/gjU?=
 =?us-ascii?Q?StCspc0oIMRFjK4JBg/4iCyxSJggSc/qeOG7pOzGDKuN6+GPS7ektKuoJMHu?=
 =?us-ascii?Q?pc+l3aaJjiwx+HovaX6XCFHUXDmInFl1Ha7Nrez7nHMu9Pjq2G2Ggy4DNlxg?=
 =?us-ascii?Q?Bg2wPkOyRjr+2Ls8wl9B+rRME7IZPyrOpZ8HBjdGMI1W20yO5pwGY6umRaZv?=
 =?us-ascii?Q?Ki1SYWayeEo/eJnw5ouIgy2qniR2XkyZxTf0GCeX2vjNoGDMdzuC6kVjq+zH?=
 =?us-ascii?Q?c3VK8V6iAMSH8i2iz3j7kLZdU2SjFq2S/B6fs6SJCDOmmJVe2lF6aRI1v0oo?=
 =?us-ascii?Q?zW/oDneLhLswqHlBdczCUeDLxtV2oFZNK1lRT/gMQo5DIEaGUDCQVZUyJtJk?=
 =?us-ascii?Q?KnCukGyI/C1iGHzzeZF+jG6T8id637cC8N0VsIY8Qipoc5+pgNyf47WVDlNJ?=
 =?us-ascii?Q?+YqedCMNXlpRwyXsmo5/iP2LPKiuokpqKsWDlVWhMX+zCRlmIUKyq6rBbI9E?=
 =?us-ascii?Q?Vw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 461f5ff7-a0b4-40a8-30f5-08db942ea86e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:33:52.0753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 71juRvI85b863rO5OXkrDXGq6yi5k2/oCt3UEFk8ET6vN7Llcx4SpXQH/kOBOItPez5C0MYHrxKMe/VybapIYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7995
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vinicius,

On Wed, Aug 02, 2023 at 04:29:55PM -0700, Vinicius Costa Gomes wrote:
> Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> This test is somehow flaky (all others are fine), 1 in ~4 times, it fails.
> 
> Taking a look at the test I couldn't quickly find out the reason for the
> flakyness.
> 
> Here's the verbose output of one of the failures:
> 
> vcgomes@otc-cfl-clr-30 ~/src/net-next/tools/testing/selftests/tc-testing $ sudo ./tdc.py -e 39b4 -v
> All test results:
> 
> 1..1
> not ok 1 39b4 - Reject grafting taprio as child qdisc of software taprio
> 	Could not match regex pattern. Verify command output:
> parse error: Objects must consist of key:value pairs at line 1, column 334

Interesting. I'm not seeing this, and I re-ran it a few times. The error
message seems to come from jq, as if it's not able to parse something.

Sorry, I only have caveman debugging techniques. Could you remove the
pipe into jq and rerun a few times, see what it prints when it fails?

diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/taprio.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/taprio.json
index de51408544e2..bb6be1f78e31 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/taprio.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/taprio.json
@@ -148,8 +148,8 @@
         ],
         "cmdUnderTest": "$TC qdisc replace dev $ETH parent 8001:7 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 200 sched-entry S ff 20000000 clockid CLOCK_TAI",
         "expExitCode": "2",
-        "verifyCmd": "$TC -j qdisc show dev $ETH root | jq '.[].options.base_time'",
-        "matchPattern": "0",
+        "verifyCmd": "$TC -j qdisc show dev $ETH root",
+        "matchPattern": "\\[{\"kind\":\"taprio\",\"handle\":\"8001:\",\"root\":true,\"refcnt\":9,\"options\":{\"tc\":0,\"map\":\\[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0\\],\"queues\":\\[\\],\"clockid\":\"TAI\",\"base_time\":0,\"cycle_time\":20000000,\"cycle_time_extension\":0,\"schedule\":\\[{\"index\":0,\"cmd\":\"S\",\"gatemask\":\"0xff\",\"interval\":20000000}\\],\"max-sdu\":\\[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0\\],\"fp\":\\[\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\",\"E\"\\]}}\\]",
         "matchCount": "1",
         "teardown": [
             "$TC qdisc del dev $ETH root",